You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by echarles <gi...@git.apache.org> on 2016/05/30 15:35:52 UTC

[GitHub] incubator-zeppelin pull request: Remove unnedeed commons-exec decl...

GitHub user echarles opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/931

    Remove unnedeed commons-exec declaration in scope test [ZEPPELIN-904]

    ### What is this PR for?
    zeppelin-server should simply rely on transitive commons-exec from zeppelin-interpreter.
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN/ZEPPELIN-533
    
    ### How should this be tested?
    Simply build
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? N
    * Is there breaking changes for older versions? N
    * Does this needs documentation? N
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/datalayer/zeppelin-datalayer commons-exec-compile-scope

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/931.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #931
    
----
commit b791ba723a173e2266c39b272cbf52b59f6ba76e
Author: Eric Charles <er...@datalayer.io>
Date:   2016-05-30T15:34:08Z

    remove unnedeed commons-exec declaration in scope test

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request #931: Remove unnedeed commons-exec declarati...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/931


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Remove unnedeed commons-exec decl...

Posted by jongyoul <gi...@git.apache.org>.

Github user jongyoul commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/931#issuecomment-222580712
  
    LGTM. Merging if there's no more discussion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Remove unnedeed commons-exec decl...

Posted by cloverhearts <gi...@git.apache.org>.

Github user cloverhearts commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/931#issuecomment-222581135
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Remove unnedeed commons-exec decl...

Posted by bzz <gi...@git.apache.org>.

Github user bzz commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/931#issuecomment-222581686
  
    Looks great to me


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---