You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "QazCetelic (via GitHub)" <gi...@apache.org> on 2026/07/05 07:16:09 UTC
[PR] Set shared capability of Mini Moka and OPFS [opendal]
QazCetelic opened a new pull request, #7856:
URL: https://github.com/apache/opendal/pull/7856
# Which issue does this PR close?
Closes #7855.
# Rationale for this change
The shared capability flag is set for all other services, but is missing for OPFS and Mini Moka.
The choice to mark one shared and the other not is based on [Xuanwo's definition in this comment](https://github.com/apache/opendal/pull/5324#issuecomment-2480461643).
# What changes are included in this PR?
1. [Set mini moka backend shared capability to false](https://github.com/apache/opendal/commit/c3c277afbe3bf0694512ca6d133454be51b3dfbc)
2. [Set opfs backend shared capability to true](https://github.com/apache/opendal/commit/b5503c5caf3ae1636a3873ed98c48710df01a1d2)
# Are there any user-facing changes?
`opfs` shared capability becomes true instead of defaulting to false.
# AI Usage Statement
No AI used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Set shared capability of Mini Moka and OPFS [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #7856:
URL: https://github.com/apache/opendal/pull/7856#discussion_r3527266146
##########
core/services/mini_moka/src/backend.rs:
##########
@@ -135,6 +135,7 @@ impl MiniMokaBackend {
write_can_empty: true,
delete: true,
list: true,
+ shared: false,
Review Comment:
false doesn't need to be set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Set shared capability of Mini Moka and OPFS [opendal]
Posted by "QazCetelic (via GitHub)" <gi...@apache.org>.
QazCetelic commented on code in PR #7856:
URL: https://github.com/apache/opendal/pull/7856#discussion_r3563677254
##########
core/services/mini_moka/src/backend.rs:
##########
@@ -135,6 +135,7 @@ impl MiniMokaBackend {
write_can_empty: true,
delete: true,
list: true,
+ shared: false,
Review Comment:
I've added it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Set shared capability of Mini Moka and OPFS [opendal]
Posted by "erickguan (via GitHub)" <gi...@apache.org>.
erickguan commented on code in PR #7856:
URL: https://github.com/apache/opendal/pull/7856#discussion_r3562737333
##########
core/services/mini_moka/src/backend.rs:
##########
@@ -135,6 +135,7 @@ impl MiniMokaBackend {
write_can_empty: true,
delete: true,
list: true,
+ shared: false,
Review Comment:
Please do, we can rely on documentation (websites) for lists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Set shared capability of Mini Moka and OPFS [opendal]
Posted by "erickguan (via GitHub)" <gi...@apache.org>.
erickguan merged PR #7856:
URL: https://github.com/apache/opendal/pull/7856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Set shared capability of Mini Moka and OPFS [opendal]
Posted by "QazCetelic (via GitHub)" <gi...@apache.org>.
QazCetelic commented on code in PR #7856:
URL: https://github.com/apache/opendal/pull/7856#discussion_r3530830686
##########
core/services/mini_moka/src/backend.rs:
##########
@@ -135,6 +135,7 @@ impl MiniMokaBackend {
write_can_empty: true,
delete: true,
list: true,
+ shared: false,
Review Comment:
Yes, I decided to also set it because all other services also explicitly set it to false.
https://github.com/apache/opendal/blob/4f1df1216b0ecb8f2a1ba331dc82364ba957c732/core/services/cacache/src/backend.rs#L65
https://github.com/apache/opendal/blob/4f1df1216b0ecb8f2a1ba331dc82364ba957c732/core/services/cloudflare-kv/src/backend.rs#L174
https://github.com/apache/opendal/blob/4f1df1216b0ecb8f2a1ba331dc82364ba957c732/core/services/dashmap/src/backend.rs#L101
https://github.com/apache/opendal/blob/4f1df1216b0ecb8f2a1ba331dc82364ba957c732/core/services/moka/src/backend.rs#L205
https://github.com/apache/opendal/blob/4f1df1216b0ecb8f2a1ba331dc82364ba957c732/core/services/persy/src/backend.rs#L139
https://github.com/apache/opendal/blob/4f1df1216b0ecb8f2a1ba331dc82364ba957c732/core/services/redb/src/backend.rs#L151
https://github.com/apache/opendal/blob/4f1df1216b0ecb8f2a1ba331dc82364ba957c732/core/services/rocksdb/src/backend.rs#L101
https://github.com/apache/opendal/blob/4f1df1216b0ecb8f2a1ba331dc82364ba957c732/core/services/sled/src/backend.rs#L125
https://github.com/apache/opendal/blob/4f1df1216b0ecb8f2a1ba331dc82364ba957c732/core/services/sqlite/src/backend.rs#L191
I can add a commit to remove those lines if you'd prefer avoiding setting implicitly defined capabilities.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org