You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/12 19:35:42 UTC
[GitHub] [superset] junlincc opened a new issue #12469: [explore]chart save modal scroll and dropdown
junlincc opened a new issue #12469:
URL: https://github.com/apache/superset/issues/12469
https://user-images.githubusercontent.com/67837651/104363247-c5493100-54c9-11eb-9b6f-ded5f033985c.mp4
related to https://github.com/apache/superset/issues/12310(fixed issues in dashboard)
obviously this behavior is global in Superset. addressing in one modal is not enough
@adam-stasiak pls give around of audit in the product and look for all areas that are being affected, and list those in comment. 🙏
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido edited a comment on issue #12469: [explore]chart save modal scroll and dropdown
Posted by GitBox <gi...@apache.org>.
geido edited a comment on issue #12469:
URL: https://github.com/apache/superset/issues/12469#issuecomment-759704237
> obviously this behavior is global in Superset. addressing in one modal is not enough
We must be careful here though @junlincc. The most common solution might be to introduce the overflow visibility. However, we might end up in a situation like the one depicted here https://github.com/apache/superset/pull/11770#issuecomment-741438519
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kkucharc commented on issue #12469: [explore]chart save modal scroll and dropdown
Posted by GitBox <gi...@apache.org>.
kkucharc commented on issue #12469:
URL: https://github.com/apache/superset/issues/12469#issuecomment-759527290
I mentioned this issue in exiting [PR-12410](https://github.com/apache/superset/pull/12410). After small change it will address problem from the video. Thanks to @geido 's work we may save a lot of time when we detect similar dropdown issues :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on issue #12469: [explore]chart save modal scroll and dropdown
Posted by GitBox <gi...@apache.org>.
geido commented on issue #12469:
URL: https://github.com/apache/superset/issues/12469#issuecomment-759704237
> obviously this behavior is global in Superset. addressing in one modal is not enough
We must be careful here though @junlincc. The most common solution might be to introduce the overflow visibility, however we might end up in a situation like the one depicted here https://github.com/apache/superset/pull/11770#issuecomment-741438519
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on issue #12469: [explore]chart save modal scroll and dropdown
Posted by GitBox <gi...@apache.org>.
geido commented on issue #12469:
URL: https://github.com/apache/superset/issues/12469#issuecomment-759716716
I am attempting a solution for this that uses the overflow visibility but in a way that should not reintroduce other issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #12469: [explore]chart save modal scroll and dropdown
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12469:
URL: https://github.com/apache/superset/issues/12469#issuecomment-762095133
resolved
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc closed issue #12469: [explore]chart save modal scroll and dropdown
Posted by GitBox <gi...@apache.org>.
junlincc closed issue #12469:
URL: https://github.com/apache/superset/issues/12469
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org