You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "kirklund (GitHub)" <gi...@apache.org> on 2019/04/04 16:14:43 UTC
[GitHub] [geode] kirklund opened pull request #3405: GEODE-6534:
Remove unnecessary uses of this in LocalRegion
[ Full content available at: https://github.com/apache/geode/pull/3405 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] kirklund commented on pull request #3405:
GEODE-6534: Remove unnecessary uses of this in LocalRegion
Posted by "kirklund (GitHub)" <gi...@apache.org>.
I'll try to strip out non-useful comments soon as well. This was IntelliJ automating the removal of unnecessary uses of this.
[ Full content available at: https://github.com/apache/geode/pull/3405 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] kirklund closed pull request #3405: GEODE-6534:
Remove unnecessary uses of this in LocalRegion
Posted by "kirklund (GitHub)" <gi...@apache.org>.
[ pull request closed by kirklund ]
[ Full content available at: https://github.com/apache/geode/pull/3405 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] moleske commented on pull request #3405: GEODE-6534:
Remove unnecessary uses of this in LocalRegion
Posted by "moleske (GitHub)" <gi...@apache.org>.
With all of the prechecks green and the fact this was all automated replaces I wouldn't fret too hard...
[ Full content available at: https://github.com/apache/geode/pull/3405 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] pivotal-jbarrett commented on pull request #3405:
GEODE-6534: Remove unnecessary uses of this in LocalRegion
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
I assume the code around here was touched with search and replace but if you were in this area of code manually I would like to see comments like this stripped out. If there is some context from the bug that needs to be expressed here in a meaningful way then I would replace the comment. Generally though these comments just need pruning.
[ Full content available at: https://github.com/apache/geode/pull/3405 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] pivotal-jbarrett commented on pull request #3405:
GEODE-6534: Remove unnecessary uses of this in LocalRegion
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
I would wack this comment because the code is expressing this same message.
[ Full content available at: https://github.com/apache/geode/pull/3405 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org