You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by lg...@apache.org on 2020/06/05 02:32:54 UTC
[incubator-dolphinscheduler] branch dev-1.3.0 updated: fix bug:
sqoop mysql import params error (#2896)
This is an automated email from the ASF dual-hosted git repository.
lgcareer pushed a commit to branch dev-1.3.0
in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git
The following commit(s) were added to refs/heads/dev-1.3.0 by this push:
new b5eb9fe fix bug: sqoop mysql import params error (#2896)
b5eb9fe is described below
commit b5eb9fe4759c155944a68d9a1acba9d5e496995d
Author: Yelli <am...@my.com>
AuthorDate: Fri Jun 5 10:32:35 2020 +0800
fix bug: sqoop mysql import params error (#2896)
* fix bug: sqoop mysql import params error
* fix bug: sqoop mysql import params error
---
.../sqoop/generator/sources/MysqlSourceGenerator.java | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sqoop/generator/sources/MysqlSourceGenerator.java b/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sqoop/generator/sources/MysqlSourceGenerator.java
index f8e3d57..8cd5357 100644
--- a/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sqoop/generator/sources/MysqlSourceGenerator.java
+++ b/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sqoop/generator/sources/MysqlSourceGenerator.java
@@ -77,35 +77,35 @@ public class MysqlSourceGenerator implements ISourceGenerator {
}else{
srcQuery += " WHERE $CONDITIONS";
}
- result.append(" --query \'"+srcQuery+"\'");
+ result.append(" --query \'").append(srcQuery).append("\'");
}
List<Property> mapColumnHive = sourceMysqlParameter.getMapColumnHive();
if(mapColumnHive != null && !mapColumnHive.isEmpty()){
- String columnMap = "";
+ StringBuilder columnMap = new StringBuilder();
for(Property item:mapColumnHive){
- columnMap = item.getProp()+"="+ item.getValue()+",";
+ columnMap.append(item.getProp()).append("=").append(item.getValue()).append(",");
}
- if(StringUtils.isNotEmpty(columnMap)){
+ if(StringUtils.isNotEmpty(columnMap.toString())){
result.append(" --map-column-hive ")
- .append(columnMap.substring(0,columnMap.length()-1));
+ .append(columnMap.substring(0,columnMap.length() - 1));
}
}
List<Property> mapColumnJava = sourceMysqlParameter.getMapColumnJava();
if(mapColumnJava != null && !mapColumnJava.isEmpty()){
- String columnMap = "";
+ StringBuilder columnMap = new StringBuilder();
for(Property item:mapColumnJava){
- columnMap = item.getProp()+"="+ item.getValue()+",";
+ columnMap.append(item.getProp()).append("=").append(item.getValue()).append(",");
}
- if(StringUtils.isNotEmpty(columnMap)){
+ if(StringUtils.isNotEmpty(columnMap.toString())){
result.append(" --map-column-java ")
- .append(columnMap.substring(0,columnMap.length()-1));
+ .append(columnMap.substring(0,columnMap.length() - 1));
}
}
}