You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/05/04 06:20:31 UTC

[GitHub] [pulsar] truongninh opened a new pull request #10475: Improve transaction-api.md

truongninh opened a new pull request #10475:
URL: https://github.com/apache/pulsar/pull/10475


   Added note to enable transaction support in standalone mode.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #10475: [Documentation] Improve transaction-api.md

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #10475:
URL: https://github.com/apache/pulsar/pull/10475#issuecomment-903379178


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijia-w commented on pull request #10475: [Documentation] Improve transaction-api.md

Posted by GitBox <gi...@apache.org>.
sijia-w commented on pull request #10475:
URL: https://github.com/apache/pulsar/pull/10475#issuecomment-954218262


   @Anonymitaet Briefly speaking, I should resolve the conflicts in this pr by contacting the eng and then opening a new one. Is this correct?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #10475: [Documentation] Improve transaction-api.md

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #10475:
URL: https://github.com/apache/pulsar/pull/10475#issuecomment-952496491


   @sijia-w since we have a different doc architecture for the transaction (https://pulsar.apache.org/docs/en/next/txn-use/), can you help check the tech details with engineers and then open a new PR to update docs? Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #10475: [Documentation] Improve transaction-api.md

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #10475:
URL: https://github.com/apache/pulsar/pull/10475#issuecomment-904296974


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet closed pull request #10475: [Documentation] Improve transaction-api.md

Posted by GitBox <gi...@apache.org>.
Anonymitaet closed pull request #10475:
URL: https://github.com/apache/pulsar/pull/10475


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #10475: [Documentation] Improve transaction-api.md

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #10475:
URL: https://github.com/apache/pulsar/pull/10475#issuecomment-966165566


   Close this PR since transaction doc has been udpated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #10475: [Documentation] Improve transaction-api.md

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #10475:
URL: https://github.com/apache/pulsar/pull/10475#issuecomment-954363432


   @sijia-w just ignore this PR and open a new PR to update docs (you can double check the tech details with @congbobo184). After merging your new PR, you can close this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] congbobo184 commented on pull request #10475: [Documentation] Improve transaction-api.md

Posted by GitBox <gi...@apache.org>.
congbobo184 commented on pull request #10475:
URL: https://github.com/apache/pulsar/pull/10475#issuecomment-954388707


   ![image](https://user-images.githubusercontent.com/39078850/139367222-33c98884-35a2-437e-ac39-5e78a3709ac6.png)
   can change `Change the configuration in the `broker.conf` file.` to `Change the configuration in the `broker.conf` or standalone.conf file.` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijia-w commented on pull request #10475: [Documentation] Improve transaction-api.md

Posted by GitBox <gi...@apache.org>.
sijia-w commented on pull request #10475:
URL: https://github.com/apache/pulsar/pull/10475#issuecomment-954499989


   @congbobo184 Sure. Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #10475: [Documentation] Improve transaction-api.md

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #10475:
URL: https://github.com/apache/pulsar/pull/10475#issuecomment-903380711


   Hi @truongninh can you re-run the tests? After the tests pass successfully, we can merge this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org