[GitHub] [jackrabbit-filevault] tripodsan commented on a change in pull request #163: JCRVLT-549 - node cannot be deleted if it's a multi-mandatory child node

[GitBox <gi...@apache.org>]

tripodsan commented on a change in pull request #163:
URL: https://github.com/apache/jackrabbit-filevault/pull/163#discussion_r722039799



##########
File path: vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java
##########
@@ -1295,6 +1300,26 @@ public void endElement(String uri, String localName, String qName) throws SAXExc
         }
     }
 
+    private int getNumChildrenWithType(Node parent, Node child) throws RepositoryException {

Review comment:
       the problem is, that a node can only be deleted, if there are more than one child nodes with the respective type.
   so this method needs to count. but as an optimization, the counting can be aborted when there are found 2.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org