You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/11 08:30:17 UTC

[GitHub] [doris] Kikyou1997 opened a new pull request, #15817: [fix](planner) move join reorder to the single node planner

Kikyou1997 opened a new pull request, #15817:
URL: https://github.com/apache/doris/pull/15817

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem summary
   
   Describe your changes.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [ ] Yes
       - [ ] No
       - [ ] I don't know
   2. Has unit tests been added:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   3. Has document been added or modified:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   4. Does it need to update dependencies:
       - [ ] Yes
       - [ ] No
   5. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [ ] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #15817: [fix](planner) move join reorder to the single node planner

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15817:
URL: https://github.com/apache/doris/pull/15817#issuecomment-1380064685

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] hello-stephen commented on pull request #15817: [fix](planner) move join reorder to the single node planner

Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15817:
URL: https://github.com/apache/doris/pull/15817#issuecomment-1378582715

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 35.1 seconds
    load time: 498 seconds
    storage size: 17122379509 Bytes
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230111110612_clickbench_pr_77611.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] morrySnow merged pull request #15817: [fix](planner) move join reorder to the single node planner

Posted by GitBox <gi...@apache.org>.
morrySnow merged PR #15817:
URL: https://github.com/apache/doris/pull/15817


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #15817: [fix](planner) move join reorder to the single node planner

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15817:
URL: https://github.com/apache/doris/pull/15817#issuecomment-1380064803

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #15817: [fix](planner) move join reorder to the single node planner

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15817:
URL: https://github.com/apache/doris/pull/15817#issuecomment-1378397504

   #### `sh-checker report`
   
   To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/3891007781") output.
   
   <details>
   <summary>shellcheck errors</summary>
   
   ```
   
   'shellcheck ' returned error 1 finding the following syntactical issues:
   
   ----------
   
   In build-support/shell-check.sh line 266:
       content="$(grep 'sh_checker_exclude:' "${DORIS_HOME}/.github/workflows/code-checks.yml")"
                                              ^-----------^ SC2031 (info): DORIS_HOME was modified in a subshell. That change might be lost.
   
   
   In build-support/shell-check.sh line 271:
               if echo "${file:((${#DORIS_HOME} + 1))}" | grep -E "${pattern}" &>/dev/null; then
                                 ^------------^ SC2031 (info): DORIS_HOME was modified in a subshell. That change might be lost.
   
   
   In build-support/shell-check.sh line 289:
       pushd "${DORIS_HOME}" >/dev/null
              ^-----------^ SC2031 (info): DORIS_HOME was modified in a subshell. That change might be lost.
   
   
   In build-support/shell-check.sh line 311:
       read -r -a files < <(find_shell_scripts "${DORIS_HOME}")
                                                ^-----------^ SC2031 (info): DORIS_HOME was modified in a subshell. That change might be lost.
   
   For more information:
     https://www.shellcheck.net/wiki/SC2031 -- DORIS_HOME was modified in a subs...
   ----------
   
   You can address the above issues in one of three ways:
   1. Manually correct the issue in the offending shell script;
   2. Disable specific issues by adding the comment:
     # shellcheck disable=NNNN
   above the line that contains the issue, where NNNN is the error code;
   3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
   
   
   
   ```
   </details>
   
   <details>
   <summary>shfmt errors</summary>
   
   ```
   'shfmt ' found no issues.
   
   ```
   </details>
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org