You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by dawidwys <gi...@git.apache.org> on 2018/05/07 08:45:36 UTC

[GitHub] flink pull request #5960: [Flink-8725] Separate state from NFA in CEP librar...

GitHub user dawidwys opened a pull request:

    https://github.com/apache/flink/pull/5960

    [Flink-8725] Separate state from NFA in CEP library

    ## What is the purpose of the change
    
    * Separate state from NFA, especially do not serialize user classes like `Condition`
    
    ## Brief change log
    
      - Serialize only sharedBuffer and computationStates(without states itself)
      - Implemented migration procedure from old savepoints
    
    
    ## Verifying this change
    
    This change is already covered by existing tests.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
      - The serializers: yes 
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: yes, changed state format for CEP library
      - The S3 file system connector: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented? not applicable


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dawidwys/flink fix-flink-cep-serialization

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5960.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5960
    
----
commit 14edb2657bc6c884a0cfffb4b2226bbaea7a74ea
Author: Aljoscha Krettek <al...@...>
Date:   2018-02-07T12:55:11Z

    [FLINK-8725] Separate state from NFA in CEP library
    
    This also changes the serialization of state to not include the static
    NFA parts and to also not include any user code.

commit d0832031df7534e36cf6d47bab756249fcac9dc7
Author: Dawid Wysakowicz <dw...@...>
Date:   2018-05-04T13:41:27Z

    Reverted backward compatibility with <=1.5

----


---

[GitHub] flink issue #5960: [Flink-8725] Separate state from NFA in CEP library

Posted by kl0u <gi...@git.apache.org>.

Github user kl0u commented on the issue:

    https://github.com/apache/flink/pull/5960
  
    @dawidwys Also when you merge the other one, could you also close this PR?


---

[GitHub] flink pull request #5960: [Flink-8725] Separate state from NFA in CEP librar...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5960


---

[GitHub] flink issue #5960: [Flink-8725] Separate state from NFA in CEP library

Posted by dawidwys <gi...@git.apache.org>.

Github user dawidwys commented on the issue:

    https://github.com/apache/flink/pull/5960
  
    @kl0u Could you review those changes? I could use some work done here for the bigger SharedBuffer rewrite.


---