You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "EdColeman (via GitHub)" <gi...@apache.org> on 2023/11/09 00:35:54 UTC
[PR] rename DataLevel tableId() to metaTableId(), doc updates [accumulo]
EdColeman opened a new pull request, #3941:
URL: https://github.com/apache/accumulo/pull/3941
Renames the DataLevel method tableId to metaTableId to help clarify that the id returned is the reference to the meta data that contain information for that level (USER points to metadata table, METADATA points to ROOT and ROOT point to ZooKeeper)
Also adds some javadoc to emphasize the level, meta data relationship for forLevel and forTable in TabletsMetadata
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] rename DataLevel tableId() to metaTableId(), doc updates [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #3941:
URL: https://github.com/apache/accumulo/pull/3941#discussion_r1388191781
##########
core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletsMetadata.java:
##########
@@ -319,13 +319,24 @@ public Options fetch(ColumnType... colsToFetch) {
return this;
}
+ /**
+ * Set the range to the table range that stores the provided level's metadata. For example
+ * {@link DataLevel#USER} will set the range to the metadata table. {@link DataLevel#METADATA}
+ * will set the range to the root table.
+ */
@Override
public Options forLevel(DataLevel level) {
this.level = level;
this.range = TabletsSection.getRange();
return this;
}
+ /**
+ * Set the range to the data level that contains the metadata references for the provided
+ * TableId. For example, if the TableId is the metadata table id, then the table range will be
+ * root metadata that points to the metadata. Likewise, if the TableId is a user table, then the
+ * table range will be the metadata table range that points to the user table.
+ */
Review Comment:
```suggestion
/**
* For a given table read all of its tablet metadata. If the table id is for a user table, then its metadata will be read from its section in the accumulo.metadata table. If the table id is for the accumulo.metadata table, then its metadata will be read from the accumulo.root table. If the table id is for the accumulo.root table, then its metadata will be read from zookeeper.
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] rename DataLevel tableId() to metaTableId(), doc updates [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #3941:
URL: https://github.com/apache/accumulo/pull/3941#discussion_r1388187686
##########
core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletsMetadata.java:
##########
@@ -319,13 +319,24 @@ public Options fetch(ColumnType... colsToFetch) {
return this;
}
+ /**
+ * Set the range to the table range that stores the provided level's metadata. For example
+ * {@link DataLevel#USER} will set the range to the metadata table. {@link DataLevel#METADATA}
+ * will set the range to the root table.
+ */
Review Comment:
```suggestion
/**
* For a given data level, read all of its tablets metadata. For DataLevel.USER this will read tablet metadata from the accumulo.metadata table. For DataLevel.METADATA this will read tablet metadata from the accumulo.root table. For DataLevel.ROOT this will read tablet metadata from Zookeeper.
*/
```
##########
core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletsMetadata.java:
##########
@@ -319,13 +319,24 @@ public Options fetch(ColumnType... colsToFetch) {
return this;
}
+ /**
+ * Set the range to the table range that stores the provided level's metadata. For example
+ * {@link DataLevel#USER} will set the range to the metadata table. {@link DataLevel#METADATA}
+ * will set the range to the root table.
+ */
@Override
public Options forLevel(DataLevel level) {
this.level = level;
this.range = TabletsSection.getRange();
return this;
}
+ /**
+ * Set the range to the data level that contains the metadata references for the provided
+ * TableId. For example, if the TableId is the metadata table id, then the table range will be
+ * root metadata that points to the metadata. Likewise, if the TableId is a user table, then the
+ * table range will be the metadata table range that points to the user table.
+ */
Review Comment:
```suggestion
/**
* For a given table read all of its tablet metadata. If the table id is for a user table, then its metadata will be read from its section in the accumulo.metadata table. If the table is is for the accumulo.metadata table, then its metadata will be read from the accumulo.root table. If the table id is for the accumulo.root table, then its metadata will be read from zookeeper.
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] rename DataLevel tableId() to metaTableId(), doc updates [accumulo]
Posted by "ddanielr (via GitHub)" <gi...@apache.org>.
ddanielr commented on code in PR #3941:
URL: https://github.com/apache/accumulo/pull/3941#discussion_r1387358984
##########
core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletsMetadata.java:
##########
@@ -319,13 +319,24 @@ public Options fetch(ColumnType... colsToFetch) {
return this;
}
+ /**
+ * Set the range to the table range that stores the provided level's metadata. For example
+ * {@link DataLevel#USER} will set the range to the metadata table. {@link DataLevel#METADATA}
+ * will set the range to the root table.
+ */
@Override
public Options forLevel(DataLevel level) {
this.level = level;
this.range = TabletsSection.getRange();
return this;
}
+ /**
+ * Set the range to the data level that contains the metadata references for the provided
+ * TableId. For example, if the TableId is the metadata table id, then the table range will be
+ * root metadata that points to the metadata. Likewise, if the TableId is a user table, then the
Review Comment:
This comment is a bit hard to follow.
Can the metadata table location references be simplified
like `root metadata range` vs `root metadata that points to the metadata`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] rename DataLevel tableId() to metaTableId(), doc updates [accumulo]
Posted by "ddanielr (via GitHub)" <gi...@apache.org>.
ddanielr commented on PR #3941:
URL: https://github.com/apache/accumulo/pull/3941#issuecomment-1804094013
@EdColeman once Keith's documentation suggestions are committed, I think this is good to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] rename DataLevel tableId() to metaTableId(), doc updates [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #3941:
URL: https://github.com/apache/accumulo/pull/3941#discussion_r1388187686
##########
core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletsMetadata.java:
##########
@@ -319,13 +319,24 @@ public Options fetch(ColumnType... colsToFetch) {
return this;
}
+ /**
+ * Set the range to the table range that stores the provided level's metadata. For example
+ * {@link DataLevel#USER} will set the range to the metadata table. {@link DataLevel#METADATA}
+ * will set the range to the root table.
+ */
Review Comment:
```suggestion
/**
* For a given data level, read all of its tablets metadata. For DataLevel.USER this will read tablet metadata from the accumulo.metadata table for all user tables. For DataLevel.METADATA this will read tablet metadata from the accumulo.root table. For DataLevel.ROOT this will read tablet metadata from Zookeeper.
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] rename DataLevel tableId() to metaTableId(), doc updates [accumulo]
Posted by "EdColeman (via GitHub)" <gi...@apache.org>.
EdColeman merged PR #3941:
URL: https://github.com/apache/accumulo/pull/3941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] rename DataLevel tableId() to metaTableId(), doc updates [accumulo]
Posted by "EdColeman (via GitHub)" <gi...@apache.org>.
EdColeman commented on code in PR #3941:
URL: https://github.com/apache/accumulo/pull/3941#discussion_r1387948519
##########
core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletsMetadata.java:
##########
@@ -319,13 +319,24 @@ public Options fetch(ColumnType... colsToFetch) {
return this;
}
+ /**
+ * Set the range to the table range that stores the provided level's metadata. For example
+ * {@link DataLevel#USER} will set the range to the metadata table. {@link DataLevel#METADATA}
+ * will set the range to the root table.
+ */
@Override
public Options forLevel(DataLevel level) {
this.level = level;
this.range = TabletsSection.getRange();
return this;
}
+ /**
+ * Set the range to the data level that contains the metadata references for the provided
+ * TableId. For example, if the TableId is the metadata table id, then the table range will be
+ * root metadata that points to the metadata. Likewise, if the TableId is a user table, then the
Review Comment:
I'm open to suggestions. I was trying to convey that user -> metadata, metadata -> root, and root -> ZooKeeper. One issue is that metadata is overloaded. When we say metadata, is it the table? The information for a level that references point to the next level? Even that last sentence is awkward for me, so if someone has any suggestions I'll happily hit commit suggestion and move on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] rename DataLevel tableId() to metaTableId(), doc updates [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #3941:
URL: https://github.com/apache/accumulo/pull/3941#discussion_r1388191781
##########
core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletsMetadata.java:
##########
@@ -319,13 +319,24 @@ public Options fetch(ColumnType... colsToFetch) {
return this;
}
+ /**
+ * Set the range to the table range that stores the provided level's metadata. For example
+ * {@link DataLevel#USER} will set the range to the metadata table. {@link DataLevel#METADATA}
+ * will set the range to the root table.
+ */
@Override
public Options forLevel(DataLevel level) {
this.level = level;
this.range = TabletsSection.getRange();
return this;
}
+ /**
+ * Set the range to the data level that contains the metadata references for the provided
+ * TableId. For example, if the TableId is the metadata table id, then the table range will be
+ * root metadata that points to the metadata. Likewise, if the TableId is a user table, then the
+ * table range will be the metadata table range that points to the user table.
+ */
Review Comment:
```suggestion
/**
* For a given table read all of its tablet metadata. If the table id is for a user table, then its metadata will be read from its section in the accumulo.metadata table. If the table is is for the accumulo.metadata table, then its metadata will be read from the accumulo.root table. If the table id id for the accumulo.root table, then its metadata will be read from zookeeper.
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org