You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2019/05/30 12:11:00 UTC

[jira] [Commented] (HBASE-22316) Record the stack trace for current thread in FutureUtils.get

    [ https://issues.apache.org/jira/browse/HBASE-22316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851803#comment-16851803 ] 

Hudson commented on HBASE-22316:
--------------------------------

Results for branch master
	[build #1062 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1062/]: (x) *{color:red}-1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/master/1062//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/master/1062//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/master/1062//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 3. [see log for details|https://builds.apache.org/job/HBase%20Nightly/job/master/1062//artifact/output-integration/hadoop-3.log]. (note that this means we didn't check the Hadoop 3 shaded client)


> Record the stack trace for current thread in FutureUtils.get
> ------------------------------------------------------------
>
>                 Key: HBASE-22316
>                 URL: https://issues.apache.org/jira/browse/HBASE-22316
>             Project: HBase
>          Issue Type: Sub-task
>          Components: asyncclient, Client
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>              Labels: async-client
>             Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.6
>
>
> This is for debugging. As in async client, the retry will be done in the retry timer thread, so the exception we get from the CompletableFuture will have a stack trace starting from the root of the retry timer. If we just throw this exception out when calling future.get(by unwrapping the ExecutionException), the upper layer even can not know where is the exception thrown...
> This happens for me many times, so I propose that we always create a new exception in FutureUtils.get, so at least we can record the stack trace for the method calling FutureUtils.get...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)