You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2017/12/20 02:39:51 UTC

[GitHub] sijie closed pull request #892: Misc LedgerHandle changes

sijie closed pull request #892: Misc LedgerHandle changes
URL: https://github.com/apache/bookkeeper/pull/892
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
index 32eeab812..f05876e33 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
@@ -204,7 +204,7 @@ public void safeRun() {
     }
 
     protected void initializeExplicitLacFlushPolicy() {
-        if (!metadata.isClosed() && bk.getExplicitLacInterval() > 0) {
+        if (!metadata.isClosed() && !(this instanceof ReadOnlyLedgerHandle) && bk.getExplicitLacInterval() > 0) {
             explicitLacFlushPolicy = new ExplicitLacFlushPolicy.ExplicitLacFlushPolicyImpl(this);
         } else {
             explicitLacFlushPolicy = ExplicitLacFlushPolicy.VOID_EXPLICITLAC_FLUSH_POLICY;
@@ -324,6 +324,15 @@ public synchronized long getLength() {
         return this.length;
     }
 
+    /**
+     * Returns the ledger creation time.
+     *
+     * @return the ledger creation time
+     */
+    public long getCtime() {
+        return this.metadata.getCtime();
+    }
+
     /**
      * Get the Distribution Schedule.
      *
@@ -1624,6 +1633,8 @@ public void safeOperationComplete(final int rc, Void result) {
 
             // We've successfully changed an ensemble
             ensembleChangeCounter.inc();
+            LOG.info("New Ensemble: {} for ledger: {}", ensembleInfo.newEnsemble, ledgerId);
+
             // the failed bookie has been replaced
             unsetSuccessAndSendWriteRequest(ensembleInfo.replacedBookies);
         }


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services