You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "mengw15 (via GitHub)" <gi...@apache.org> on 2026/08/01 07:05:43 UTC

[PR] test(amber): extend WorkflowExecutionsResource coverage for access-controlled metadata endpoints [texera]

mengw15 opened a new pull request, #7231:
URL: https://github.com/apache/texera/pull/7231

   ### What changes were proposed in this PR?
   
   Extends the existing `MockTexeraDB`-backed `WorkflowExecutionsResourceSpec` to
   cover the previously-untested access-controlled execution-metadata endpoints.
   The result/log-URI and replay paths (`DocumentFactory` / `ReplayLogRecord`) are
   out of scope per the issue — these tests cover the jOOQ-metadata portion of each
   endpoint only.
   
   12 added tests (each seeds only what it needs, so they stay order-independent):
   
   - `retrieveExecutionsOfWorkflow` — empty list when the user lacks read access; the workflow's executions for an authorized user; a `BadRequestException` for an invalid `status` filter.
   - `retrieveLatestExecutionEntry` — `ForbiddenException` when the workflow has no executions; the most-recent entry otherwise.
   - `retrieveInteractionHistory` — empty list when the user lacks read access (the replay branch is out of scope).
   - `setExecutionAreBookmarked` — `WebApplicationException` for a user without access; the bookmark flag toggles both directions.
   - `updateWorkflowExecutionsName` — renames the execution.
   - `groupDeleteExecutionsOfWorkflow` — removes the execution rows (seeded with no URIs so `removeAllExecutionFiles` touches no storage).
   - `retrieveWorkflowRuntimeStatistics` — `NoSuchElementException` when the execution has no runtime-stats URI (the `DocumentFactory` read is out of scope).
   
   Read access is granted by seeding a `WORKFLOW_USER_ACCESS(READ)` row; that row is
   cleaned up in `cleanupTestData` before the `WORKFLOW` row (FK / leak safety). No
   production code was changed.
   
   ### Any related issues, documentation, discussions?
   
   Closes #7226
   
   ### How was this PR tested?
   
   Extended unit tests, run locally against embedded Postgres:
   
   ```
   sbt "WorkflowExecutionService/testOnly org.apache.texera.web.resource.dashboard.user.workflow.WorkflowExecutionsResourceSpec"
   # Tests: succeeded 42, failed 0   (30 existing + 12 new; re-ran for stability)
   sbt "WorkflowExecutionService/Test/scalafmtCheck" "WorkflowExecutionService/Test/scalafix --check"   # clean
   ```
   
   The failure path was verified by deliberately breaking a new assertion and
   confirming the suite goes red (41 succeeded, 1 failed), then restored.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Opus 4.8 [1M context])
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test(amber): extend WorkflowExecutionsResource coverage for access-controlled metadata endpoints [texera]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7231:
URL: https://github.com/apache/texera/pull/7231#issuecomment-5150355687

   ## [Codecov](https://app.codecov.io/gh/apache/texera/pull/7231?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 81.14%. Comparing base ([`18ebb0d`](https://app.codecov.io/gh/apache/texera/commit/18ebb0d1e6dded6f8bc04b7c52be4fa31cb27916?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`61f0e9c`](https://app.codecov.io/gh/apache/texera/commit/61f0e9c2d310a51ec84b3a9e33f9e2c3d271ed9e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 2 commits behind head on main.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##               main    #7231      +/-   ##
   ============================================
   + Coverage     81.04%   81.14%   +0.10%     
   - Complexity     3968     3976       +8     
   ============================================
     Files          1162     1162              
     Lines         46259    46259              
     Branches       5153     5153              
   ============================================
   + Hits          37490    37538      +48     
   + Misses         7096     7042      -54     
   - Partials       1673     1679       +6     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/texera/pull/7231/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
   |---|---|---|---|
   | [access-control-service](https://app.codecov.io/gh/apache/texera/pull/7231/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.00% <ø> (ø)` | | Carriedforward from [18ebb0d](https://app.codecov.io/gh/apache/texera/commit/18ebb0d1e6dded6f8bc04b7c52be4fa31cb27916?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [agent-service](https://app.codecov.io/gh/apache/texera/pull/7231/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.49% <ø> (ø)` | | Carriedforward from [18ebb0d](https://app.codecov.io/gh/apache/texera/commit/18ebb0d1e6dded6f8bc04b7c52be4fa31cb27916?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [amber](https://app.codecov.io/gh/apache/texera/pull/7231/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `76.94% <ø> (+0.28%)` | :arrow_up: | |
   | [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/7231/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `20.49% <ø> (ø)` | | Carriedforward from [18ebb0d](https://app.codecov.io/gh/apache/texera/commit/18ebb0d1e6dded6f8bc04b7c52be4fa31cb27916?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [config-service](https://app.codecov.io/gh/apache/texera/pull/7231/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `65.97% <ø> (ø)` | | Carriedforward from [18ebb0d](https://app.codecov.io/gh/apache/texera/commit/18ebb0d1e6dded6f8bc04b7c52be4fa31cb27916?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [file-service](https://app.codecov.io/gh/apache/texera/pull/7231/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `66.80% <ø> (ø)` | | Carriedforward from [18ebb0d](https://app.codecov.io/gh/apache/texera/commit/18ebb0d1e6dded6f8bc04b7c52be4fa31cb27916?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [frontend](https://app.codecov.io/gh/apache/texera/pull/7231/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.22% <ø> (ø)` | | Carriedforward from [18ebb0d](https://app.codecov.io/gh/apache/texera/commit/18ebb0d1e6dded6f8bc04b7c52be4fa31cb27916?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/7231/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.89% <ø> (ø)` | | Carriedforward from [18ebb0d](https://app.codecov.io/gh/apache/texera/commit/18ebb0d1e6dded6f8bc04b7c52be4fa31cb27916?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [pyamber](https://app.codecov.io/gh/apache/texera/pull/7231/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `97.36% <ø> (ø)` | | Carriedforward from [18ebb0d](https://app.codecov.io/gh/apache/texera/commit/18ebb0d1e6dded6f8bc04b7c52be4fa31cb27916?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/7231/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `26.31% <ø> (ø)` | | Carriedforward from [18ebb0d](https://app.codecov.io/gh/apache/texera/commit/18ebb0d1e6dded6f8bc04b7c52be4fa31cb27916?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/7231?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test(amber): extend WorkflowExecutionsResource coverage for access-controlled metadata endpoints [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7231:
URL: https://github.com/apache/texera/pull/7231#issuecomment-5150346518

   <!-- texera-benchmarks-comment -->
   ## ⚠️ Benchmark changes need a look
   
   🟢 1 better · 🔴 2 worse · ⚪ 12 noise (<±5%) · 0 without baseline
   
   > Compared against main `18ebb0d` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
   
   [Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/30689037071)
   
   | | config | throughput | MB/s | latency | max Δ latest / 7d |
   |---|---|---:|---:|---:|---:|
   | 🟢 | bs=10 sw=10 sl=64 | 423 | 0.258 | 21,860/31,653/31,653 us | 🟢 -8.1% / 🔴 +95.4% |
   | ⚪ | bs=100 sw=10 sl=64 | 834 | 0.509 | 118,950/154,968/154,968 us | ⚪ within ±5% / 🔴 +39.9% |
   | 🔴 | bs=1000 sw=10 sl=64 | 913 | 0.557 | 1,092,733/1,221,304/1,221,304 us | 🔴 +7.9% / 🔴 +14.9% |
   
   <details><summary>Baseline details</summary>
   
   Latest main `18ebb0d` from same runner
   
   | config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
   |---|---|---:|---:|---:|---:|---:|
   | bs=10 sw=10 sl=64 | throughput | 423 tuples/sec | 432 tuples/sec | 765.25 tuples/sec | -2.1% | -44.7% |
   | bs=10 sw=10 sl=64 | MB/s | 0.258 MB/s | 0.264 MB/s | 0.467 MB/s | -2.3% | -44.8% |
   | bs=10 sw=10 sl=64 | p50 | 21,860 us | 23,784 us | 12,703 us | -8.1% | +72.1% |
   | bs=10 sw=10 sl=64 | p95 | 31,653 us | 31,664 us | 16,199 us | -0.0% | +95.4% |
   | bs=10 sw=10 sl=64 | p99 | 31,653 us | 31,664 us | 19,557 us | -0.0% | +61.8% |
   | bs=100 sw=10 sl=64 | throughput | 834 tuples/sec | 832 tuples/sec | 965.22 tuples/sec | +0.2% | -13.6% |
   | bs=100 sw=10 sl=64 | MB/s | 0.509 MB/s | 0.508 MB/s | 0.589 MB/s | +0.2% | -13.6% |
   | bs=100 sw=10 sl=64 | p50 | 118,950 us | 117,869 us | 103,830 us | +0.9% | +14.6% |
   | bs=100 sw=10 sl=64 | p95 | 154,968 us | 149,871 us | 110,778 us | +3.4% | +39.9% |
   | bs=100 sw=10 sl=64 | p99 | 154,968 us | 149,871 us | 118,713 us | +3.4% | +30.5% |
   | bs=1000 sw=10 sl=64 | throughput | 913 tuples/sec | 924 tuples/sec | 992.33 tuples/sec | -1.2% | -8.0% |
   | bs=1000 sw=10 sl=64 | MB/s | 0.557 MB/s | 0.564 MB/s | 0.606 MB/s | -1.2% | -8.0% |
   | bs=1000 sw=10 sl=64 | p50 | 1,092,733 us | 1,083,634 us | 1,016,959 us | +0.8% | +7.5% |
   | bs=1000 sw=10 sl=64 | p95 | 1,221,304 us | 1,131,759 us | 1,062,501 us | +7.9% | +14.9% |
   | bs=1000 sw=10 sl=64 | p99 | 1,221,304 us | 1,131,759 us | 1,082,611 us | +7.9% | +12.8% |
   
   </details>
   
   <details><summary>Raw CSV</summary>
   
   ```csv
   config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
   0,10,10,64,20,472.93,200,128000,423,0.258,21860.15,31652.66,31652.66
   1,100,10,64,20,2399.20,2000,1280000,834,0.509,118950.13,154968.42,154968.42
   2,1000,10,64,20,21914.24,20000,12800000,913,0.557,1092733.32,1221303.55,1221303.55
   ```
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test(amber): extend WorkflowExecutionsResource coverage for access-controlled metadata endpoints [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7231:
URL: https://github.com/apache/texera/pull/7231#issuecomment-5150321996

   <!-- texera-reviewer-suggestion -->
   ### Automated Reviewer Suggestions
   
   Based on the `git blame` history of the changed files, we recommend the following reviewers:
   
   - No candidates found from `git blame` history.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test(amber): extend WorkflowExecutionsResource coverage for access-controlled metadata endpoints [texera]

Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #7231:
URL: https://github.com/apache/texera/pull/7231


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org