You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/06 01:52:52 UTC
[GitHub] [spark] AngersZhuuuu opened a new pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles about task summary about Web UI and restful API
AngersZhuuuu opened a new pull request #31048:
URL: https://github.com/apache/spark/pull/31048
### What changes were proposed in this pull request?
We should keep same quantiles about task summary about Web UI and Restful API
The direct result of resuful API is not same with Web UI is confusing. We'd better to keep same.
### Why are the changes needed?
Keep same result between restful API and web ui
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Existed UI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu edited a comment on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu edited a comment on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756612675
> Yes, I understand.
> I mean the change seems reasonable to align to the UI.
Ur, you mean change UI to be consistent with RestFul API. Is there any discuss about why use `0.05,0.25,0.5,0.75,0.95`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756813112
**[Test build #133846 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133846/testReport)** for PR 31048 at commit [`ed53e30`](https://github.com/apache/spark/commit/ed53e3063173613cfa7353b0de6421deb951d33b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-755128529
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133706/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756813112
**[Test build #133846 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133846/testReport)** for PR 31048 at commit [`ed53e30`](https://github.com/apache/spark/commit/ed53e3063173613cfa7353b0de6421deb951d33b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu edited a comment on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu edited a comment on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756788354
> those are just default values so the user can change what they request. Normally I would agree that keeping the same makes sense. I tried to go back to see if there was a reason it was made this way but didn't see any comments on it.
>
> One question is whether this is a breaking change because users that do this will now get a different result. thoughts from others? Ideally it doesn't matter as they would check what the quantiles are but if they aren't it would be different results.
Yea, and default value is not show in [monitoring page](https://spark.apache.org/docs/3.0.0/monitoring.html) and user will see ui's quantiles in Web UI. They may think the are same. we need to add this default value to monitoring page too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756610727
> The UI for a stage shows `0,0`, `0.25`, `0.50`, `0.75` and `1.0` percentiles so it seems to be consistent.
> https://github.com/apache/spark/blob/cc201545626ffe556682f45edc370ac6fe29e9df/core/src/main/resources/org/apache/spark/ui/static/stagepage.js#L180-L212
But restful is `0.05,0.25,0.5,0.75,0.95`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-755066995
**[Test build #133706 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133706/testReport)** for PR 31048 at commit [`6ae763e`](https://github.com/apache/spark/commit/6ae763e6f2019d6b25ebfcd1c0dea473f923fae0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles about task summary about Web UI and restful API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-755030542
**[Test build #133696 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133696/testReport)** for PR 31048 at commit [`c0e05b7`](https://github.com/apache/spark/commit/c0e05b72a146d3da0d024e46d1d97a40e72e4a2a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756620060
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756700566
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133830/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-759146015
> I'm more on the side of putting it into a 4.0 since it could break someone and if someone doesn't like it they just set what they want.
Ok, wait for spark 4.0 release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756608101
The UI for a stage shows `0,0`, `0.25`, `0.50`, `0.75` and `1.0` percentiles so it seems to be consistent.
https://github.com/apache/spark/blob/cc201545626ffe556682f45edc370ac6fe29e9df/core/src/main/resources/org/apache/spark/ui/static/stagepage.js#L180-L212
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756672353
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756700566
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133830/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756773764
> What does the UI look like before and after? what is in the REST API not in the UI?
The problem is :
1. In spark web ui task summary the quantiles is `0.0.0.25,0.5,0.75,1.0`
2. In restful API /applications/[app-id]/stages/[stage-id]/[stage-attempt-id]/taskSummary the quantiles is `0.05,0.25,0.5,0.75,1.0`
The result is not same, we'd better keep it consistent
For one APP running in our env, stage=4 & stageAttemptId=0
We can see the scheduler delay. the value is not same.
<img width="1377" alt="Screen Shot 2021-01-08 at 10 03 21 PM" src="https://user-images.githubusercontent.com/46485123/104024432-11f8e780-51fe-11eb-92b8-dd84a550d829.png">
<img width="1310" alt="Screen Shot 2021-01-08 at 10 03 46 PM" src="https://user-images.githubusercontent.com/46485123/104024442-16250500-51fe-11eb-9dc0-7a8a93fae176.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756788354
> those are just default values so the user can change what they request. Normally I would agree that keeping the same makes sense. I tried to go back to see if there was a reason it was made this way but didn't see any comments on it.
>
> One question is whether this is a breaking change because users that do this will now get a different result. thoughts from others? Ideally it doesn't matter as they would check what the quantiles are but if they aren't it would be different results.
Yea, and default value is not show in [monitoring page](https://spark.apache.org/docs/3.0.0/monitoring.html) and user will see ui's quantiles in Web UI. They may think the are same. we need to add this default to monitoring page too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-755066995
**[Test build #133706 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133706/testReport)** for PR 31048 at commit [`6ae763e`](https://github.com/apache/spark/commit/6ae763e6f2019d6b25ebfcd1c0dea473f923fae0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-755064462
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38284/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
tgravescs commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756783846
those are just default values so the user can change what they request. Normally I would agree that keeping the same makes sense. I tried to go back to see if there was a reason it was made this way but didn't see any comments on it.
One question is whether this is a breaking change because users that do this will now get a different result. thoughts from others? Ideally it doesn't matter as they would check what the quantiles are but if they aren't it would be different results.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-755128529
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133706/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-755084609
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38294/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756613343
I saw the [past PR](https://github.com/apache/spark/pull/5940) but I don't see the discussion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756637779
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38419/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu edited a comment on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu edited a comment on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756773764
> What does the UI look like before and after? what is in the REST API not in the UI?
The problem is :
1. In spark web ui task summary the quantiles is `0.0.0.25,0.5,0.75,1.0`
2. In restful API /applications/[app-id]/stages/[stage-id]/[stage-attempt-id]/taskSummary the quantiles is `0.05,0.25,0.5,0.75,0.95`
The result is not same, we'd better keep it consistent
For one APP running in our env, stage=4 & stageAttemptId=0
We can see the scheduler delay. the value is not same.
<img width="1377" alt="Screen Shot 2021-01-08 at 10 03 21 PM" src="https://user-images.githubusercontent.com/46485123/104024432-11f8e780-51fe-11eb-92b8-dd84a550d829.png">
<img width="1310" alt="Screen Shot 2021-01-08 at 10 03 46 PM" src="https://user-images.githubusercontent.com/46485123/104024442-16250500-51fe-11eb-9dc0-7a8a93fae176.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756845709
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38435/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756672353
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38419/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756834917
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38435/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #31048:
URL: https://github.com/apache/spark/pull/31048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756917941
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133846/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-755102368
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38294/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756672353
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38419/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-755080857
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133696/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-755030542
**[Test build #133696 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133696/testReport)** for PR 31048 at commit [`c0e05b7`](https://github.com/apache/spark/commit/c0e05b72a146d3da0d024e46d1d97a40e72e4a2a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
tgravescs commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756783846
those are just default values so the user can change what they request. Normally I would agree that keeping the same makes sense. I tried to go back to see if there was a reason it was made this way but didn't see any comments on it.
One question is whether this is a breaking change because users that do this will now get a different result. thoughts from others? Ideally it doesn't matter as they would check what the quantiles are but if they aren't it would be different results.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-755127511
**[Test build #133706 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133706/testReport)** for PR 31048 at commit [`6ae763e`](https://github.com/apache/spark/commit/6ae763e6f2019d6b25ebfcd1c0dea473f923fae0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756612675
> Yes, I understand.
> I mean the change seems reasonable to align to the UI.
Ur, you mean change UI to be consistent with RestFul API. Is there any discuss about why use `0.05,0.25,0.5,0.75,0.95`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-755080857
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133696/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles about task summary about Web UI and restful API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-755042476
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38284/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756651374
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38419/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles about task summary about Web UI and restful API
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-755024502
ping @gengliangwang @sarutak
found this when we discuss about https://github.com/apache/spark/pull/31001#discussion_r551530183
We should keep all consistent. also. cc @ron8hu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756620060
**[Test build #133830 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133830/testReport)** for PR 31048 at commit [`6ae763e`](https://github.com/apache/spark/commit/6ae763e6f2019d6b25ebfcd1c0dea473f923fae0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles about task summary about Web UI and restful API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-755049806
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38284/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756615560
> > Ur, you mean change UI to be consistent with RestFul API. Is there any discuss about why use 0.05,0.25,0.5,0.75,0.95?
>
> No, I don't think it's necessary to change the UI. This change seems reasonable to conform to the UI.
> I saw the [past PR](https://github.com/apache/spark/pull/5940) but I don't see the discussion about the quantile.
Yea
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756611986
> But restful is 0.05,0.25,0.5,0.75,0.95
Yes, I understand.
I mean the change seems reasonable to align to the UI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756611986
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756690976
**[Test build #133830 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133830/testReport)** for PR 31048 at commit [`6ae763e`](https://github.com/apache/spark/commit/6ae763e6f2019d6b25ebfcd1c0dea473f923fae0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756620060
**[Test build #133830 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133830/testReport)** for PR 31048 at commit [`6ae763e`](https://github.com/apache/spark/commit/6ae763e6f2019d6b25ebfcd1c0dea473f923fae0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu edited a comment on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu edited a comment on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756612675
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756608101
The UI for a stage shows `0,0`, `0.25`, `0.50`, `0.75` and `1.0` percentiles so it seems to be consistent.
https://github.com/apache/spark/blob/master/core/src/main/resources/org/apache/spark/ui/static/stagepage.js#L180
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756792609
I see, OK. Yes I agree the default should be consistent with the UI, but, it is a minor breaking change, I suppose. I wonder if it's worth it, or needs to wait until Spark 4. Open to dev@ if you like for visibility and comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756917941
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133846/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #31048:
URL: https://github.com/apache/spark/pull/31048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-755072128
**[Test build #133696 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133696/testReport)** for PR 31048 at commit [`c0e05b7`](https://github.com/apache/spark/commit/c0e05b72a146d3da0d024e46d1d97a40e72e4a2a).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756613343
> Ur, you mean change UI to be consistent with RestFul API. Is there any discuss about why use 0.05,0.25,0.5,0.75,0.95?
No, I don't think it's necessary to change the UI. This change seems reasonable to conform to the UI.
I saw the [past PR](https://github.com/apache/spark/pull/5940) but I don't see the discussion about the quantile.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756617137
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756608101
The UI for a stage shows `0,0`, `0.25`, `0.50`, `0.75` and `1.0` percentiles so it seems to be consistent.
https://github.com/apache/spark/blob/cc201545626ffe556682f45edc370ac6fe29e9df/core/src/main/resources/org/apache/spark/ui/static/stagepage.js#L180
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756608101
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-826002227
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756601367
ping @squito @dongjoon-hyun @srowen @tgravescs since you have commit to this part.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756845709
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38435/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-755064462
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38284/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756837490
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38435/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756672353
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-758336280
Seems got no reply from other dev, emmmm, What should I do next？ ping @srowen @gengliangwang @sarutak @tgravescs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756610727
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756620060
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-757828373
Though it's a minor breaking change, I think it makes more sense to be consistent with the UI and show Min/Max instead of 0.05/0.95 quantiles.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756611986
> But restful is 0.05,0.25,0.5,0.75,0.95
Yes, I understand.
I mean the change seems reasonable to align to the UI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756755259
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-755076048
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38294/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-755102368
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38294/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756755259
What does the UI look like before and after? what is in the REST API not in the UI?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-756917085
**[Test build #133846 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133846/testReport)** for PR 31048 at commit [`ed53e30`](https://github.com/apache/spark/commit/ed53e3063173613cfa7353b0de6421deb951d33b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on pull request #31048: [SPARK-34019][WEBUI] Keep same quantiles of task summary between Web UI and restful API
Posted by GitBox <gi...@apache.org>.
tgravescs commented on pull request #31048:
URL: https://github.com/apache/spark/pull/31048#issuecomment-758724507
I'm more on the side of putting it into a 4.0 since it could break someone and if someone doesn't like it they just set what they want.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org