You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/14 21:40:48 UTC

[GitHub] [arrow] wjones127 commented on pull request #11726: ARROW-14738: [Python][Doc] Make return types clickable

wjones127 commented on pull request #11726:
URL: https://github.com/apache/arrow/pull/11726#issuecomment-994050841


   Took a look at this locally. For other's benefit, here's how this changes the RecordBatch API reference page:
   
   <details>
   <summary>Before</summary>
   ![before screen shot](https://user-images.githubusercontent.com/5488879/146082136-654cd3d2-7a95-4a42-87c3-162baa68d7c9.png)
   </details>
   
   
   <details>
   <summary>After</summary>
   ![After screen shot](https://user-images.githubusercontent.com/5488879/146082149-a2a16b13-d681-4999-b868-77a4922049fb.png)
   </details>
   
   Looks pretty nice!
   
   Althrough I don't love the extra-heavy font-weight on the parameter names. Would be be willing to add this to the CSS at `docs/source/_static/theme_overrides.css`?
   
   ```css
   b, strong {
     font-weight: bold;
   }
   ```
   
   That would make the above page look like:
   
   <details>
   <summary>Fixed</summary>
   ![Screen Shot 2021-12-14 at 1 39 23 PM](https://user-images.githubusercontent.com/5488879/146083562-d5197c12-4549-4949-923a-e82521827f05.png)
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org