You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@arrow.apache.org by Ji Liu <ni...@aliyun.com.INVALID> on 2020/03/06 08:27:30 UTC
[Java] Port vector validate functionality
Hi all,
In C++ side, we already have array validate functionality[1] but no similar functionality in Java side.
I was thinking if we should port this into Java implementation? Since we already has visitor interface[2] and it seems not very complicated. I created an issue to track this[3].
Thanks,
Ji Liu
[1] https://github.com/apache/arrow/blob/6600a39ffe149971afd5ad3c78c2b538cdc03cfd/cpp/src/arrow/array/validate.h
[2] https://github.com/apache/arrow/blob/6600a39ffe149971afd5ad3c78c2b538cdc03cfd/java/vector/src/main/java/org/apache/arrow/vector/compare/VectorVisitor.java
[3] https://issues.apache.org/jira/browse/ARROW-8020
Re: [Java] Port vector validate functionality
Posted by Ji Liu <ni...@aliyun.com.INVALID>.
Hi Wes and Micah,
Thanks for your valuable suggestion, I will create sub-tasks under this issue as follow-up works when this one is finished.
Thanks,
Ji Liu
------------------------------------------------------------------
From:Micah Kornfield <em...@gmail.com>
Send Time:2020年3月11日(星期三) 13:42
To:dev <de...@arrow.apache.org>
Cc:Ji Liu <ni...@aliyun.com>
Subject:Re: [Java] Port vector validate functionality
I agree, it would also be good to run with some of the fuzzed IPC files.
On Fri, Mar 6, 2020 at 6:20 AM Wes McKinney <we...@gmail.com> wrote:
Seems useful. It may be a good idea to run within integration tests as
an extra sanity check also
On Fri, Mar 6, 2020 at 2:27 AM Ji Liu <ni...@aliyun.com.invalid> wrote:
>
>
> Hi all,
> In C++ side, we already have array validate functionality[1] but no similar functionality in Java side.
> I was thinking if we should port this into Java implementation? Since we already has visitor interface[2] and it seems not very complicated. I created an issue to track this[3].
>
>
> Thanks,
> Ji Liu
>
> [1] https://github.com/apache/arrow/blob/6600a39ffe149971afd5ad3c78c2b538cdc03cfd/cpp/src/arrow/array/validate.h
> [2] https://github.com/apache/arrow/blob/6600a39ffe149971afd5ad3c78c2b538cdc03cfd/java/vector/src/main/java/org/apache/arrow/vector/compare/VectorVisitor.java
> [3] https://issues.apache.org/jira/browse/ARROW-8020
Re: [Java] Port vector validate functionality
Posted by Micah Kornfield <em...@gmail.com>.
I agree, it would also be good to run with some of the fuzzed IPC files.
On Fri, Mar 6, 2020 at 6:20 AM Wes McKinney <we...@gmail.com> wrote:
> Seems useful. It may be a good idea to run within integration tests as
> an extra sanity check also
>
> On Fri, Mar 6, 2020 at 2:27 AM Ji Liu <ni...@aliyun.com.invalid> wrote:
> >
> >
> > Hi all,
> > In C++ side, we already have array validate functionality[1] but no
> similar functionality in Java side.
> > I was thinking if we should port this into Java implementation? Since we
> already has visitor interface[2] and it seems not very complicated. I
> created an issue to track this[3].
> >
> >
> > Thanks,
> > Ji Liu
> >
> > [1]
> https://github.com/apache/arrow/blob/6600a39ffe149971afd5ad3c78c2b538cdc03cfd/cpp/src/arrow/array/validate.h
> > [2]
> https://github.com/apache/arrow/blob/6600a39ffe149971afd5ad3c78c2b538cdc03cfd/java/vector/src/main/java/org/apache/arrow/vector/compare/VectorVisitor.java
> > [3] https://issues.apache.org/jira/browse/ARROW-8020
>
Re: [Java] Port vector validate functionality
Posted by Wes McKinney <we...@gmail.com>.
Seems useful. It may be a good idea to run within integration tests as
an extra sanity check also
On Fri, Mar 6, 2020 at 2:27 AM Ji Liu <ni...@aliyun.com.invalid> wrote:
>
>
> Hi all,
> In C++ side, we already have array validate functionality[1] but no similar functionality in Java side.
> I was thinking if we should port this into Java implementation? Since we already has visitor interface[2] and it seems not very complicated. I created an issue to track this[3].
>
>
> Thanks,
> Ji Liu
>
> [1] https://github.com/apache/arrow/blob/6600a39ffe149971afd5ad3c78c2b538cdc03cfd/cpp/src/arrow/array/validate.h
> [2] https://github.com/apache/arrow/blob/6600a39ffe149971afd5ad3c78c2b538cdc03cfd/java/vector/src/main/java/org/apache/arrow/vector/compare/VectorVisitor.java
> [3] https://issues.apache.org/jira/browse/ARROW-8020