You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/12/09 17:45:00 UTC

[jira] [Work logged] (BEAM-5820) Vendor Calcite

     [ https://issues.apache.org/jira/browse/BEAM-5820?focusedWorklogId=356400&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-356400 ]

ASF GitHub Bot logged work on BEAM-5820:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Dec/19 17:44
            Start Date: 09/Dec/19 17:44
    Worklog Time Spent: 10m 
      Work Description: suztomo commented on pull request #9189: [BEAM-5820] Use vendored calcite
URL: https://github.com/apache/beam/pull/9189#discussion_r355589635
 
 

 ##########
 File path: sdks/java/extensions/sql/build.gradle
 ##########
 @@ -76,70 +37,40 @@ configurations {
   fmppTemplates
 }
 
-def calcite_version = "1.20.0"
-def avatica_version = "1.15.0"
 def zetasql_version = "2019.09.1"
 
 dependencies {
   javacc "net.java.dev.javacc:javacc:4.0"
   fmppTask "com.googlecode.fmpp-maven-plugin:fmpp-maven-plugin:1.0"
   fmppTask "org.freemarker:freemarker:2.3.28"
-  fmppTemplates "org.apache.calcite:calcite-core:$calcite_version"
-  shadow library.java.vendored_guava_26_0_jre // Internal use
-  compile library.java.guava // Interfaces with Calcite use this
-  compile "org.apache.calcite:calcite-core:$calcite_version"
-  compile "org.apache.calcite:calcite-linq4j:$calcite_version"
-  compile "org.apache.calcite.avatica:avatica-core:$avatica_version"
-  compile "com.google.api.grpc:proto-google-common-protos:1.12.0" // Interfaces with ZetaSQL use this
+  fmppTemplates library.java.vendored_calcite_1_20_0
+  compile project(":sdks:java:core")
+  compile project(":sdks:java:extensions:join-library")
+  compile project(":runners:direct-java")
+  compile library.java.commons_csv
+  compile library.java.vendored_calcite_1_20_0
+  compile "com.alibaba:fastjson:1.2.49"
+  compile "org.codehaus.janino:janino:3.0.11"
+  compile "org.codehaus.janino:commons-compiler:3.0.11"
   compile "com.google.zetasql:zetasql-jni-channel:$zetasql_version"
   compile "com.google.zetasql:zetasql-client:$zetasql_version"
   compile "com.google.zetasql:zetasql-types:$zetasql_version"
-  shadow project(path: ":sdks:java:core", configuration: "shadow")
-  shadow project(":sdks:java:extensions:join-library")
-  shadow library.java.slf4j_api
-  shadow library.java.commons_codec
 
 Review comment:
   I this this omission caused the @iemejia 's finding:
   https://issues.apache.org/jira/browse/BEAM-8858?page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel&focusedCommentId=16991773#comment-16991773 .
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 356400)
    Time Spent: 16h 20m  (was: 16h 10m)

> Vendor Calcite
> --------------
>
>                 Key: BEAM-5820
>                 URL: https://issues.apache.org/jira/browse/BEAM-5820
>             Project: Beam
>          Issue Type: Sub-task
>          Components: dsl-sql
>            Reporter: Kenneth Knowles
>            Assignee: Kai Jiang
>            Priority: Major
>             Fix For: 2.17.0
>
>          Time Spent: 16h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)