You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "domoritz (via GitHub)" <gi...@apache.org> on 2023/12/16 16:22:22 UTC
[PR] GH-39248: [JS] Unify code paths for utf8 and largeUtf8 [arrow]
domoritz opened a new pull request, #39249:
URL: https://github.com/apache/arrow/pull/39249
Closes #39248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39248: [JS] Unify code paths for utf8 and largeUtf8 [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #39249:
URL: https://github.com/apache/arrow/pull/39249#issuecomment-1859683039
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 9c097d504a6acc193a5ce0a4cbf3551c948dcf90.
There were 2 benchmark results indicating a performance regression:
- Commit Run on `ursa-i9-9960x` at [2023-12-18 04:06:30Z](https://conbench.ursa.dev/compare/runs/3033f43fe10841369934c75badd301fc...5e5033c0bcd64ddd9289b79daceab3a0/)
- [`tpch` (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-20, scale_factor=1](https://conbench.ursa.dev/compare/benchmarks/0657f78b88da7cdf800072af37caeece...0657fdd8ae2e7e3b8000f312d0588ed2)
- [`tpch` (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-20, scale_factor=1](https://conbench.ursa.dev/compare/benchmarks/0657f78c39ba7c7f80006b56d7bccf46...0657fdd9a85c7b268000fcae8682e166)
The [full Conbench report](https://github.com/apache/arrow/runs/19733955106) has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39248: [JS] Unify code paths for utf8 and largeUtf8 [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #39249:
URL: https://github.com/apache/arrow/pull/39249#issuecomment-1858919298
Thanks for your patience. Conbench analyzed the 1 benchmarking run that has been run so far on PR commit 4da251bf3841b6cf44b9d3d6701cee8612f08839.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/19709850592) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39248: [JS] Unify code paths for utf8 and largeUtf8 [arrow]
Posted by "domoritz (via GitHub)" <gi...@apache.org>.
domoritz commented on PR #39249:
URL: https://github.com/apache/arrow/pull/39249#issuecomment-1858859765
@ursabot please benchmark lang=JS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39248: [JS] Unify code paths for utf8 and largeUtf8 [arrow]
Posted by "domoritz (via GitHub)" <gi...@apache.org>.
domoritz merged PR #39249:
URL: https://github.com/apache/arrow/pull/39249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39248: [JS] Unify code paths for utf8 and largeUtf8 [arrow]
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #39249:
URL: https://github.com/apache/arrow/pull/39249#issuecomment-1858859775
Supported benchmark command examples:
`@ursabot benchmark help`
To run all benchmarks:
`@ursabot please benchmark`
To filter benchmarks by language:
`@ursabot please benchmark lang=Python`
`@ursabot please benchmark lang=C++`
`@ursabot please benchmark lang=R`
`@ursabot please benchmark lang=Java`
`@ursabot please benchmark lang=JavaScript`
To filter Python and R benchmarks by name:
`@ursabot please benchmark name=file-write`
`@ursabot please benchmark name=file-write lang=Python`
`@ursabot please benchmark name=file-.*`
To filter C++ benchmarks by archery --suite-filter and --benchmark-filter:
`@ursabot please benchmark command=cpp-micro --suite-filter=arrow-compute-vector-selection-benchmark --benchmark-filter=TakeStringRandomIndicesWithNulls/262144/2 --iterations=3`
For other `command=cpp-micro` options, please see https://github.com/voltrondata-labs/benchmarks/blob/main/benchmarks/cpp_micro_benchmarks.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39248: [JS] Unify code paths for utf8 and largeUtf8 [arrow]
Posted by "domoritz (via GitHub)" <gi...@apache.org>.
domoritz commented on PR #39249:
URL: https://github.com/apache/arrow/pull/39249#issuecomment-1858859951
@ursabot please benchmark lang=JavaScript
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39248: [JS] Unify code paths for utf8 and largeUtf8 [arrow]
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #39249:
URL: https://github.com/apache/arrow/pull/39249#issuecomment-1858859966
Benchmark runs are scheduled for commit 4da251bf3841b6cf44b9d3d6701cee8612f08839. Watch https://buildkite.com/apache-arrow and https://conbench.ursa.dev for updates. A comment will be posted here when the runs are complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39248: [JS] Unify code paths for utf8 and largeUtf8 [arrow]
Posted by "domoritz (via GitHub)" <gi...@apache.org>.
domoritz commented on PR #39249:
URL: https://github.com/apache/arrow/pull/39249#issuecomment-1859488046
Reviewed as part of #39258.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org