[jira] [Commented] (CB-7608) Add option to set "useWideViewPort" to false.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-7608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14143157#comment-14143157 ] 

ASF GitHub Bot commented on CB-7608:
------------------------------------

GitHub user sebastienblanc opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/66

    CB-7608 : add option useWidthViewPort (Android Platform) 

    When using inAppBrowser with Android, the viewport tag of the loaded page is ignored. As a result, some pages using a specific viewport (for instance an Ionic view) are completly zoomed out.
    With iOS it's possible to fix that by passing "enableViewportScale" but for Android the only way to fix this is to set 'useWideViewPort' to 'false' . It's now harcoded to 'true' https://github.com/apache/cordova-plugin-inappbrowser/blob/master/src/android/InAppBrowser.java#L620.
    We should be able to pass the value through the option (i.e : 'location=no, useWideViewPort=no')

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sebastienblanc/cordova-plugin-inappbrowser CB-7608

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/66.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #66
    
----
commit 5f8e3e4f153a9380605c34a5e0d717fe73d73af4
Author: Sebastien Blanc <sc...@gmail.com>
Date:   2014-09-22T12:42:04Z

    add option useWidthViewPort

----


> Add option to set "useWideViewPort" to false.
> ---------------------------------------------
>
>                 Key: CB-7608
>                 URL: https://issues.apache.org/jira/browse/CB-7608
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Android, Plugin InAppBrowser
>    Affects Versions: 3.5.0
>            Reporter: Sébastien Blanc
>
> When using inAppBrowser with Android, the viewport tag of the loaded page is ignored. As a result, some pages using a specific viewport (for instance an Ionic view) are completly zoomed out.
> With iOS it's possible to fix that by passing "enableViewportScale" but for Android the only way to fix this is to set  'useWideViewPort' to 'false' . It's now harcoded to 'true' https://github.com/apache/cordova-plugin-inappbrowser/blob/master/src/android/InAppBrowser.java#L620.
> We should be able to pass the value through the option (i.e : 'location=no, useWideViewPort=no') 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)