You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Yongqiao Wang <yq...@cn.ibm.com> on 2016/01/04 12:23:06 UTC
Re: Review Request 41790: Add tests for /weights endpoint.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/
-----------------------------------------------------------
(Updated Jan. 4, 2016, 11:23 a.m.)
Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
Changes
-------
Add the authrization and authentication test.
Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200
Repository: mesos
Description
-------
Add tests for /weights endpoint.
Diffs (updated)
-----
src/Makefile.am b58d6b560858d318058be766456dd5c5ef98c23e
src/tests/dynamic_weights_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/41790/diff/
Testing
-------
Make and Make check successfully!
./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
[==========] Running 5 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 5 tests from DynamicWeightsTest
[ RUN ] DynamicWeightsTest.PutInvalidRequest
[ OK ] DynamicWeightsTest.PutInvalidRequest (77 ms)
[ RUN ] DynamicWeightsTest.NegativeWeight
[ OK ] DynamicWeightsTest.NegativeWeight (35 ms)
[ RUN ] DynamicWeightsTest.NonExistentRole
[ OK ] DynamicWeightsTest.NonExistentRole (40 ms)
[ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
[ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (46 ms)
[ RUN ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
[ OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (37 ms)
[----------] 5 tests from DynamicWeightsTest (235 ms total)
[----------] Global test environment tear-down
[==========] 5 tests from 1 test case ran. (244 ms total)
[ PASSED ] 5 tests.
Thanks,
Yongqiao Wang
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/#review112565
-----------------------------------------------------------
Bad patch!
Reviews applied: [41597]
Failed command: ./support/apply-review.sh -n -r 41597
Error:
2016-01-04 13:01:47 URL:https://reviews.apache.org/r/41597/diff/raw/ [8106/8106] -> "41597.patch" [1]
Total errors found: 0
Checking 8 files
Error: Commit message summary (the first line) must end in a period.
- Mesos ReviewBot
On Jan. 4, 2016, 11:23 a.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 11:23 a.m.)
>
>
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
>
>
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add tests for /weights endpoint.
>
>
> Diffs
> -----
>
> src/Makefile.am b58d6b560858d318058be766456dd5c5ef98c23e
> src/tests/dynamic_weights_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41790/diff/
>
>
> Testing
> -------
>
> Make and Make check successfully!
>
> ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
> [==========] Running 9 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 9 tests from DynamicWeightsTest
> [ RUN ] DynamicWeightsTest.PutInvalidRequest
> [ OK ] DynamicWeightsTest.PutInvalidRequest (106 ms)
> [ RUN ] DynamicWeightsTest.NegativeWeight
> [ OK ] DynamicWeightsTest.NegativeWeight (43 ms)
> [ RUN ] DynamicWeightsTest.NonExistentRole
> [ OK ] DynamicWeightsTest.NonExistentRole (40 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (46 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (35 ms)
> [ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
> [ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (33 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (41 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
> [ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (34 ms)
> [ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (36 ms)
> [----------] 9 tests from DynamicWeightsTest (415 ms total)
>
> [----------] Global test environment tear-down
> [==========] 9 tests from 1 test case ran. (424 ms total)
> [ PASSED ] 9 tests.
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/#review113028
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41597, 41681, 41789, 41790]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 6, 2016, 2:07 a.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2016, 2:07 a.m.)
>
>
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
>
>
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add tests for /weights endpoint.
>
>
> Diffs
> -----
>
> src/Makefile.am e08e86724abaa3023f0483aa222354c95d4d3817
> src/tests/dynamic_weights_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41790/diff/
>
>
> Testing
> -------
>
> Make and Make check successfully!
>
> ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
> [==========] Running 10 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 10 tests from DynamicWeightsTest
> [ RUN ] DynamicWeightsTest.PutInvalidRequest
> [ OK ] DynamicWeightsTest.PutInvalidRequest (102 ms)
> [ RUN ] DynamicWeightsTest.NegativeWeight
> [ OK ] DynamicWeightsTest.NegativeWeight (42 ms)
> [ RUN ] DynamicWeightsTest.MissingRole
> [ OK ] DynamicWeightsTest.MissingRole (43 ms)
> [ RUN ] DynamicWeightsTest.NonExistentRole
> [ OK ] DynamicWeightsTest.NonExistentRole (30 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (38 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (42 ms)
> [ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
> [ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (35 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (37 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
> [ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (44 ms)
> [ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (30 ms)
> [----------] 10 tests from DynamicWeightsTest (443 ms total)
>
> [----------] Global test environment tear-down
> [==========] 10 tests from 1 test case ran. (452 ms total)
> [ PASSED ] 10 tests.
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/#review113678
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41597, 41681, 41789, 41790]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 9, 2016, 11:38 a.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2016, 11:38 a.m.)
>
>
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
>
>
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add tests for /weights endpoint.
>
>
> Diffs
> -----
>
> src/Makefile.am bbd0c119321fa9d11fea61b140428dd92d1258c8
> src/tests/dynamic_weights_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41790/diff/
>
>
> Testing
> -------
>
> Make and Make check successfully!
>
> ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
> [==========] Running 10 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 10 tests from DynamicWeightsTest
> [ RUN ] DynamicWeightsTest.PutInvalidRequest
> [ OK ] DynamicWeightsTest.PutInvalidRequest (102 ms)
> [ RUN ] DynamicWeightsTest.NegativeWeight
> [ OK ] DynamicWeightsTest.NegativeWeight (42 ms)
> [ RUN ] DynamicWeightsTest.MissingRole
> [ OK ] DynamicWeightsTest.MissingRole (43 ms)
> [ RUN ] DynamicWeightsTest.NonExistentRole
> [ OK ] DynamicWeightsTest.NonExistentRole (30 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (38 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (42 ms)
> [ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
> [ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (35 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (37 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
> [ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (44 ms)
> [ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (30 ms)
> [----------] 10 tests from DynamicWeightsTest (443 ms total)
>
> [----------] Global test environment tear-down
> [==========] 10 tests from 1 test case ran. (452 ms total)
> [ PASSED ] 10 tests.
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Yongqiao Wang <yq...@cn.ibm.com>.
> On Jan. 11, 2016, 7:55 a.m., Adam B wrote:
> > src/tests/dynamic_weights_tests.cpp, line 329
> > <https://reviews.apache.org/r/41790/diff/7/?file=1189251#file1189251line329>
> >
> > "specified role"? Which one? You mean WEIGHTS?
Yes, I have improved the comments to more clear.
> On Jan. 11, 2016, 7:55 a.m., Adam B wrote:
> > src/tests/dynamic_weights_tests.cpp, line 148
> > <https://reviews.apache.org/r/41790/diff/7/?file=1189251#file1189251line148>
> >
> > Why don't we have a `process::http::put()`?
I have explained it in https://reviews.apache.org/r/41789/, only want to use a general function rather than some specific funcs.
> On Jan. 11, 2016, 7:55 a.m., Adam B wrote:
> > src/tests/dynamic_weights_tests.cpp, line 155
> > <https://reviews.apache.org/r/41790/diff/7/?file=1189251#file1189251line155>
> >
> > What does the false do? Please comment
I will comment that in the place of httpRequest function declaration in http.hpp.
- Yongqiao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/#review113689
-----------------------------------------------------------
On Jan. 9, 2016, 11:38 a.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2016, 11:38 a.m.)
>
>
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
>
>
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add tests for /weights endpoint.
>
>
> Diffs
> -----
>
> src/Makefile.am bbd0c119321fa9d11fea61b140428dd92d1258c8
> src/tests/dynamic_weights_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41790/diff/
>
>
> Testing
> -------
>
> Make and Make check successfully!
>
> ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
> [==========] Running 10 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 10 tests from DynamicWeightsTest
> [ RUN ] DynamicWeightsTest.PutInvalidRequest
> [ OK ] DynamicWeightsTest.PutInvalidRequest (102 ms)
> [ RUN ] DynamicWeightsTest.NegativeWeight
> [ OK ] DynamicWeightsTest.NegativeWeight (42 ms)
> [ RUN ] DynamicWeightsTest.MissingRole
> [ OK ] DynamicWeightsTest.MissingRole (43 ms)
> [ RUN ] DynamicWeightsTest.NonExistentRole
> [ OK ] DynamicWeightsTest.NonExistentRole (30 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (38 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (42 ms)
> [ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
> [ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (35 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (37 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
> [ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (44 ms)
> [ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (30 ms)
> [----------] 10 tests from DynamicWeightsTest (443 ms total)
>
> [----------] Global test environment tear-down
> [==========] 10 tests from 1 test case ran. (452 ms total)
> [ PASSED ] 10 tests.
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/#review113689
-----------------------------------------------------------
A good set of tests for the functionality, but I've got some suggestions for you, most importantly:
- We should consider an official `http::put()` method like `http::post()`, etc.
- Don't forget to clear the permissive bit if you want restrictive ACLs.
- I found a few unused methods/variables. Use it or lose it.
src/tests/dynamic_weights_tests.cpp (line 70)
<https://reviews.apache.org/r/41790/#comment174484>
s/std:://g
src/tests/dynamic_weights_tests.cpp (line 79)
<https://reviews.apache.org/r/41790/#comment174447>
s/weithgs/weights/
src/tests/dynamic_weights_tests.cpp (line 88)
<https://reviews.apache.org/r/41790/#comment174448>
This is never called?
src/tests/dynamic_weights_tests.cpp (line 99)
<https://reviews.apache.org/r/41790/#comment174449>
`s/;/./`
src/tests/dynamic_weights_tests.cpp (line 103)
<https://reviews.apache.org/r/41790/#comment174450>
Error check, for empty vector, etc.
src/tests/dynamic_weights_tests.cpp (line 105)
<https://reviews.apache.org/r/41790/#comment174483>
s/std:://g
src/tests/dynamic_weights_tests.cpp (line 106)
<https://reviews.apache.org/r/41790/#comment174451>
Assert that pair.size() == 2
src/tests/dynamic_weights_tests.cpp (line 130)
<https://reviews.apache.org/r/41790/#comment174452>
s/std:://g
src/tests/dynamic_weights_tests.cpp (lines 130 - 133)
<https://reviews.apache.org/r/41790/#comment174454>
We usually use `FOO = "bar";` rather than `FOO{"bar"}`.
src/tests/dynamic_weights_tests.cpp (line 133)
<https://reviews.apache.org/r/41790/#comment174453>
Unused?
src/tests/dynamic_weights_tests.cpp (line 135)
<https://reviews.apache.org/r/41790/#comment174455>
Unused?
src/tests/dynamic_weights_tests.cpp (line 146)
<https://reviews.apache.org/r/41790/#comment174462>
I'm not convinced the lambda makes this much more readable. And you aren't actually calling `http::put`, since that doesn't exist.
src/tests/dynamic_weights_tests.cpp (line 148)
<https://reviews.apache.org/r/41790/#comment174456>
Why don't we have a `process::http::put()`?
src/tests/dynamic_weights_tests.cpp (line 155)
<https://reviews.apache.org/r/41790/#comment174457>
What does the false do? Please comment
src/tests/dynamic_weights_tests.cpp (line 158)
<https://reviews.apache.org/r/41790/#comment174468>
s/a update/an update/g
src/tests/dynamic_weights_tests.cpp (lines 170 - 173)
<https://reviews.apache.org/r/41790/#comment174466>
Why the scoping here? If you want to reuse the names 'badRequest' and 'response', you could do so without creating a new variable each time.
src/tests/dynamic_weights_tests.cpp (line 186)
<https://reviews.apache.org/r/41790/#comment174470>
s/update weights/update weights request/
s/invalid fields/an invalid field/
src/tests/dynamic_weights_tests.cpp (line 191)
<https://reviews.apache.org/r/41790/#comment174472>
What makes this an invalid field? Isn't it a perfectly reasonable role name?
Or is it supposed to be `weights=[{ "role":"role1", "weight":1.5}]`, in which case "role1" is also an invalid field name?
src/tests/dynamic_weights_tests.cpp (line 204)
<https://reviews.apache.org/r/41790/#comment174473>
Can you test weight=0 too?
src/tests/dynamic_weights_tests.cpp (lines 221 - 222)
<https://reviews.apache.org/r/41790/#comment174474>
Could you verify after the failed update that the weights are still at their original value?
src/tests/dynamic_weights_tests.cpp (lines 264 - 265)
<https://reviews.apache.org/r/41790/#comment174475>
s/does not contains/not specified/
src/tests/dynamic_weights_tests.cpp (line 267)
<https://reviews.apache.org/r/41790/#comment174476>
s/NonExistent/Nonexistent/
src/tests/dynamic_weights_tests.cpp (line 292)
<https://reviews.apache.org/r/41790/#comment174477>
s/the existent roles/a whitelisted role/
src/tests/dynamic_weights_tests.cpp (line 293)
<https://reviews.apache.org/r/41790/#comment174478>
s/contains in/contained in/
s/is succeeded/succeeds/
src/tests/dynamic_weights_tests.cpp (lines 313 - 314)
<https://reviews.apache.org/r/41790/#comment174479>
Verify the new weights in `/roles`?
src/tests/dynamic_weights_tests.cpp (lines 320 - 321)
<https://reviews.apache.org/r/41790/#comment174480>
s/is succeeded/succeeds/
src/tests/dynamic_weights_tests.cpp (line 329)
<https://reviews.apache.org/r/41790/#comment174481>
"specified role"? Which one? You mean WEIGHTS?
src/tests/dynamic_weights_tests.cpp (line 372)
<https://reviews.apache.org/r/41790/#comment174482>
s/absense/absence/
src/tests/dynamic_weights_tests.cpp (lines 394 - 395)
<https://reviews.apache.org/r/41790/#comment174485>
You should also set `acls.permissive = false;` if you want to actually disallow unknown principals/roles.
src/tests/dynamic_weights_tests.cpp (lines 429 - 430)
<https://reviews.apache.org/r/41790/#comment174486>
also permissive=false
- Adam B
On Jan. 9, 2016, 3:38 a.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2016, 3:38 a.m.)
>
>
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
>
>
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add tests for /weights endpoint.
>
>
> Diffs
> -----
>
> src/Makefile.am bbd0c119321fa9d11fea61b140428dd92d1258c8
> src/tests/dynamic_weights_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41790/diff/
>
>
> Testing
> -------
>
> Make and Make check successfully!
>
> ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
> [==========] Running 10 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 10 tests from DynamicWeightsTest
> [ RUN ] DynamicWeightsTest.PutInvalidRequest
> [ OK ] DynamicWeightsTest.PutInvalidRequest (102 ms)
> [ RUN ] DynamicWeightsTest.NegativeWeight
> [ OK ] DynamicWeightsTest.NegativeWeight (42 ms)
> [ RUN ] DynamicWeightsTest.MissingRole
> [ OK ] DynamicWeightsTest.MissingRole (43 ms)
> [ RUN ] DynamicWeightsTest.NonExistentRole
> [ OK ] DynamicWeightsTest.NonExistentRole (30 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (38 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (42 ms)
> [ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
> [ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (35 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (37 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
> [ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (44 ms)
> [ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (30 ms)
> [----------] 10 tests from DynamicWeightsTest (443 ms total)
>
> [----------] Global test environment tear-down
> [==========] 10 tests from 1 test case ran. (452 ms total)
> [ PASSED ] 10 tests.
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/#review113810
-----------------------------------------------------------
Bad patch!
Reviews applied: [41597, 41681, 41789, 41790]
Failed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
Error:
+ : ubuntu:14.04
+ : gcc
+ : --verbose
+++ dirname ./support/docker_build.sh
++ cd ./support/..
++ pwd
+ MESOS_DIRECTORY=/home/jenkins/jenkins-slave/workspace/mesos-reviewbot
+ cd /home/jenkins/jenkins-slave/workspace/mesos-reviewbot
+ DOCKERFILE=Dockerfile
+ rm -f Dockerfile
+ case $OS in
+ append_dockerfile 'FROM ubuntu:14.04'
+ echo FROM ubuntu:14.04
+ append_dockerfile 'RUN rm -rf /var/lib/apt/lists/*'
+ echo RUN rm -rf /var/lib/apt/lists/get.docker.io_ubuntu_dists_docker_main_binary-amd64_Packages /var/lib/apt/lists/get.docker.io_ubuntu_dists_docker_main_binary-i386_Packages /var/lib/apt/lists/get.docker.io_ubuntu_dists_docker_Release /var/lib/apt/lists/get.docker.io_ubuntu_dists_docker_Release.gpg /var/lib/apt/lists/lock /var/lib/apt/lists/packages.apache.org_asf%5finternal_dists_trusty_main_binary-amd64_Packages /var/lib/apt/lists/packages.apache.org_asf%5finternal_dists_trusty_main_binary-i386_Packages /var/lib/apt/lists/packages.apache.org_asf%5finternal_dists_trusty_Release /var/lib/apt/lists/packages.apache.org_asf%5finternal_dists_trusty_Release.gpg /var/lib/apt/lists/partial /var/lib/apt/lists/ppa.launchpad.net_webupd8team_java_ubuntu_dists_trusty_main_binary-amd64_Packages /var/lib/apt/lists/ppa.launchpad.net_webupd8team_java_ubuntu_dists_trusty_main_binary-i386_Packages /var/lib/apt/lists/ppa.launchpad.net_webupd8team_java_ubuntu_dists_trusty_main_i18n_Translation-en /va
r/lib/apt/lists/ppa.launchpad.net_webupd8team_java_ubuntu_dists_trusty_main_source_Sources /var/lib/apt/lists/ppa.launchpad.net_webupd8team_java_ubuntu_dists_trusty_Release /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_InRelease /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_main_binary-amd64_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_main_binary-i386_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_main_i18n_Translation-en /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_main_source_Sources /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_multiverse_binary-amd64_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_multiverse_binary-i386_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_multiverse_i18n_Translation-en /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_multiver
se_source_Sources /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_restricted_binary-amd64_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_restricted_binary-i386_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_restricted_i18n_Translation-en /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_restricted_source_Sources /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_universe_binary-amd64_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_universe_binary-i386_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_universe_i18n_Translation-en /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_universe_source_Sources /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_InRelease /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_main_binary-amd64_Packages /var/lib/apt/lists/u
s.archive.ubuntu.com_ubuntu_dists_trusty-backports_main_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_main_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_main_source_Sources /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_multiverse_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_multiverse_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_multiverse_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_multiverse_source_Sources /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_restricted_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_restricted_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_restricted_i18n_Translation-en /var/lib/apt/lists
/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_restricted_source_Sources /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_universe_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_universe_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_universe_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_universe_source_Sources /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty_main_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty_main_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty_main_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty_main_source_Sources /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty_multiverse_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty_multiverse_binary-i386_
Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty_multiverse_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty_multiverse_source_Sources /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty_Release /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty_Release.gpg /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty_restricted_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty_restricted_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty_restricted_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty_restricted_source_Sources /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty_universe_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty_universe_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty_universe_i18n_Translation-en /var/lib/apt/lists/us.archiv
e.ubuntu.com_ubuntu_dists_trusty_universe_source_Sources /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-updates_InRelease /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-updates_main_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-updates_main_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-updates_main_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-updates_main_source_Sources /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-updates_multiverse_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-updates_multiverse_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-updates_multiverse_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-updates_multiverse_source_Sources /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-updates_restricted_binary-am
d64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-updates_restricted_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-updates_restricted_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-updates_restricted_source_Sources /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-updates_universe_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-updates_universe_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-updates_universe_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-updates_universe_source_Sources
+ append_dockerfile 'RUN apt-get update'
+ echo RUN apt-get update
+ append_dockerfile 'RUN apt-get -y install build-essential clang git maven autoconf libtool'
+ echo RUN apt-get -y install build-essential clang git maven autoconf libtool
+ append_dockerfile 'RUN apt-get -y install openjdk-7-jdk python-dev python-boto libcurl4-nss-dev libsasl2-dev libapr1-dev libsvn-dev libevent-dev libev-dev'
+ echo RUN apt-get -y install openjdk-7-jdk python-dev python-boto libcurl4-nss-dev libsasl2-dev libapr1-dev libsvn-dev libevent-dev libev-dev
+ append_dockerfile 'RUN adduser --disabled-password --gecos '\'''\'' mesos'
+ echo RUN adduser --disabled-password --gecos ''\'''\''' mesos
+ append_dockerfile 'ENV GTEST_FILTER -FsTest.FileSystemTableRead'
+ echo ENV GTEST_FILTER -FsTest.FileSystemTableRead
+ append_dockerfile 'ENV GTEST_OUTPUT xml:report.xml'
+ echo ENV GTEST_OUTPUT xml:report.xml
+ case $COMPILER in
+ append_dockerfile 'ENV CC gcc'
+ echo ENV CC gcc
+ append_dockerfile 'ENV CXX g++'
+ echo ENV CXX g++
+ append_dockerfile 'WORKDIR mesos'
+ echo WORKDIR mesos
+ append_dockerfile 'COPY . /mesos/'
+ echo COPY . /mesos/
+ append_dockerfile 'RUN chown -R mesos /mesos'
+ echo RUN chown -R mesos /mesos
+ append_dockerfile 'USER mesos'
+ echo USER mesos
+ append_dockerfile 'CMD ./bootstrap && ./configure --verbose && DISTCHECK_CONFIGURE_FLAGS="--verbose" GLOG_v=1 MESOS_VERBOSE=1 make -j8 distcheck'
+ echo CMD ./bootstrap '&&' ./configure --verbose '&&' 'DISTCHECK_CONFIGURE_FLAGS="--verbose"' GLOG_v=1 MESOS_VERBOSE=1 make -j8 distcheck
++ date +%s
+ TAG=mesos-1452536610-17941
+ docker build --no-cache=true -t mesos-1452536610-17941 .
Sending build context to Docker daemon 529.1 kB
Sending build context to Docker daemon 1.054 MB
Sending build context to Docker daemon 1.606 MB
Sending build context to Docker daemon 2.13 MB
Sending build context to Docker daemon 2.656 MB
Sending build context to Docker daemon 3.183 MB
Sending build context to Docker daemon 3.708 MB
Sending build context to Docker daemon 4.26 MB
Sending build context to Docker daemon 4.817 MB
Sending build context to Docker daemon 5.374 MB
Sending build context to Docker daemon 5.931 MB
Sending build context to Docker daemon 6.488 MB
Sending build context to Docker daemon 7.045 MB
Sending build context to Docker daemon 7.602 MB
Sending build context to Docker daemon 8.159 MB
Sending build context to Docker daemon 8.716 MB
Sending build context to Docker daemon 9.273 MB
Sending build context to Docker daemon 9.83 MB
Sending build context to Docker daemon 10.39 MB
Sending build context to Docker daemon 10.94 MB
Sending build context to Docker daemon 11.5 MB
Sending build context to Docker daemon 12.06 MB
Sending build context to Docker daemon 12.62 MB
Sending build context to Docker daemon 13.17 MB
Sending build context to Docker daemon 13.73 MB
Sending build context to Docker daemon 14.29 MB
Sending build context to Docker daemon 14.84 MB
Sending build context to Docker daemon 15.4 MB
Sending build context to Docker daemon 15.96 MB
Sending build context to Docker daemon 16.52 MB
Sending build context to Docker daemon 17.07 MB
Sending build context to Docker daemon 17.63 MB
Sending build context to Docker daemon 18.19 MB
Sending build context to Docker daemon 18.74 MB
Sending build context to Docker daemon 19.3 MB
Sending build context to Docker daemon 19.86 MB
Sending build context to Docker daemon 20.41 MB
Sending build context to Docker daemon 20.97 MB
Sending build context to Docker daemon 21.53 MB
Sending build context to Docker daemon 22.09 MB
Sending build context to Docker daemon 22.64 MB
Sending build context to Docker daemon 23.2 MB
Sending build context to Docker daemon 23.76 MB
Sending build context to Docker daemon 24.31 MB
Sending build context to Docker daemon 24.87 MB
Sending build context to Docker daemon 25.43 MB
Sending build context to Docker daemon 25.99 MB
Sending build context to Docker daemon 26.54 MB
Sending build context to Docker daemon 27.1 MB
Sending build context to Docker daemon 27.66 MB
Sending build context to Docker daemon 28.21 MB
Sending build context to Docker daemon 28.77 MB
Sending build context to Docker daemon 29.33 MB
Sending build context to Docker daemon 29.88 MB
Sending build context to Docker daemon 30.44 MB
Sending build context to Docker daemon 31 MB
Sending build context to Docker daemon 31.56 MB
Sending build context to Docker daemon 32.11 MB
Sending build context to Docker daemon 32.67 MB
Sending build context to Docker daemon 33.23 MB
Sending build context to Docker daemon 33.78 MB
Sending build context to Docker daemon 34.34 MB
Sending build context to Docker daemon 34.9 MB
Sending build context to Docker daemon 35.45 MB
Sending build context to Docker daemon 36.01 MB
Sending build context to Docker daemon 36.57 MB
Sending build context to Docker daemon 37.13 MB
Sending build context to Docker daemon 37.68 MB
Sending build context to Docker daemon 38.24 MB
Sending build context to Docker daemon 38.8 MB
Sending build context to Docker daemon 39.35 MB
Sending build context to Docker daemon 39.91 MB
Sending build context to Docker daemon 40.47 MB
Sending build context to Docker daemon 41.03 MB
Sending build context to Docker daemon 41.58 MB
Sending build context to Docker daemon 42.14 MB
Sending build context to Docker daemon 42.7 MB
Sending build context to Docker daemon 43.25 MB
Sending build context to Docker daemon 43.81 MB
Sending build context to Docker daemon 44.37 MB
Sending build context to Docker daemon 44.92 MB
Sending build context to Docker daemon 45.48 MB
Sending build context to Docker daemon 46.04 MB
Sending build context to Docker daemon 46.6 MB
Sending build context to Docker daemon 47.15 MB
Sending build context to Docker daemon 47.71 MB
Sending build context to Docker daemon 48.27 MB
Sending build context to Docker daemon 48.82 MB
Sending build context to Docker daemon 49.38 MB
Sending build context to Docker daemon 49.94 MB
Sending build context to Docker daemon 50.5 MB
Sending build context to Docker daemon 51.05 MB
Sending build context to Docker daemon 51.61 MB
Sending build context to Docker daemon 52.17 MB
Sending build context to Docker daemon 52.72 MB
Sending build context to Docker daemon 53.28 MB
Sending build context to Docker daemon 53.84 MB
Sending build context to Docker daemon 54.39 MB
Sending build context to Docker daemon 54.95 MB
Sending build context to Docker daemon 55.51 MB
Sending build context to Docker daemon 56.07 MB
Sending build context to Docker daemon 56.62 MB
Sending build context to Docker daemon 57.18 MB
Sending build context to Docker daemon 57.74 MB
Sending build context to Docker daemon 58.29 MB
Sending build context to Docker daemon 58.85 MB
Sending build context to Docker daemon 59.41 MB
Sending build context to Docker daemon 59.97 MB
Sending build context to Docker daemon 60.52 MB
Sending build context to Docker daemon 61.08 MB
Sending build context to Docker daemon 61.64 MB
Sending build context to Docker daemon 62.19 MB
Sending build context to Docker daemon 62.75 MB
Sending build context to Docker daemon 63.31 MB
Sending build context to Docker daemon 63.86 MB
Sending build context to Docker daemon 64.42 MB
Sending build context to Docker daemon 64.98 MB
Sending build context to Docker daemon 65.54 MB
Sending build context to Docker daemon 66.09 MB
Sending build context to Docker daemon 66.65 MB
Sending build context to Docker daemon 67.21 MB
Sending build context to Docker daemon 67.76 MB
Sending build context to Docker daemon 68.32 MB
Sending build context to Docker daemon 68.88 MB
Sending build context to Docker daemon 69.44 MB
Sending build context to Docker daemon 69.99 MB
Sending build context to Docker daemon 70.55 MB
Sending build context to Docker daemon 71.11 MB
Sending build context to Docker daemon 71.66 MB
Sending build context to Docker daemon 72.22 MB
Sending build context to Docker daemon 72.78 MB
Sending build context to Docker daemon 73.33 MB
Sending build context to Docker daemon 73.89 MB
Sending build context to Docker daemon 74.45 MB
Sending build context to Docker daemon 75.01 MB
Sending build context to Docker daemon 75.56 MB
Sending build context to Docker daemon 76.12 MB
Sending build context to Docker daemon 76.68 MB
Sending build context to Docker daemon 77.23 MB
Sending build context to Docker daemon 77.79 MB
Sending build context to Docker daemon 78.35 MB
Sending build context to Docker daemon 78.91 MB
Sending build context to Docker daemon 79.46 MB
Sending build context to Docker daemon 80.02 MB
Sending build context to Docker daemon 80.58 MB
Sending build context to Docker daemon 81.13 MB
Sending build context to Docker daemon 81.69 MB
Sending build context to Docker daemon 82.25 MB
Sending build context to Docker daemon 82.8 MB
Sending build context to Docker daemon 83.36 MB
Sending build context to Docker daemon 83.92 MB
Sending build context to Docker daemon 84.48 MB
Sending build context to Docker daemon 85.03 MB
Sending build context to Docker daemon 85.59 MB
Sending build context to Docker daemon 86.15 MB
Sending build context to Docker daemon 86.7 MB
Sending build context to Docker daemon 87.26 MB
Sending build context to Docker daemon 87.82 MB
Sending build context to Docker daemon 88.38 MB
Sending build context to Docker daemon 88.93 MB
Sending build context to Docker daemon 89.49 MB
Sending build context to Docker daemon 90.05 MB
Sending build context to Docker daemon 90.6 MB
Sending build context to Docker daemon 91.16 MB
Sending build context to Docker daemon 91.72 MB
Sending build context to Docker daemon 92.27 MB
Sending build context to Docker daemon 92.83 MB
Sending build context to Docker daemon 93.39 MB
Sending build context to Docker daemon 93.95 MB
Sending build context to Docker daemon 94.5 MB
Sending build context to Docker daemon 95.06 MB
Sending build context to Docker daemon 95.62 MB
Sending build context to Docker daemon 96.17 MB
Sending build context to Docker daemon 96.73 MB
Sending build context to Docker daemon 97.29 MB
Sending build context to Docker daemon 97.85 MB
Sending build context to Docker daemon 98.4 MB
Sending build context to Docker daemon 98.96 MB
Sending build context to Docker daemon 99.52 MB
Sending build context to Docker daemon 100.1 MB
Sending build context to Docker daemon 100.6 MB
Sending build context to Docker daemon 101.2 MB
Sending build context to Docker daemon 101.7 MB
Sending build context to Docker daemon 102.3 MB
Sending build context to Docker daemon 102.9 MB
Sending build context to Docker daemon 103.4 MB
Sending build context to Docker daemon 104 MB
Sending build context to Docker daemon 104.5 MB
Sending build context to Docker daemon 105.1 MB
Sending build context to Docker daemon 105.6 MB
Sending build context to Docker daemon 106.2 MB
Sending build context to Docker daemon 106.8 MB
Sending build context to Docker daemon 107.3 MB
Sending build context to Docker daemon 107.9 MB
Sending build context to Docker daemon 108.4 MB
Sending build context to Docker daemon 109 MB
Sending build context to Docker daemon 109.5 MB
Sending build context to Docker daemon 110.1 MB
Sending build context to Docker daemon 110.7 MB
Sending build context to Docker daemon 111.2 MB
Sending build context to Docker daemon 111.8 MB
Sending build context to Docker daemon 112.3 MB
Sending build context to Docker daemon 112.9 MB
Sending build context to Docker daemon 113.4 MB
Sending build context to Docker daemon 114 MB
Sending build context to Docker daemon 114.6 MB
Sending build context to Docker daemon 115.1 MB
Sending build context to Docker daemon 115.7 MB
Sending build context to Docker daemon 116.2 MB
Sending build context to Docker daemon 116.8 MB
Sending build context to Docker daemon 117.3 MB
Sending build context to Docker daemon 117.9 MB
Sending build context to Docker daemon 118.5 MB
Sending build context to Docker daemon 119 MB
Sending build context to Docker daemon 119.6 MB
Sending build context to Docker daemon 120.1 MB
Sending build context to Docker daemon 120.7 MB
Sending build context to Docker daemon 121.2 MB
Sending build context to Docker daemon 121.8 MB
Sending build context to Docker daemon 122.4 MB
Sending build context to Docker daemon 122.9 MB
Sending build context to Docker daemon 123.5 MB
Sending build context to Docker daemon 124 MB
Sending build context to Docker daemon 124.6 MB
Sending build context to Docker daemon 125.1 MB
Sending build context to Docker daemon 125.7 MB
Sending build context to Docker daemon 126.3 MB
Sending build context to Docker daemon 126.8 MB
Sending build context to Docker daemon 127.4 MB
Sending build context to Docker daemon 127.9 MB
Sending build context to Docker daemon 128.5 MB
Sending build context to Docker daemon 129 MB
Sending build context to Docker daemon 129.6 MB
Sending build context to Docker daemon 130.2 MB
Sending build context to Docker daemon 130.7 MB
Sending build context to Docker daemon 131.3 MB
Sending build context to Docker daemon 131.8 MB
Sending build context to Docker daemon 132.4 MB
Sending build context to Docker daemon 132.9 MB
Sending build context to Docker daemon 133.5 MB
Sending build context to Docker daemon 134.1 MB
Sending build context to Docker daemon 134.6 MB
Sending build context to Docker daemon 135.2 MB
Sending build context to Docker daemon 135.7 MB
Sending build context to Docker daemon 136.3 MB
Sending build context to Docker daemon 136.8 MB
Sending build context to Docker daemon 137.4 MB
Sending build context to Docker daemon 138 MB
Sending build context to Docker daemon 138.5 MB
Sending build context to Docker daemon 139.1 MB
Sending build context to Docker daemon 139.6 MB
Sending build context to Docker daemon 140.2 MB
Sending build context to Docker daemon 140.7 MB
Sending build context to Docker daemon 141.3 MB
Sending build context to Docker daemon 141.9 MB
Sending build context to Docker daemon 142.4 MB
Sending build context to Docker daemon 143 MB
Sending build context to Docker daemon 143.5 MB
Sending build context to Docker daemon 144.1 MB
Sending build context to Docker daemon 144.6 MB
Sending build context to Docker daemon 145.2 MB
Sending build context to Docker daemon 145.8 MB
Sending build context to Docker daemon 146.3 MB
Sending build context to Docker daemon 146.9 MB
Sending build context to Docker daemon 147.4 MB
Sending build context to Docker daemon 148 MB
Sending build context to Docker daemon 148.5 MB
Sending build context to Docker daemon 149.1 MB
Sending build context to Docker daemon 149.7 MB
Sending build context to Docker daemon 150.2 MB
Sending build context to Docker daemon 150.8 MB
Sending build context to Docker daemon 151.3 MB
Sending build context to Docker daemon 151.9 MB
Sending build context to Docker daemon 152.4 MB
Sending build context to Docker daemon 153 MB
Sending build context to Docker daemon 153.6 MB
Sending build context to Docker daemon 154.1 MB
Sending build context to Docker daemon 154.7 MB
Sending build context to Docker daemon 155.2 MB
Sending build context to Docker daemon 155.8 MB
Sending build context to Docker daemon 156.3 MB
Sending build context to Docker daemon 156.9 MB
Sending build context to Docker daemon 157.5 MB
Sending build context to Docker daemon 158 MB
Sending build context to Docker daemon 158.6 MB
Sending build context to Docker daemon 159.1 MB
Sending build context to Docker daemon 159.7 MB
Sending build context to Docker daemon 160.2 MB
Sending build context to Docker daemon 160.8 MB
Sending build context to Docker daemon 161.3 MB
Sending build context to Docker daemon 161.9 MB
Sending build context to Docker daemon 162.5 MB
Sending build context to Docker daemon 163 MB
Sending build context to Docker daemon 163.6 MB
Sending build context to Docker daemon 164.1 MB
Sending build context to Docker daemon 164.7 MB
Sending build context to Docker daemon 165.2 MB
Sending build context to Docker daemon 165.8 MB
Sending build context to Docker daemon 166.4 MB
Sending build context to Docker daemon 166.9 MB
Sending build context to Docker daemon 167.5 MB
Sending build context to Docker daemon 168 MB
Sending build context to Docker daemon 168.6 MB
Sending build context to Docker daemon 169.1 MB
Sending build context to Docker daemon 169.7 MB
Sending build context to Docker daemon 170.3 MB
Sending build context to Docker daemon 170.8 MB
Sending build context to Docker daemon 171.4 MB
Sending build context to Docker daemon 171.9 MB
Sending build context to Docker daemon 172.5 MB
Sending build context to Docker daemon 173 MB
Sending build context to Docker daemon 173.6 MB
Sending build context to Docker daemon 174.2 MB
Sending build context to Docker daemon 174.7 MB
Sending build context to Docker daemon 175.3 MB
Sending build context to Docker daemon 175.8 MB
Sending build context to Docker daemon 176.4 MB
Sending build context to Docker daemon 176.9 MB
Sending build context to Docker daemon 177.5 MB
Sending build context to Docker daemon 178.1 MB
Sending build context to Docker daemon 178.6 MB
Sending build context to Docker daemon 179.2 MB
Sending build context to Docker daemon 179.7 MB
Sending build context to Docker daemon 180.3 MB
Sending build context to Docker daemon 180.8 MB
Sending build context to Docker daemon 181.4 MB
Sending build context to Docker daemon 182 MB
Sending build context to Docker daemon 182.5 MB
Sending build context to Docker daemon 183.1 MB
Sending build context to Docker daemon 183.6 MB
Sending build context to Docker daemon 184.2 MB
Sending build context to Docker daemon 184.7 MB
Sending build context to Docker daemon 185.3 MB
Sending build context to Docker daemon 185.9 MB
Sending build context to Docker daemon 186.4 MB
Sending build context to Docker daemon 187 MB
Sending build context to Docker daemon 187.5 MB
Sending build context to Docker daemon 188.1 MB
Sending build context to Docker daemon 188.6 MB
Sending build context to Docker daemon 189.2 MB
Sending build context to Docker daemon 189.8 MB
Sending build context to Docker daemon 190.3 MB
Sending build context to Docker daemon 190.9 MB
Sending build context to Docker daemon 191.4 MB
Sending build context to Docker daemon 192 MB
Sending build context to Docker daemon 192.5 MB
Sending build context to Docker daemon 193.1 MB
Sending build context to Docker daemon 193.7 MB
Sending build context to Docker daemon 194.2 MB
Sending build context to Docker daemon 194.8 MB
Sending build context to Docker daemon 195.3 MB
Sending build context to Docker daemon 195.9 MB
Sending build context to Docker daemon 196.4 MB
Sending build context to Docker daemon 197 MB
Sending build context to Docker daemon 197.6 MB
Sending build context to Docker daemon 198.1 MB
Sending build context to Docker daemon 198.7 MB
Sending build context to Docker daemon 199.2 MB
Sending build context to Docker daemon 199.8 MB
Sending build context to Docker daemon 200.3 MB
Sending build context to Docker daemon 200.9 MB
Sending build context to Docker daemon 201.5 MB
Sending build context to Docker daemon 202 MB
Sending build context to Docker daemon 202.6 MB
Sending build context to Docker daemon 203.1 MB
Sending build context to Docker daemon 203.7 MB
Sending build context to Docker daemon 204.2 MB
Sending build context to Docker daemon 204.8 MB
Sending build context to Docker daemon 205.4 MB
Sending build context to Docker daemon 205.9 MB
Sending build context to Docker daemon 206.5 MB
Sending build context to Docker daemon 207 MB
Sending build context to Docker daemon 207.6 MB
Sending build context to Docker daemon 208.1 MB
Sending build context to Docker daemon 208.7 MB
Sending build context to Docker daemon 209.3 MB
Sending build context to Docker daemon 209.8 MB
Sending build context to Docker daemon 210.4 MB
Sending build context to Docker daemon 210.9 MB
Sending build context to Docker daemon 211.5 MB
Sending build context to Docker daemon 212 MB
Sending build context to Docker daemon 212.6 MB
Sending build context to Docker daemon 213.2 MB
Sending build context to Docker daemon 213.7 MB
Sending build context to Docker daemon 214.3 MB
Sending build context to Docker daemon 214.8 MB
Sending build context to Docker daemon 215.4 MB
Sending build context to Docker daemon 215.9 MB
Sending build context to Docker daemon 216.5 MB
Sending build context to Docker daemon 217.1 MB
Sending build context to Docker daemon 217.6 MB
Sending build context to Docker daemon 218.2 MB
Sending build context to Docker daemon 218.7 MB
Sending build context to Docker daemon 219.3 MB
Sending build context to Docker daemon 219.8 MB
Sending build context to Docker daemon 220.4 MB
Sending build context to Docker daemon 221 MB
Sending build context to Docker daemon 221.5 MB
Sending build context to Docker daemon 222.1 MB
Sending build context to Docker daemon 222.6 MB
Sending build context to Docker daemon 223.2 MB
Sending build context to Docker daemon 223.7 MB
Sending build context to Docker daemon 224.3 MB
Sending build context to Docker daemon 224.9 MB
Sending build context to Docker daemon 225.4 MB
Sending build context to Docker daemon 226 MB
Sending build context to Docker daemon 226.5 MB
Sending build context to Docker daemon 227.1 MB
Sending build context to Docker daemon 227.6 MB
Sending build context to Docker daemon 228.2 MB
Sending build context to Docker daemon 228.8 MB
Sending build context to Docker daemon 229.3 MB
Sending build context to Docker daemon 229.9 MB
Sending build context to Docker daemon 230.4 MB
Sending build context to Docker daemon 231 MB
Sending build context to Docker daemon 231.5 MB
Sending build context to Docker daemon 232.1 MB
Sending build context to Docker daemon 232.7 MB
Sending build context to Docker daemon 233.2 MB
Sending build context to Docker daemon 233.8 MB
Sending build context to Docker daemon 234.3 MB
Sending build context to Docker daemon 234.9 MB
Sending build context to Docker daemon 235.4 MB
Sending build context to Docker daemon 236 MB
Sending build context to Docker daemon 236.6 MB
Sending build context to Docker daemon 237.1 MB
Sending build context to Docker daemon 237.7 MB
Sending build context to Docker daemon 238.2 MB
Sending build context to Docker daemon 238.8 MB
Sending build context to Docker daemon 239.3 MB
Sending build context to Docker daemon 239.9 MB
Sending build context to Docker daemon 240.5 MB
Sending build context to Docker daemon 241 MB
Sending build context to Docker daemon 241.6 MB
Sending build context to Docker daemon 242.1 MB
Sending build context to Docker daemon 242.7 MB
Sending build context to Docker daemon 243.2 MB
Sending build context to Docker daemon 243.8 MB
Sending build context to Docker daemon 244.3 MB
Sending build context to Docker daemon 244.9 MB
Sending build context to Docker daemon 245.4 MB
Sending build context to Docker daemon 246 MB
Sending build context to Docker daemon 246.5 MB
Sending build context to Docker daemon 247.1 MB
Sending build context to Docker daemon 247.7 MB
Sending build context to Docker daemon 248.2 MB
Sending build context to Docker daemon 248.8 MB
Sending build context to Docker daemon 249.3 MB
Sending build context to Docker daemon 249.9 MB
Sending build context to Docker daemon 250.4 MB
Sending build context to Docker daemon 251 MB
Sending build context to Docker daemon 251.6 MB
Sending build context to Docker daemon 252.1 MB
Sending build context to Docker daemon 252.7 MB
Sending build context to Docker daemon 253.2 MB
Sending build context to Docker daemon 253.8 MB
Sending build context to Docker daemon 254.3 MB
Sending build context to Docker daemon 254.9 MB
Sending build context to Docker daemon 255.4 MB
Sending build context to Docker daemon 256 MB
Sending build context to Docker daemon 256.5 MB
Sending build context to Docker daemon 257 MB
Sending build context to Docker daemon 257.6 MB
Sending build context to Docker daemon 258.1 MB
Sending build context to Docker daemon 258.7 MB
Sending build context to Docker daemon 259.3 MB
Sending build context to Docker daemon 259.8 MB
Sending build context to Docker daemon 260.4 MB
Sending build context to Docker daemon 260.9 MB
Sending build context to Docker daemon 261.5 MB
Sending build context to Docker daemon 262 MB
Sending build context to Docker daemon 262.6 MB
Sending build context to Docker daemon 263.2 MB
Sending build context to Docker daemon 263.7 MB
Sending build context to Docker daemon 264.3 MB
Sending build context to Docker daemon 264.8 MB
Sending build context to Docker daemon 265.4 MB
Sending build context to Docker daemon 265.9 MB
Sending build context to Docker daemon 266.5 MB
Sending build context to Docker daemon 267.1 MB
Sending build context to Docker daemon 267.6 MB
Sending build context to Docker daemon 268.2 MB
Sending build context to Docker daemon 268.7 MB
Sending build context to Docker daemon 269.3 MB
Sending build context to Docker daemon 269.8 MB
Sending build context to Docker daemon 270.4 MB
Sending build context to Docker daemon 271 MB
Sending build context to Docker daemon 271.5 MB
Sending build context to Docker daemon 272.1 MB
Sending build context to Docker daemon 272.6 MB
Sending build context to Docker daemon 273.2 MB
Sending build context to Docker daemon 273.7 MB
Sending build context to Docker daemon 274.3 MB
Sending build context to Docker daemon 274.8 MB
Sending build context to Docker daemon 275.4 MB
Sending build context to Docker daemon 275.9 MB
Sending build context to Docker daemon 276.4 MB
Sending build context to Docker daemon 277 MB
Sending build context to Docker daemon 277.5 MB
Sending build context to Docker daemon 278 MB
Sending build context to Docker daemon 278.6 MB
Sending build context to Docker daemon 279.2 MB
Sending build context to Docker daemon 279.7 MB
Sending build context to Docker daemon 280.2 MB
Sending build context to Docker daemon 280.7 MB
Sending build context to Docker daemon 281.3 MB
Sending build context to Docker daemon 281.8 MB
Sending build context to Docker daemon 282.3 MB
Sending build context to Docker daemon 282.9 MB
Sending build context to Docker daemon 283.4 MB
Sending build context to Docker daemon 283.9 MB
Sending build context to Docker daemon 284.5 MB
Sending build context to Docker daemon 285 MB
Sending build context to Docker daemon 285.5 MB
Sending build context to Docker daemon 286 MB
Sending build context to Docker daemon 286.6 MB
Sending build context to Docker daemon 287.1 MB
Sending build context to Docker daemon 287.7 MB
Sending build context to Docker daemon 288.2 MB
Sending build context to Docker daemon 288.7 MB
Sending build context to Docker daemon 288.7 MB
Step 1 : FROM ubuntu:14.04
---> c4bea91afef3
Step 2 : RUN rm -rf /var/lib/apt/lists/get.docker.io_ubuntu_dists_docker_main_binary-amd64_Packages /var/lib/apt/lists/get.docker.io_ubuntu_dists_docker_main_binary-i386_Packages /var/lib/apt/lists/get.docker.io_ubuntu_dists_docker_Release /var/lib/apt/lists/get.docker.io_ubuntu_dists_docker_Release.gpg /var/lib/apt/lists/lock /var/lib/apt/lists/packages.apache.org_asf%5finternal_dists_trusty_main_binary-amd64_Packages /var/lib/apt/lists/packages.apache.org_asf%5finternal_dists_trusty_main_binary-i386_Packages /var/lib/apt/lists/packages.apache.org_asf%5finternal_dists_trusty_Release /var/lib/apt/lists/packages.apache.org_asf%5finternal_dists_trusty_Release.gpg /var/lib/apt/lists/partial /var/lib/apt/lists/ppa.launchpad.net_webupd8team_java_ubuntu_dists_trusty_main_binary-amd64_Packages /var/lib/apt/lists/ppa.launchpad.net_webupd8team_java_ubuntu_dists_trusty_main_binary-i386_Packages /var/lib/apt/lists/ppa.launchpad.net_webupd8team_java_ubuntu_dists_trusty_main_i18n_Translation-en /
var/lib/apt/lists/ppa.launchpad.net_webupd8team_java_ubuntu_dists_trusty_main_source_Sources /var/lib/apt/lists/ppa.launchpad.net_webupd8team_java_ubuntu_dists_trusty_Release /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_InRelease /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_main_binary-amd64_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_main_binary-i386_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_main_i18n_Translation-en /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_main_source_Sources /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_multiverse_binary-amd64_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_multiverse_binary-i386_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_multiverse_i18n_Translation-en /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_multiv
erse_source_Sources /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_restricted_binary-amd64_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_restricted_binary-i386_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_restricted_i18n_Translation-en /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_restricted_source_Sources /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_universe_binary-amd64_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_universe_binary-i386_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_universe_i18n_Translation-en /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_universe_source_Sources /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_InRelease /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_main_binary-amd64_Packages /var/lib/apt/lists
/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_main_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_main_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_main_source_Sources /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_multiverse_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_multiverse_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_multiverse_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_multiverse_source_Sources /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_restricted_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_restricted_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_restricted_i18n_Translation-en /var/lib/apt/lis
ts/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_restricted_source_Sources /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_universe_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_universe_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_universe_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_universe_source_Sources /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty_main_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty_main_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty_main_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty_main_source_Sources /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty_multiverse_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty_multiverse_binary-i38
6_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty_multiverse_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty_multiverse_source_Sources /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty_Release /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty_Release.gpg /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty_restricted_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty_restricted_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty_restricted_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty_restricted_source_Sources /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty_universe_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty_universe_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty_universe_i18n_Translation-en /var/lib/apt/lists/us.arch
ive.ubuntu.com_ubuntu_dists_trusty_universe_source_Sources /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-updates_InRelease /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-updates_main_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-updates_main_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-updates_main_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-updates_main_source_Sources /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-updates_multiverse_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-updates_multiverse_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-updates_multiverse_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-updates_multiverse_source_Sources /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-updates_restricted_binary-
amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-updates_restricted_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-updates_restricted_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-updates_restricted_source_Sources /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-updates_universe_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-updates_universe_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-updates_universe_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-updates_universe_source_Sources
---> Running in 03626a364384
---> 2c52e7778005
Removing intermediate container 03626a364384
Step 3 : RUN apt-get update
---> Running in e9f54b7b42ce
Ign http://archive.ubuntu.com trusty InRelease
Get:1 http://archive.ubuntu.com trusty-updates InRelease [64.4 kB]
Get:2 http://archive.ubuntu.com trusty-security InRelease [64.4 kB]
Hit http://archive.ubuntu.com trusty Release.gpg
Hit http://archive.ubuntu.com trusty Release
Get:3 http://archive.ubuntu.com trusty-updates/main Sources [311 kB]
Get:4 http://archive.ubuntu.com trusty-updates/restricted Sources [5219 B]
Get:5 http://archive.ubuntu.com trusty-updates/universe Sources [183 kB]
Get:6 http://archive.ubuntu.com trusty-updates/main amd64 Packages [857 kB]
Get:7 http://archive.ubuntu.com trusty-updates/restricted amd64 Packages [23.4 kB]
Get:8 http://archive.ubuntu.com trusty-updates/universe amd64 Packages [432 kB]
Get:9 http://archive.ubuntu.com trusty-security/main Sources [129 kB]
Get:10 http://archive.ubuntu.com trusty-security/restricted Sources [3920 B]
Get:11 http://archive.ubuntu.com trusty-security/universe Sources [36.9 kB]
Get:12 http://archive.ubuntu.com trusty-security/main amd64 Packages [501 kB]
Get:13 http://archive.ubuntu.com trusty-security/restricted amd64 Packages [20.2 kB]
Get:14 http://archive.ubuntu.com trusty-security/universe amd64 Packages [159 kB]
Get:15 http://archive.ubuntu.com trusty/main Sources [1335 kB]
Get:16 http://archive.ubuntu.com trusty/restricted Sources [5335 B]
Get:17 http://archive.ubuntu.com trusty/universe Sources [7926 kB]
Get:18 http://archive.ubuntu.com trusty/main amd64 Packages [1743 kB]
Get:19 http://archive.ubuntu.com trusty/restricted amd64 Packages [16.0 kB]
Get:20 http://archive.ubuntu.com trusty/universe amd64 Packages [7589 kB]
Fetched 21.4 MB in 4s (4552 kB/s)
[91mW: Failed to fetch http://archive.ubuntu.com/ubuntu/dists/trusty-updates/main/source/Sources Hash Sum mismatch
W: Failed to fetch http://archive.ubuntu.com/ubuntu/dists/trusty-updates/main/binary-amd64/Packages Hash Sum mismatch
W: Failed to fetch http://archive.ubuntu.com/ubuntu/dists/trusty-updates/universe/binary-amd64/Packages Hash Sum mismatch
E: Some index files failed to download. They have been ignored, or old ones used instead.
[0mThe command '/bin/sh -c apt-get update' returned a non-zero code: 100
- Mesos ReviewBot
On Jan. 11, 2016, 2:47 p.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2016, 2:47 p.m.)
>
>
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
>
>
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add tests for /weights endpoint.
>
>
> Diffs
> -----
>
> src/Makefile.am 8cbfb1ba5fa49f2d3cc26ea325838a1c68a79660
> src/tests/dynamic_weights_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41790/diff/
>
>
> Testing
> -------
>
> Make and Make check successfully!
>
> ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
> [==========] Running 11 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 11 tests from DynamicWeightsTest
> [ RUN ] DynamicWeightsTest.PutInvalidRequest
> [ OK ] DynamicWeightsTest.PutInvalidRequest (102 ms)
> [ RUN ] DynamicWeightsTest.ZeroWeight
> [ OK ] DynamicWeightsTest.ZeroWeight (38 ms)
> [ RUN ] DynamicWeightsTest.NegativeWeight
> [ OK ] DynamicWeightsTest.NegativeWeight (38 ms)
> [ RUN ] DynamicWeightsTest.MissingRole
> [ OK ] DynamicWeightsTest.MissingRole (43 ms)
> [ RUN ] DynamicWeightsTest.UnknownRole
> [ OK ] DynamicWeightsTest.UnknownRole (36 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (44 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (52 ms)
> [ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
> [ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (40 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (32 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
> [ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (37 ms)
> [ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (30 ms)
> [----------] 11 tests from DynamicWeightsTest (492 ms total)
>
> [----------] Global test environment tear-down
> [==========] 11 tests from 1 test case ran. (503 ms total)
> [ PASSED ] 11 tests.
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/#review113980
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41597, 41681, 41789, 41790]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 12, 2016, 7:30 a.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 7:30 a.m.)
>
>
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
>
>
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add tests for /weights endpoint.
>
>
> Diffs
> -----
>
> src/Makefile.am 8cbfb1ba5fa49f2d3cc26ea325838a1c68a79660
> src/tests/dynamic_weights_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41790/diff/
>
>
> Testing
> -------
>
> Make and Make check successfully!
>
> ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
> [==========] Running 11 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 11 tests from DynamicWeightsTest
> [ RUN ] DynamicWeightsTest.PutInvalidRequest
> [ OK ] DynamicWeightsTest.PutInvalidRequest (102 ms)
> [ RUN ] DynamicWeightsTest.ZeroWeight
> [ OK ] DynamicWeightsTest.ZeroWeight (38 ms)
> [ RUN ] DynamicWeightsTest.NegativeWeight
> [ OK ] DynamicWeightsTest.NegativeWeight (38 ms)
> [ RUN ] DynamicWeightsTest.MissingRole
> [ OK ] DynamicWeightsTest.MissingRole (43 ms)
> [ RUN ] DynamicWeightsTest.UnknownRole
> [ OK ] DynamicWeightsTest.UnknownRole (36 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (44 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (52 ms)
> [ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
> [ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (40 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (32 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
> [ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (37 ms)
> [ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (30 ms)
> [----------] 11 tests from DynamicWeightsTest (492 ms total)
>
> [----------] Global test environment tear-down
> [==========] 11 tests from 1 test case ran. (503 ms total)
> [ PASSED ] 11 tests.
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/#review115398
-----------------------------------------------------------
src/tests/dynamic_weights_tests.cpp (line 120)
<https://reviews.apache.org/r/41790/#comment176398>
Please put the open brace `{` on a new line.
src/tests/dynamic_weights_tests.cpp (line 400)
<https://reviews.apache.org/r/41790/#comment176399>
s/role/roles/
- Adam B
On Jan. 20, 2016, 1:14 a.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2016, 1:14 a.m.)
>
>
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
>
>
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add tests for /weights endpoint.
>
>
> Diffs
> -----
>
> src/Makefile.am 4fabe600d4ba38c95a777d622b0b675dd5811a53
> src/tests/dynamic_weights_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41790/diff/
>
>
> Testing
> -------
>
> Make and Make check successfully!
>
> ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
> [==========] Running 11 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 11 tests from DynamicWeightsTest
> [ RUN ] DynamicWeightsTest.PutInvalidRequest
> [ OK ] DynamicWeightsTest.PutInvalidRequest (102 ms)
> [ RUN ] DynamicWeightsTest.ZeroWeight
> [ OK ] DynamicWeightsTest.ZeroWeight (38 ms)
> [ RUN ] DynamicWeightsTest.NegativeWeight
> [ OK ] DynamicWeightsTest.NegativeWeight (38 ms)
> [ RUN ] DynamicWeightsTest.MissingRole
> [ OK ] DynamicWeightsTest.MissingRole (43 ms)
> [ RUN ] DynamicWeightsTest.UnknownRole
> [ OK ] DynamicWeightsTest.UnknownRole (36 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (44 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (52 ms)
> [ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
> [ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (40 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (32 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
> [ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (37 ms)
> [ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (30 ms)
> [----------] 11 tests from DynamicWeightsTest (492 ms total)
>
> [----------] Global test environment tear-down
> [==========] 11 tests from 1 test case ran. (503 ms total)
> [ PASSED ] 11 tests.
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/#review115567
-----------------------------------------------------------
Bad patch!
Reviews applied: [41597, 41681, 41789]
Failed command: ./support/apply-review.sh -n -r 41789
Error:
2016-01-21 05:51:10 URL:https://reviews.apache.org/r/41789/diff/raw/ [8436/8436] -> "41789.patch" [1]
error: patch failed: 3rdparty/libprocess/src/tests/http_tests.cpp:92
error: 3rdparty/libprocess/src/tests/http_tests.cpp: patch does not apply
- Mesos ReviewBot
On Jan. 21, 2016, 3:08 a.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2016, 3:08 a.m.)
>
>
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
>
>
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add tests for /weights endpoint.
>
>
> Diffs
> -----
>
> src/Makefile.am 4fabe600d4ba38c95a777d622b0b675dd5811a53
> src/tests/dynamic_weights_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41790/diff/
>
>
> Testing
> -------
>
> Make and Make check successfully!
>
> ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
> [==========] Running 11 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 11 tests from DynamicWeightsTest
> [ RUN ] DynamicWeightsTest.PutInvalidRequest
> [ OK ] DynamicWeightsTest.PutInvalidRequest (102 ms)
> [ RUN ] DynamicWeightsTest.ZeroWeight
> [ OK ] DynamicWeightsTest.ZeroWeight (38 ms)
> [ RUN ] DynamicWeightsTest.NegativeWeight
> [ OK ] DynamicWeightsTest.NegativeWeight (38 ms)
> [ RUN ] DynamicWeightsTest.MissingRole
> [ OK ] DynamicWeightsTest.MissingRole (43 ms)
> [ RUN ] DynamicWeightsTest.UnknownRole
> [ OK ] DynamicWeightsTest.UnknownRole (36 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (44 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (52 ms)
> [ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
> [ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (40 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (32 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
> [ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (37 ms)
> [ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (30 ms)
> [----------] 11 tests from DynamicWeightsTest (492 ms total)
>
> [----------] Global test environment tear-down
> [==========] 11 tests from 1 test case ran. (503 ms total)
> [ PASSED ] 11 tests.
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/#review116040
-----------------------------------------------------------
Bad patch!
Reviews applied: [41597]
Failed command: ./support/apply-review.sh -n -r 41597
Error:
...<truncated>...
2016-01-25 02:34:11 URL:https://reviews.apache.org/r/41597/diff/raw/ [7672/7672] -> "41597.patch" [1]
error: patch failed: src/master/allocator/mesos/hierarchical.cpp:1043
error: src/master/allocator/mesos/hierarchical.cpp: patch does not apply
Full log: https://builds.apache.org/job/mesos-reviewbot/11017/console
- Mesos ReviewBot
On Jan. 25, 2016, 1:51 a.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2016, 1:51 a.m.)
>
>
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
>
>
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add tests for /weights endpoint.
>
>
> Diffs
> -----
>
> src/Makefile.am 19bf3a7c2e43ca04ed6e6d506e052de5537f7c2f
> src/tests/dynamic_weights_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41790/diff/
>
>
> Testing
> -------
>
> Make and Make check successfully!
>
> ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
> [==========] Running 11 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 11 tests from DynamicWeightsTest
> [ RUN ] DynamicWeightsTest.PutInvalidRequest
> [ OK ] DynamicWeightsTest.PutInvalidRequest (102 ms)
> [ RUN ] DynamicWeightsTest.ZeroWeight
> [ OK ] DynamicWeightsTest.ZeroWeight (38 ms)
> [ RUN ] DynamicWeightsTest.NegativeWeight
> [ OK ] DynamicWeightsTest.NegativeWeight (38 ms)
> [ RUN ] DynamicWeightsTest.MissingRole
> [ OK ] DynamicWeightsTest.MissingRole (43 ms)
> [ RUN ] DynamicWeightsTest.UnknownRole
> [ OK ] DynamicWeightsTest.UnknownRole (36 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (44 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (52 ms)
> [ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
> [ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (40 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (32 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
> [ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (37 ms)
> [ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (30 ms)
> [----------] 11 tests from DynamicWeightsTest (492 ms total)
>
> [----------] Global test environment tear-down
> [==========] 11 tests from 1 test case ran. (503 ms total)
> [ PASSED ] 11 tests.
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Adam B <ad...@mesosphere.io>.
> On Feb. 27, 2016, 4:21 a.m., Adam B wrote:
> > Sorry this took me forever to get to. Looks pretty good except for some indentation and some unnecessary lines.
> > I'd also like to see a couple of registrar tests, like AlexR suggested.
>
> Yongqiao Wang wrote:
> Thanks Adam. I will add a couple of registrar tests later in another patches, is it OK?
Sure, it can go in a later patch, but let's make sure not to forget it.
- Adam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/#review121077
-----------------------------------------------------------
On Feb. 27, 2016, 5:55 a.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2016, 5:55 a.m.)
>
>
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
>
>
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add tests for /weights endpoint.
>
>
> Diffs
> -----
>
> src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5
> src/tests/dynamic_weights_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41790/diff/
>
>
> Testing
> -------
>
> Make and Make check successfully!
>
> ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
> [==========] Running 11 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 11 tests from DynamicWeightsTest
> [ RUN ] DynamicWeightsTest.PutInvalidRequest
> [ OK ] DynamicWeightsTest.PutInvalidRequest (85 ms)
> [ RUN ] DynamicWeightsTest.ZeroWeight
> [ OK ] DynamicWeightsTest.ZeroWeight (46 ms)
> [ RUN ] DynamicWeightsTest.NegativeWeight
> [ OK ] DynamicWeightsTest.NegativeWeight (49 ms)
> [ RUN ] DynamicWeightsTest.NonNumericWeight
> [ OK ] DynamicWeightsTest.NonNumericWeight (49 ms)
> [ RUN ] DynamicWeightsTest.MissingRole
> [ OK ] DynamicWeightsTest.MissingRole (50 ms)
> [ RUN ] DynamicWeightsTest.UnknownRole
> [ OK ] DynamicWeightsTest.UnknownRole (49 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (45 ms)
> [ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
> [ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (45 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (37 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
> [ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (36 ms)
> [ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (35 ms)
> [----------] 11 tests from DynamicWeightsTest (527 ms total)
>
> [----------] Global test environment tear-down
> [==========] 11 tests from 1 test case ran. (536 ms total)
> [ PASSED ] 11 tests.
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Yongqiao Wang <yq...@cn.ibm.com>.
> On Feb. 27, 2016, 12:21 p.m., Adam B wrote:
> > Sorry this took me forever to get to. Looks pretty good except for some indentation and some unnecessary lines.
> > I'd also like to see a couple of registrar tests, like AlexR suggested.
>
> Yongqiao Wang wrote:
> Thanks Adam. I will add a couple of registrar tests later in another patches, is it OK?
>
> Adam B wrote:
> Sure, it can go in a later patch, but let's make sure not to forget it.
I have logged a separated JIRA ticket #MESOS-4797 to trace this task.
- Yongqiao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/#review121077
-----------------------------------------------------------
On Feb. 27, 2016, 1:55 p.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2016, 1:55 p.m.)
>
>
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
>
>
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add tests for /weights endpoint.
>
>
> Diffs
> -----
>
> src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5
> src/tests/dynamic_weights_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41790/diff/
>
>
> Testing
> -------
>
> Make and Make check successfully!
>
> ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
> [==========] Running 11 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 11 tests from DynamicWeightsTest
> [ RUN ] DynamicWeightsTest.PutInvalidRequest
> [ OK ] DynamicWeightsTest.PutInvalidRequest (85 ms)
> [ RUN ] DynamicWeightsTest.ZeroWeight
> [ OK ] DynamicWeightsTest.ZeroWeight (46 ms)
> [ RUN ] DynamicWeightsTest.NegativeWeight
> [ OK ] DynamicWeightsTest.NegativeWeight (49 ms)
> [ RUN ] DynamicWeightsTest.NonNumericWeight
> [ OK ] DynamicWeightsTest.NonNumericWeight (49 ms)
> [ RUN ] DynamicWeightsTest.MissingRole
> [ OK ] DynamicWeightsTest.MissingRole (50 ms)
> [ RUN ] DynamicWeightsTest.UnknownRole
> [ OK ] DynamicWeightsTest.UnknownRole (49 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (45 ms)
> [ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
> [ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (45 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (37 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
> [ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (36 ms)
> [ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (35 ms)
> [----------] 11 tests from DynamicWeightsTest (527 ms total)
>
> [----------] Global test environment tear-down
> [==========] 11 tests from 1 test case ran. (536 ms total)
> [ PASSED ] 11 tests.
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Yongqiao Wang <yq...@cn.ibm.com>.
> On Feb. 27, 2016, 12:21 p.m., Adam B wrote:
> > Sorry this took me forever to get to. Looks pretty good except for some indentation and some unnecessary lines.
> > I'd also like to see a couple of registrar tests, like AlexR suggested.
Thanks Adam. I will add a couple of registrar tests later in another patches, is it OK?
- Yongqiao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/#review121077
-----------------------------------------------------------
On Jan. 25, 2016, 3:47 p.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2016, 3:47 p.m.)
>
>
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
>
>
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add tests for /weights endpoint.
>
>
> Diffs
> -----
>
> src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6
> src/tests/dynamic_weights_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41790/diff/
>
>
> Testing
> -------
>
> Make and Make check successfully!
>
> ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
> [==========] Running 11 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 11 tests from DynamicWeightsTest
> [ RUN ] DynamicWeightsTest.PutInvalidRequest
> [ OK ] DynamicWeightsTest.PutInvalidRequest (102 ms)
> [ RUN ] DynamicWeightsTest.ZeroWeight
> [ OK ] DynamicWeightsTest.ZeroWeight (38 ms)
> [ RUN ] DynamicWeightsTest.NegativeWeight
> [ OK ] DynamicWeightsTest.NegativeWeight (38 ms)
> [ RUN ] DynamicWeightsTest.MissingRole
> [ OK ] DynamicWeightsTest.MissingRole (43 ms)
> [ RUN ] DynamicWeightsTest.UnknownRole
> [ OK ] DynamicWeightsTest.UnknownRole (36 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (44 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (52 ms)
> [ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
> [ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (40 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (32 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
> [ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (37 ms)
> [ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (30 ms)
> [----------] 11 tests from DynamicWeightsTest (492 ms total)
>
> [----------] Global test environment tear-down
> [==========] 11 tests from 1 test case ran. (503 ms total)
> [ PASSED ] 11 tests.
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/#review121077
-----------------------------------------------------------
Sorry this took me forever to get to. Looks pretty good except for some indentation and some unnecessary lines.
I'd also like to see a couple of registrar tests, like AlexR suggested.
src/tests/dynamic_weights_tests.cpp (lines 71 - 74)
<https://reviews.apache.org/r/41790/#comment182667>
You can just use `process::http::Headers` instead.
src/tests/dynamic_weights_tests.cpp (line 108)
<https://reviews.apache.org/r/41790/#comment182674>
s/Req/Request/ (we don't like abbrev's)
src/tests/dynamic_weights_tests.cpp (line 113)
<https://reviews.apache.org/r/41790/#comment182675>
s/json/"%s"/ - no reaon to create a local variable for a string constant that isn't reused.
src/tests/dynamic_weights_tests.cpp (lines 134 - 150)
<https://reviews.apache.org/r/41790/#comment182676>
Seems like this should be an if/else, rather than always evaluating JSON::parse("[...]") even if the value's getting thrown away. Maybe something more like:
```Try<JSON::Value> expected;
if (weights == "") {
expected = "[..short..]";
} else if (weights == WEIGHTS) {
expected = "[...longer...]";
} else {
expected = Error("Unexpected weights string.");
}```
src/tests/dynamic_weights_tests.cpp (lines 215 - 219)
<https://reviews.apache.org/r/41790/#comment182677>
This seems like an arbitrary indentation. Either align with the parentheses (too far over in this case), or indent 4 spaces in from the previous line.
src/tests/dynamic_weights_tests.cpp (lines 215 - 219)
<https://reviews.apache.org/r/41790/#comment182678>
This seems like an arbitrary indentation. Either align with the parentheses (too far over in this case), or indent 4 spaces in from the previous line.
src/tests/dynamic_weights_tests.cpp (line 227)
<https://reviews.apache.org/r/41790/#comment182679>
s/filed/field/
src/tests/dynamic_weights_tests.cpp (lines 236 - 240)
<https://reviews.apache.org/r/41790/#comment182680>
Fix the indent again, everywhere.
src/tests/dynamic_weights_tests.cpp (line 247)
<https://reviews.apache.org/r/41790/#comment182681>
Soon this line won't be necessary, but we'll try to get your patch committed before Joseph's so he's the one who has to rebase, not you. :)
src/tests/dynamic_weights_tests.cpp (line 290)
<https://reviews.apache.org/r/41790/#comment182682>
Please add another Bad Request test for a non-numeric weight value, like "role1=two"
src/tests/dynamic_weights_tests.cpp (line 322)
<https://reviews.apache.org/r/41790/#comment182683>
s/empty (Only a space) role/empty role (only a space)/
src/tests/dynamic_weights_tests.cpp (line 400)
<https://reviews.apache.org/r/41790/#comment182687>
s/does not/not/
src/tests/dynamic_weights_tests.cpp (line 472)
<https://reviews.apache.org/r/41790/#comment182689>
You can remove the `UpdateWeightsWithImplicitRoles` test, since this test already tests implicit roles.
src/tests/dynamic_weights_tests.cpp (line 523)
<https://reviews.apache.org/r/41790/#comment182690>
This line should be unnecessary. If there are no credentials in the request, and authenticate_http=false (meaning authn is not required), then your request should be allowed through without authn.
In this setup, the master would still use its --credentials to authenticate any client that tries to use credentials.
src/tests/dynamic_weights_tests.cpp (lines 553 - 556)
<https://reviews.apache.org/r/41790/#comment182691>
These lines should be unnecessary if the ACLs are restrictive by default.
- Adam B
On Jan. 25, 2016, 7:47 a.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2016, 7:47 a.m.)
>
>
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
>
>
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add tests for /weights endpoint.
>
>
> Diffs
> -----
>
> src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6
> src/tests/dynamic_weights_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41790/diff/
>
>
> Testing
> -------
>
> Make and Make check successfully!
>
> ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
> [==========] Running 11 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 11 tests from DynamicWeightsTest
> [ RUN ] DynamicWeightsTest.PutInvalidRequest
> [ OK ] DynamicWeightsTest.PutInvalidRequest (102 ms)
> [ RUN ] DynamicWeightsTest.ZeroWeight
> [ OK ] DynamicWeightsTest.ZeroWeight (38 ms)
> [ RUN ] DynamicWeightsTest.NegativeWeight
> [ OK ] DynamicWeightsTest.NegativeWeight (38 ms)
> [ RUN ] DynamicWeightsTest.MissingRole
> [ OK ] DynamicWeightsTest.MissingRole (43 ms)
> [ RUN ] DynamicWeightsTest.UnknownRole
> [ OK ] DynamicWeightsTest.UnknownRole (36 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (44 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (52 ms)
> [ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
> [ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (40 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (32 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
> [ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (37 ms)
> [ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (30 ms)
> [----------] 11 tests from DynamicWeightsTest (492 ms total)
>
> [----------] Global test environment tear-down
> [==========] 11 tests from 1 test case ran. (503 ms total)
> [ PASSED ] 11 tests.
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/#review116141
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41597, 41681, 41789, 41790]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 25, 2016, 3:47 p.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2016, 3:47 p.m.)
>
>
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
>
>
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add tests for /weights endpoint.
>
>
> Diffs
> -----
>
> src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6
> src/tests/dynamic_weights_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41790/diff/
>
>
> Testing
> -------
>
> Make and Make check successfully!
>
> ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
> [==========] Running 11 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 11 tests from DynamicWeightsTest
> [ RUN ] DynamicWeightsTest.PutInvalidRequest
> [ OK ] DynamicWeightsTest.PutInvalidRequest (102 ms)
> [ RUN ] DynamicWeightsTest.ZeroWeight
> [ OK ] DynamicWeightsTest.ZeroWeight (38 ms)
> [ RUN ] DynamicWeightsTest.NegativeWeight
> [ OK ] DynamicWeightsTest.NegativeWeight (38 ms)
> [ RUN ] DynamicWeightsTest.MissingRole
> [ OK ] DynamicWeightsTest.MissingRole (43 ms)
> [ RUN ] DynamicWeightsTest.UnknownRole
> [ OK ] DynamicWeightsTest.UnknownRole (36 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (44 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (52 ms)
> [ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
> [ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (40 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (32 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
> [ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (37 ms)
> [ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (30 ms)
> [----------] 11 tests from DynamicWeightsTest (492 ms total)
>
> [----------] Global test environment tear-down
> [==========] 11 tests from 1 test case ran. (503 ms total)
> [ PASSED ] 11 tests.
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/#review121092
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41597, 41681, 43863, 41790]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 27, 2016, 1:55 p.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2016, 1:55 p.m.)
>
>
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
>
>
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add tests for /weights endpoint.
>
>
> Diffs
> -----
>
> src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5
> src/tests/dynamic_weights_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41790/diff/
>
>
> Testing
> -------
>
> Make and Make check successfully!
>
> ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
> [==========] Running 11 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 11 tests from DynamicWeightsTest
> [ RUN ] DynamicWeightsTest.PutInvalidRequest
> [ OK ] DynamicWeightsTest.PutInvalidRequest (85 ms)
> [ RUN ] DynamicWeightsTest.ZeroWeight
> [ OK ] DynamicWeightsTest.ZeroWeight (46 ms)
> [ RUN ] DynamicWeightsTest.NegativeWeight
> [ OK ] DynamicWeightsTest.NegativeWeight (49 ms)
> [ RUN ] DynamicWeightsTest.NonNumericWeight
> [ OK ] DynamicWeightsTest.NonNumericWeight (49 ms)
> [ RUN ] DynamicWeightsTest.MissingRole
> [ OK ] DynamicWeightsTest.MissingRole (50 ms)
> [ RUN ] DynamicWeightsTest.UnknownRole
> [ OK ] DynamicWeightsTest.UnknownRole (49 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (45 ms)
> [ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
> [ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (45 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (37 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
> [ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (36 ms)
> [ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (35 ms)
> [----------] 11 tests from DynamicWeightsTest (527 ms total)
>
> [----------] Global test environment tear-down
> [==========] 11 tests from 1 test case ran. (536 ms total)
> [ PASSED ] 11 tests.
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/#review122696
-----------------------------------------------------------
Looks like you bumped this down in the review chain to come last, after r/44512 (Support to get weights info by /weights). If you revert to the previous revision, depending on /roles instead of GET /weights, then I can commit these tests much sooner, and you can add a patch later to update the tests to use GET /weights.
- Adam B
On March 8, 2016, 9:52 p.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> -----------------------------------------------------------
>
> (Updated March 8, 2016, 9:52 p.m.)
>
>
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
>
>
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add tests for /weights endpoint.
>
>
> Diffs
> -----
>
> src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261
> src/tests/dynamic_weights_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41790/diff/
>
>
> Testing
> -------
>
> Make and Make check successfully!
>
> $ ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
> [==========] Running 11 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 11 tests from DynamicWeightsTest
> [ RUN ] DynamicWeightsTest.PutInvalidRequest
> [ OK ] DynamicWeightsTest.PutInvalidRequest (87 ms)
> [ RUN ] DynamicWeightsTest.ZeroWeight
> [ OK ] DynamicWeightsTest.ZeroWeight (44 ms)
> [ RUN ] DynamicWeightsTest.NegativeWeight
> [ OK ] DynamicWeightsTest.NegativeWeight (42 ms)
> [ RUN ] DynamicWeightsTest.NonNumericWeight
> [ OK ] DynamicWeightsTest.NonNumericWeight (37 ms)
> [ RUN ] DynamicWeightsTest.MissingRole
> [ OK ] DynamicWeightsTest.MissingRole (42 ms)
> [ RUN ] DynamicWeightsTest.UnknownRole
> [ OK ] DynamicWeightsTest.UnknownRole (38 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (38 ms)
> [ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
> [ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (35 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (45 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
> [ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (38 ms)
> [ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (35 ms)
> [----------] 11 tests from DynamicWeightsTest (482 ms total)
>
> [----------] Global test environment tear-down
> [==========] 11 tests from 1 test case ran. (490 ms total)
> [ PASSED ] 11 tests.
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/#review123358
-----------------------------------------------------------
Fix it, then Ship it!
Thanks for updating this back to a GET on /roles. Fix these minor points and I'll get this committed asap.
src/tests/dynamic_weights_tests.cpp (line 117)
<https://reviews.apache.org/r/41790/#comment185576>
I recently committed Joerg's change to add authentication to more master endpoints, including /roles. You probably need to update this to:
```
response = process::http::get(
master.get(),
"roles",
None(),
createBasicAuthHeaders(DEFAULT_CREDENTIAL));
```
src/tests/dynamic_weights_tests.cpp (line 114)
<https://reviews.apache.org/r/41790/#comment185589>
We prefer to use Option in our method parameters, rather than null pointers or empty strings.
So, this should be `const Option<string>& weights = None()`, and the `weights == ""` check below should be a `weights.isNone()` check.
src/tests/dynamic_weights_tests.cpp (line 323)
<https://reviews.apache.org/r/41790/#comment185590>
Nit: s/they're/they are/
src/tests/dynamic_weights_tests.cpp (line 367)
<https://reviews.apache.org/r/41790/#comment185591>
"Specify --roles whitelist when starting master."
src/tests/dynamic_weights_tests.cpp (line 397)
<https://reviews.apache.org/r/41790/#comment185592>
"Specify --roles whitelist when starting master."
src/tests/dynamic_weights_tests.cpp (line 401)
<https://reviews.apache.org/r/41790/#comment185593>
Can you `checkWithRolesEndpoint(master);` here, so we know that role1 and role2 start with default weights before the update request?
Or will the explicit roles flag cause the /roles endpoint to list them differently from your default? More like a weights flag of "role1=1.0,role2=1.0"
src/tests/dynamic_weights_tests.cpp (lines 443 - 444)
<https://reviews.apache.org/r/41790/#comment185594>
Please wrap at the `<<` instead of the `(`:
```
AWAIT_EXPECT_RESPONSE_STATUS_EQ(Unauthorized({}).status, response1)
<< response1.get().body;
```
src/tests/dynamic_weights_tests.cpp (lines 457 - 458)
<https://reviews.apache.org/r/41790/#comment185595>
Wrap at `<<` instead
src/tests/dynamic_weights_tests.cpp (lines 563 - 564)
<https://reviews.apache.org/r/41790/#comment185596>
Wrap at `<<` instead
- Adam B
On March 9, 2016, 1:47 a.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> -----------------------------------------------------------
>
> (Updated March 9, 2016, 1:47 a.m.)
>
>
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
>
>
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add tests for /weights endpoint.
>
>
> Diffs
> -----
>
> src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955
> src/tests/dynamic_weights_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41790/diff/
>
>
> Testing
> -------
>
> Make and Make check successfully!
>
> $ ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
> [==========] Running 11 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 11 tests from DynamicWeightsTest
> [ RUN ] DynamicWeightsTest.PutInvalidRequest
> [ OK ] DynamicWeightsTest.PutInvalidRequest (87 ms)
> [ RUN ] DynamicWeightsTest.ZeroWeight
> [ OK ] DynamicWeightsTest.ZeroWeight (44 ms)
> [ RUN ] DynamicWeightsTest.NegativeWeight
> [ OK ] DynamicWeightsTest.NegativeWeight (42 ms)
> [ RUN ] DynamicWeightsTest.NonNumericWeight
> [ OK ] DynamicWeightsTest.NonNumericWeight (37 ms)
> [ RUN ] DynamicWeightsTest.MissingRole
> [ OK ] DynamicWeightsTest.MissingRole (42 ms)
> [ RUN ] DynamicWeightsTest.UnknownRole
> [ OK ] DynamicWeightsTest.UnknownRole (38 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (38 ms)
> [ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
> [ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (35 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (45 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
> [ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (38 ms)
> [ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (35 ms)
> [----------] 11 tests from DynamicWeightsTest (482 ms total)
>
> [----------] Global test environment tear-down
> [==========] 11 tests from 1 test case ran. (490 ms total)
> [ PASSED ] 11 tests.
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/#review123380
-----------------------------------------------------------
src/tests/dynamic_weights_tests.cpp (line 171)
<https://reviews.apache.org/r/41790/#comment185631>
Fix the indent here
- Adam B
On March 9, 2016, 1:47 a.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> -----------------------------------------------------------
>
> (Updated March 9, 2016, 1:47 a.m.)
>
>
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
>
>
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add tests for /weights endpoint.
>
>
> Diffs
> -----
>
> src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955
> src/tests/dynamic_weights_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41790/diff/
>
>
> Testing
> -------
>
> Make and Make check successfully!
>
> $ ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
> [==========] Running 11 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 11 tests from DynamicWeightsTest
> [ RUN ] DynamicWeightsTest.PutInvalidRequest
> [ OK ] DynamicWeightsTest.PutInvalidRequest (87 ms)
> [ RUN ] DynamicWeightsTest.ZeroWeight
> [ OK ] DynamicWeightsTest.ZeroWeight (44 ms)
> [ RUN ] DynamicWeightsTest.NegativeWeight
> [ OK ] DynamicWeightsTest.NegativeWeight (42 ms)
> [ RUN ] DynamicWeightsTest.NonNumericWeight
> [ OK ] DynamicWeightsTest.NonNumericWeight (37 ms)
> [ RUN ] DynamicWeightsTest.MissingRole
> [ OK ] DynamicWeightsTest.MissingRole (42 ms)
> [ RUN ] DynamicWeightsTest.UnknownRole
> [ OK ] DynamicWeightsTest.UnknownRole (38 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (38 ms)
> [ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
> [ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (35 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (45 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
> [ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (38 ms)
> [ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (35 ms)
> [----------] 11 tests from DynamicWeightsTest (482 ms total)
>
> [----------] Global test environment tear-down
> [==========] 11 tests from 1 test case ran. (490 ms total)
> [ PASSED ] 11 tests.
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Yongqiao Wang <yq...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/
-----------------------------------------------------------
(Updated March 14, 2016, 10:04 a.m.)
Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
Changes
-------
Addressed comments of Adam.
Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200
Repository: mesos
Description
-------
Add tests for /weights endpoint.
Diffs (updated)
-----
src/Makefile.am f2a592dba3e963c99c48c4b9045b4a04d173cb22
src/tests/dynamic_weights_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/41790/diff/
Testing
-------
Make and Make check successfully!
$ ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
[==========] Running 11 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 11 tests from DynamicWeightsTest
[ RUN ] DynamicWeightsTest.PutInvalidRequest
[ OK ] DynamicWeightsTest.PutInvalidRequest (87 ms)
[ RUN ] DynamicWeightsTest.ZeroWeight
[ OK ] DynamicWeightsTest.ZeroWeight (44 ms)
[ RUN ] DynamicWeightsTest.NegativeWeight
[ OK ] DynamicWeightsTest.NegativeWeight (42 ms)
[ RUN ] DynamicWeightsTest.NonNumericWeight
[ OK ] DynamicWeightsTest.NonNumericWeight (37 ms)
[ RUN ] DynamicWeightsTest.MissingRole
[ OK ] DynamicWeightsTest.MissingRole (42 ms)
[ RUN ] DynamicWeightsTest.UnknownRole
[ OK ] DynamicWeightsTest.UnknownRole (38 ms)
[ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
[ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (38 ms)
[ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
[ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (35 ms)
[ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
[ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (45 ms)
[ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
[ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (38 ms)
[ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
[ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (35 ms)
[----------] 11 tests from DynamicWeightsTest (482 ms total)
[----------] Global test environment tear-down
[==========] 11 tests from 1 test case ran. (490 ms total)
[ PASSED ] 11 tests.
Thanks,
Yongqiao Wang
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Yongqiao Wang <yq...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/
-----------------------------------------------------------
(Updated March 9, 2016, 9:47 a.m.)
Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
Changes
-------
Addressed comments of Adam.
Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200
Repository: mesos
Description
-------
Add tests for /weights endpoint.
Diffs (updated)
-----
src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955
src/tests/dynamic_weights_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/41790/diff/
Testing
-------
Make and Make check successfully!
$ ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
[==========] Running 11 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 11 tests from DynamicWeightsTest
[ RUN ] DynamicWeightsTest.PutInvalidRequest
[ OK ] DynamicWeightsTest.PutInvalidRequest (87 ms)
[ RUN ] DynamicWeightsTest.ZeroWeight
[ OK ] DynamicWeightsTest.ZeroWeight (44 ms)
[ RUN ] DynamicWeightsTest.NegativeWeight
[ OK ] DynamicWeightsTest.NegativeWeight (42 ms)
[ RUN ] DynamicWeightsTest.NonNumericWeight
[ OK ] DynamicWeightsTest.NonNumericWeight (37 ms)
[ RUN ] DynamicWeightsTest.MissingRole
[ OK ] DynamicWeightsTest.MissingRole (42 ms)
[ RUN ] DynamicWeightsTest.UnknownRole
[ OK ] DynamicWeightsTest.UnknownRole (38 ms)
[ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
[ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (38 ms)
[ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
[ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (35 ms)
[ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
[ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (45 ms)
[ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
[ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (38 ms)
[ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
[ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (35 ms)
[----------] 11 tests from DynamicWeightsTest (482 ms total)
[----------] Global test environment tear-down
[==========] 11 tests from 1 test case ran. (490 ms total)
[ PASSED ] 11 tests.
Thanks,
Yongqiao Wang
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Yongqiao Wang <yq...@cn.ibm.com>.
> On March 9, 2016, 8:26 a.m., Adam B wrote:
> > src/tests/dynamic_weights_tests.cpp, line 89
> > <https://reviews.apache.org/r/41790/diff/14/?file=1273013#file1273013line89>
> >
> > We don't (yet) use `CHECK_GE/LE/GT/LT` anywhere, I think because we want tests themselves to try to be exact. This might be more appropriate as `ASSERT_GE(tokens.size(), 1u)`.
> > Is it really even all that bad if `weightsFlag` was an empty string with no tokens? You'd just return an empty `infos`.
OK, it just only needs to remove `CHECK_GE(tokens.size(), 1u);`, if `weightsFlag` was an empty string, then return an empty infos.
- Yongqiao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/#review121134
-----------------------------------------------------------
On March 9, 2016, 5:52 a.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> -----------------------------------------------------------
>
> (Updated March 9, 2016, 5:52 a.m.)
>
>
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
>
>
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add tests for /weights endpoint.
>
>
> Diffs
> -----
>
> src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261
> src/tests/dynamic_weights_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41790/diff/
>
>
> Testing
> -------
>
> Make and Make check successfully!
>
> $ ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
> [==========] Running 11 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 11 tests from DynamicWeightsTest
> [ RUN ] DynamicWeightsTest.PutInvalidRequest
> [ OK ] DynamicWeightsTest.PutInvalidRequest (87 ms)
> [ RUN ] DynamicWeightsTest.ZeroWeight
> [ OK ] DynamicWeightsTest.ZeroWeight (44 ms)
> [ RUN ] DynamicWeightsTest.NegativeWeight
> [ OK ] DynamicWeightsTest.NegativeWeight (42 ms)
> [ RUN ] DynamicWeightsTest.NonNumericWeight
> [ OK ] DynamicWeightsTest.NonNumericWeight (37 ms)
> [ RUN ] DynamicWeightsTest.MissingRole
> [ OK ] DynamicWeightsTest.MissingRole (42 ms)
> [ RUN ] DynamicWeightsTest.UnknownRole
> [ OK ] DynamicWeightsTest.UnknownRole (38 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (38 ms)
> [ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
> [ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (35 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (45 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
> [ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (38 ms)
> [ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (35 ms)
> [----------] 11 tests from DynamicWeightsTest (482 ms total)
>
> [----------] Global test environment tear-down
> [==========] 11 tests from 1 test case ran. (490 ms total)
> [ PASSED ] 11 tests.
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/#review121134
-----------------------------------------------------------
src/tests/dynamic_weights_tests.cpp (line 345)
<https://reviews.apache.org/r/41790/#comment182785>
s/Only/only/
src/tests/dynamic_weights_tests.cpp (line 544)
<https://reviews.apache.org/r/41790/#comment182786>
s/Setup ACLs so that/Set ACLs to be non-permissive by default so that/
src/tests/dynamic_weights_tests.cpp (lines 72 - 73)
<https://reviews.apache.org/r/41790/#comment182789>
"The dynamic weights tests in this file are split into logical groups:"
src/tests/dynamic_weights_tests.cpp (line 84)
<https://reviews.apache.org/r/41790/#comment182790>
s/with/from/
src/tests/dynamic_weights_tests.cpp (line 89)
<https://reviews.apache.org/r/41790/#comment182791>
We don't (yet) use `CHECK_GE/LE/GT/LT` anywhere, I think because we want tests themselves to try to be exact. This might be more appropriate as `ASSERT_GE(tokens.size(), 1u)`.
Is it really even all that bad if `weightsFlag` was an empty string with no tokens? You'd just return an empty `infos`.
- Adam B
On March 8, 2016, 9:52 p.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> -----------------------------------------------------------
>
> (Updated March 8, 2016, 9:52 p.m.)
>
>
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
>
>
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add tests for /weights endpoint.
>
>
> Diffs
> -----
>
> src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261
> src/tests/dynamic_weights_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41790/diff/
>
>
> Testing
> -------
>
> Make and Make check successfully!
>
> $ ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
> [==========] Running 11 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 11 tests from DynamicWeightsTest
> [ RUN ] DynamicWeightsTest.PutInvalidRequest
> [ OK ] DynamicWeightsTest.PutInvalidRequest (87 ms)
> [ RUN ] DynamicWeightsTest.ZeroWeight
> [ OK ] DynamicWeightsTest.ZeroWeight (44 ms)
> [ RUN ] DynamicWeightsTest.NegativeWeight
> [ OK ] DynamicWeightsTest.NegativeWeight (42 ms)
> [ RUN ] DynamicWeightsTest.NonNumericWeight
> [ OK ] DynamicWeightsTest.NonNumericWeight (37 ms)
> [ RUN ] DynamicWeightsTest.MissingRole
> [ OK ] DynamicWeightsTest.MissingRole (42 ms)
> [ RUN ] DynamicWeightsTest.UnknownRole
> [ OK ] DynamicWeightsTest.UnknownRole (38 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (38 ms)
> [ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
> [ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (35 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (45 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
> [ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (38 ms)
> [ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (35 ms)
> [----------] 11 tests from DynamicWeightsTest (482 ms total)
>
> [----------] Global test environment tear-down
> [==========] 11 tests from 1 test case ran. (490 ms total)
> [ PASSED ] 11 tests.
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Yongqiao Wang <yq...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/
-----------------------------------------------------------
(Updated March 9, 2016, 5:52 a.m.)
Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
Changes
-------
Check the updated results wiht /weights endpoint.
Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200
Repository: mesos
Description
-------
Add tests for /weights endpoint.
Diffs (updated)
-----
src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261
src/tests/dynamic_weights_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/41790/diff/
Testing (updated)
-------
Make and Make check successfully!
$ ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
[==========] Running 11 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 11 tests from DynamicWeightsTest
[ RUN ] DynamicWeightsTest.PutInvalidRequest
[ OK ] DynamicWeightsTest.PutInvalidRequest (87 ms)
[ RUN ] DynamicWeightsTest.ZeroWeight
[ OK ] DynamicWeightsTest.ZeroWeight (44 ms)
[ RUN ] DynamicWeightsTest.NegativeWeight
[ OK ] DynamicWeightsTest.NegativeWeight (42 ms)
[ RUN ] DynamicWeightsTest.NonNumericWeight
[ OK ] DynamicWeightsTest.NonNumericWeight (37 ms)
[ RUN ] DynamicWeightsTest.MissingRole
[ OK ] DynamicWeightsTest.MissingRole (42 ms)
[ RUN ] DynamicWeightsTest.UnknownRole
[ OK ] DynamicWeightsTest.UnknownRole (38 ms)
[ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
[ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (38 ms)
[ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
[ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (35 ms)
[ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
[ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (45 ms)
[ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
[ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (38 ms)
[ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
[ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (35 ms)
[----------] 11 tests from DynamicWeightsTest (482 ms total)
[----------] Global test environment tear-down
[==========] 11 tests from 1 test case ran. (490 ms total)
[ PASSED ] 11 tests.
Thanks,
Yongqiao Wang
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Yongqiao Wang <yq...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/
-----------------------------------------------------------
(Updated Feb. 27, 2016, 1:55 p.m.)
Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
Changes
-------
Addressed comments of Adam.
Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200
Repository: mesos
Description
-------
Add tests for /weights endpoint.
Diffs (updated)
-----
src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5
src/tests/dynamic_weights_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/41790/diff/
Testing (updated)
-------
Make and Make check successfully!
./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
[==========] Running 11 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 11 tests from DynamicWeightsTest
[ RUN ] DynamicWeightsTest.PutInvalidRequest
[ OK ] DynamicWeightsTest.PutInvalidRequest (85 ms)
[ RUN ] DynamicWeightsTest.ZeroWeight
[ OK ] DynamicWeightsTest.ZeroWeight (46 ms)
[ RUN ] DynamicWeightsTest.NegativeWeight
[ OK ] DynamicWeightsTest.NegativeWeight (49 ms)
[ RUN ] DynamicWeightsTest.NonNumericWeight
[ OK ] DynamicWeightsTest.NonNumericWeight (49 ms)
[ RUN ] DynamicWeightsTest.MissingRole
[ OK ] DynamicWeightsTest.MissingRole (50 ms)
[ RUN ] DynamicWeightsTest.UnknownRole
[ OK ] DynamicWeightsTest.UnknownRole (49 ms)
[ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
[ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (45 ms)
[ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
[ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (45 ms)
[ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
[ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (37 ms)
[ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
[ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (36 ms)
[ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
[ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (35 ms)
[----------] 11 tests from DynamicWeightsTest (527 ms total)
[----------] Global test environment tear-down
[==========] 11 tests from 1 test case ran. (536 ms total)
[ PASSED ] 11 tests.
Thanks,
Yongqiao Wang
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Yongqiao Wang <yq...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/
-----------------------------------------------------------
(Updated Jan. 25, 2016, 3:47 p.m.)
Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
Changes
-------
Update the tests and trigger the ReviewBot again.
Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200
Repository: mesos
Description
-------
Add tests for /weights endpoint.
Diffs (updated)
-----
src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6
src/tests/dynamic_weights_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/41790/diff/
Testing
-------
Make and Make check successfully!
./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
[==========] Running 11 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 11 tests from DynamicWeightsTest
[ RUN ] DynamicWeightsTest.PutInvalidRequest
[ OK ] DynamicWeightsTest.PutInvalidRequest (102 ms)
[ RUN ] DynamicWeightsTest.ZeroWeight
[ OK ] DynamicWeightsTest.ZeroWeight (38 ms)
[ RUN ] DynamicWeightsTest.NegativeWeight
[ OK ] DynamicWeightsTest.NegativeWeight (38 ms)
[ RUN ] DynamicWeightsTest.MissingRole
[ OK ] DynamicWeightsTest.MissingRole (43 ms)
[ RUN ] DynamicWeightsTest.UnknownRole
[ OK ] DynamicWeightsTest.UnknownRole (36 ms)
[ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
[ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (44 ms)
[ RUN ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
[ OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (52 ms)
[ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
[ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (40 ms)
[ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
[ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (32 ms)
[ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
[ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (37 ms)
[ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
[ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (30 ms)
[----------] 11 tests from DynamicWeightsTest (492 ms total)
[----------] Global test environment tear-down
[==========] 11 tests from 1 test case ran. (503 ms total)
[ PASSED ] 11 tests.
Thanks,
Yongqiao Wang
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Yongqiao Wang <yq...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/
-----------------------------------------------------------
(Updated Jan. 25, 2016, 1:51 a.m.)
Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
Changes
-------
Update the Unauthorized error HTTP response.
Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200
Repository: mesos
Description
-------
Add tests for /weights endpoint.
Diffs (updated)
-----
src/Makefile.am 19bf3a7c2e43ca04ed6e6d506e052de5537f7c2f
src/tests/dynamic_weights_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/41790/diff/
Testing
-------
Make and Make check successfully!
./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
[==========] Running 11 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 11 tests from DynamicWeightsTest
[ RUN ] DynamicWeightsTest.PutInvalidRequest
[ OK ] DynamicWeightsTest.PutInvalidRequest (102 ms)
[ RUN ] DynamicWeightsTest.ZeroWeight
[ OK ] DynamicWeightsTest.ZeroWeight (38 ms)
[ RUN ] DynamicWeightsTest.NegativeWeight
[ OK ] DynamicWeightsTest.NegativeWeight (38 ms)
[ RUN ] DynamicWeightsTest.MissingRole
[ OK ] DynamicWeightsTest.MissingRole (43 ms)
[ RUN ] DynamicWeightsTest.UnknownRole
[ OK ] DynamicWeightsTest.UnknownRole (36 ms)
[ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
[ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (44 ms)
[ RUN ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
[ OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (52 ms)
[ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
[ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (40 ms)
[ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
[ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (32 ms)
[ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
[ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (37 ms)
[ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
[ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (30 ms)
[----------] 11 tests from DynamicWeightsTest (492 ms total)
[----------] Global test environment tear-down
[==========] 11 tests from 1 test case ran. (503 ms total)
[ PASSED ] 11 tests.
Thanks,
Yongqiao Wang
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/#review115736
-----------------------------------------------------------
Bad patch!
Reviews applied: [41597]
Failed command: ./support/apply-review.sh -n -r 41597
Error:
2016-01-21 23:47:46 URL:https://reviews.apache.org/r/41597/diff/raw/ [7672/7672] -> "41597.patch" [1]
error: patch failed: src/master/allocator/mesos/hierarchical.cpp:1043
error: src/master/allocator/mesos/hierarchical.cpp: patch does not apply
- Mesos ReviewBot
On Jan. 21, 2016, 9:57 a.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2016, 9:57 a.m.)
>
>
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
>
>
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add tests for /weights endpoint.
>
>
> Diffs
> -----
>
> src/Makefile.am 4fabe600d4ba38c95a777d622b0b675dd5811a53
> src/tests/dynamic_weights_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41790/diff/
>
>
> Testing
> -------
>
> Make and Make check successfully!
>
> ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
> [==========] Running 11 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 11 tests from DynamicWeightsTest
> [ RUN ] DynamicWeightsTest.PutInvalidRequest
> [ OK ] DynamicWeightsTest.PutInvalidRequest (102 ms)
> [ RUN ] DynamicWeightsTest.ZeroWeight
> [ OK ] DynamicWeightsTest.ZeroWeight (38 ms)
> [ RUN ] DynamicWeightsTest.NegativeWeight
> [ OK ] DynamicWeightsTest.NegativeWeight (38 ms)
> [ RUN ] DynamicWeightsTest.MissingRole
> [ OK ] DynamicWeightsTest.MissingRole (43 ms)
> [ RUN ] DynamicWeightsTest.UnknownRole
> [ OK ] DynamicWeightsTest.UnknownRole (36 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (44 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (52 ms)
> [ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
> [ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (40 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (32 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
> [ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (37 ms)
> [ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (30 ms)
> [----------] 11 tests from DynamicWeightsTest (492 ms total)
>
> [----------] Global test environment tear-down
> [==========] 11 tests from 1 test case ran. (503 ms total)
> [ PASSED ] 11 tests.
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Yongqiao Wang <yq...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/
-----------------------------------------------------------
(Updated Jan. 21, 2016, 9:57 a.m.)
Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
Changes
-------
Update the dependency to address the build error.
Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200
Repository: mesos
Description
-------
Add tests for /weights endpoint.
Diffs
-----
src/Makefile.am 4fabe600d4ba38c95a777d622b0b675dd5811a53
src/tests/dynamic_weights_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/41790/diff/
Testing
-------
Make and Make check successfully!
./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
[==========] Running 11 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 11 tests from DynamicWeightsTest
[ RUN ] DynamicWeightsTest.PutInvalidRequest
[ OK ] DynamicWeightsTest.PutInvalidRequest (102 ms)
[ RUN ] DynamicWeightsTest.ZeroWeight
[ OK ] DynamicWeightsTest.ZeroWeight (38 ms)
[ RUN ] DynamicWeightsTest.NegativeWeight
[ OK ] DynamicWeightsTest.NegativeWeight (38 ms)
[ RUN ] DynamicWeightsTest.MissingRole
[ OK ] DynamicWeightsTest.MissingRole (43 ms)
[ RUN ] DynamicWeightsTest.UnknownRole
[ OK ] DynamicWeightsTest.UnknownRole (36 ms)
[ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
[ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (44 ms)
[ RUN ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
[ OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (52 ms)
[ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
[ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (40 ms)
[ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
[ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (32 ms)
[ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
[ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (37 ms)
[ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
[ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (30 ms)
[----------] 11 tests from DynamicWeightsTest (492 ms total)
[----------] Global test environment tear-down
[==========] 11 tests from 1 test case ran. (503 ms total)
[ PASSED ] 11 tests.
Thanks,
Yongqiao Wang
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Yongqiao Wang <yq...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/
-----------------------------------------------------------
(Updated Jan. 21, 2016, 3:08 a.m.)
Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
Changes
-------
Add the denpendy to fix the build error.
Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200
Repository: mesos
Description
-------
Add tests for /weights endpoint.
Diffs
-----
src/Makefile.am 4fabe600d4ba38c95a777d622b0b675dd5811a53
src/tests/dynamic_weights_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/41790/diff/
Testing
-------
Make and Make check successfully!
./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
[==========] Running 11 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 11 tests from DynamicWeightsTest
[ RUN ] DynamicWeightsTest.PutInvalidRequest
[ OK ] DynamicWeightsTest.PutInvalidRequest (102 ms)
[ RUN ] DynamicWeightsTest.ZeroWeight
[ OK ] DynamicWeightsTest.ZeroWeight (38 ms)
[ RUN ] DynamicWeightsTest.NegativeWeight
[ OK ] DynamicWeightsTest.NegativeWeight (38 ms)
[ RUN ] DynamicWeightsTest.MissingRole
[ OK ] DynamicWeightsTest.MissingRole (43 ms)
[ RUN ] DynamicWeightsTest.UnknownRole
[ OK ] DynamicWeightsTest.UnknownRole (36 ms)
[ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
[ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (44 ms)
[ RUN ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
[ OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (52 ms)
[ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
[ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (40 ms)
[ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
[ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (32 ms)
[ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
[ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (37 ms)
[ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
[ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (30 ms)
[----------] 11 tests from DynamicWeightsTest (492 ms total)
[----------] Global test environment tear-down
[==========] 11 tests from 1 test case ran. (503 ms total)
[ PASSED ] 11 tests.
Thanks,
Yongqiao Wang
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Yongqiao Wang <yq...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/
-----------------------------------------------------------
(Updated Jan. 20, 2016, 11:13 a.m.)
Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
Changes
-------
Addressed the comments of Adam.
Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200
Repository: mesos
Description
-------
Add tests for /weights endpoint.
Diffs (updated)
-----
src/Makefile.am 4fabe600d4ba38c95a777d622b0b675dd5811a53
src/tests/dynamic_weights_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/41790/diff/
Testing
-------
Make and Make check successfully!
./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
[==========] Running 11 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 11 tests from DynamicWeightsTest
[ RUN ] DynamicWeightsTest.PutInvalidRequest
[ OK ] DynamicWeightsTest.PutInvalidRequest (102 ms)
[ RUN ] DynamicWeightsTest.ZeroWeight
[ OK ] DynamicWeightsTest.ZeroWeight (38 ms)
[ RUN ] DynamicWeightsTest.NegativeWeight
[ OK ] DynamicWeightsTest.NegativeWeight (38 ms)
[ RUN ] DynamicWeightsTest.MissingRole
[ OK ] DynamicWeightsTest.MissingRole (43 ms)
[ RUN ] DynamicWeightsTest.UnknownRole
[ OK ] DynamicWeightsTest.UnknownRole (36 ms)
[ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
[ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (44 ms)
[ RUN ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
[ OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (52 ms)
[ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
[ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (40 ms)
[ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
[ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (32 ms)
[ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
[ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (37 ms)
[ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
[ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (30 ms)
[----------] 11 tests from DynamicWeightsTest (492 ms total)
[----------] Global test environment tear-down
[==========] 11 tests from 1 test case ran. (503 ms total)
[ PASSED ] 11 tests.
Thanks,
Yongqiao Wang
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Yongqiao Wang <yq...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/
-----------------------------------------------------------
(Updated Jan. 20, 2016, 9:14 a.m.)
Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
Changes
-------
Update the tests to call process::http::request instead of process::http::httpRequest.
Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200
Repository: mesos
Description
-------
Add tests for /weights endpoint.
Diffs (updated)
-----
src/Makefile.am 4fabe600d4ba38c95a777d622b0b675dd5811a53
src/tests/dynamic_weights_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/41790/diff/
Testing
-------
Make and Make check successfully!
./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
[==========] Running 11 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 11 tests from DynamicWeightsTest
[ RUN ] DynamicWeightsTest.PutInvalidRequest
[ OK ] DynamicWeightsTest.PutInvalidRequest (102 ms)
[ RUN ] DynamicWeightsTest.ZeroWeight
[ OK ] DynamicWeightsTest.ZeroWeight (38 ms)
[ RUN ] DynamicWeightsTest.NegativeWeight
[ OK ] DynamicWeightsTest.NegativeWeight (38 ms)
[ RUN ] DynamicWeightsTest.MissingRole
[ OK ] DynamicWeightsTest.MissingRole (43 ms)
[ RUN ] DynamicWeightsTest.UnknownRole
[ OK ] DynamicWeightsTest.UnknownRole (36 ms)
[ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
[ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (44 ms)
[ RUN ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
[ OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (52 ms)
[ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
[ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (40 ms)
[ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
[ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (32 ms)
[ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
[ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (37 ms)
[ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
[ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (30 ms)
[----------] 11 tests from DynamicWeightsTest (492 ms total)
[----------] Global test environment tear-down
[==========] 11 tests from 1 test case ran. (503 ms total)
[ PASSED ] 11 tests.
Thanks,
Yongqiao Wang
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Yongqiao Wang <yq...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/
-----------------------------------------------------------
(Updated Jan. 12, 2016, 7:30 a.m.)
Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
Changes
-------
Rebase.
Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200
Repository: mesos
Description
-------
Add tests for /weights endpoint.
Diffs (updated)
-----
src/Makefile.am 8cbfb1ba5fa49f2d3cc26ea325838a1c68a79660
src/tests/dynamic_weights_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/41790/diff/
Testing
-------
Make and Make check successfully!
./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
[==========] Running 11 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 11 tests from DynamicWeightsTest
[ RUN ] DynamicWeightsTest.PutInvalidRequest
[ OK ] DynamicWeightsTest.PutInvalidRequest (102 ms)
[ RUN ] DynamicWeightsTest.ZeroWeight
[ OK ] DynamicWeightsTest.ZeroWeight (38 ms)
[ RUN ] DynamicWeightsTest.NegativeWeight
[ OK ] DynamicWeightsTest.NegativeWeight (38 ms)
[ RUN ] DynamicWeightsTest.MissingRole
[ OK ] DynamicWeightsTest.MissingRole (43 ms)
[ RUN ] DynamicWeightsTest.UnknownRole
[ OK ] DynamicWeightsTest.UnknownRole (36 ms)
[ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
[ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (44 ms)
[ RUN ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
[ OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (52 ms)
[ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
[ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (40 ms)
[ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
[ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (32 ms)
[ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
[ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (37 ms)
[ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
[ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (30 ms)
[----------] 11 tests from DynamicWeightsTest (492 ms total)
[----------] Global test environment tear-down
[==========] 11 tests from 1 test case ran. (503 ms total)
[ PASSED ] 11 tests.
Thanks,
Yongqiao Wang
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Yongqiao Wang <yq...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/
-----------------------------------------------------------
(Updated Jan. 11, 2016, 2:47 p.m.)
Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
Changes
-------
Addressed the comments of Adam.
Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200
Repository: mesos
Description
-------
Add tests for /weights endpoint.
Diffs (updated)
-----
src/Makefile.am 8cbfb1ba5fa49f2d3cc26ea325838a1c68a79660
src/tests/dynamic_weights_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/41790/diff/
Testing (updated)
-------
Make and Make check successfully!
./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
[==========] Running 11 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 11 tests from DynamicWeightsTest
[ RUN ] DynamicWeightsTest.PutInvalidRequest
[ OK ] DynamicWeightsTest.PutInvalidRequest (102 ms)
[ RUN ] DynamicWeightsTest.ZeroWeight
[ OK ] DynamicWeightsTest.ZeroWeight (38 ms)
[ RUN ] DynamicWeightsTest.NegativeWeight
[ OK ] DynamicWeightsTest.NegativeWeight (38 ms)
[ RUN ] DynamicWeightsTest.MissingRole
[ OK ] DynamicWeightsTest.MissingRole (43 ms)
[ RUN ] DynamicWeightsTest.UnknownRole
[ OK ] DynamicWeightsTest.UnknownRole (36 ms)
[ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
[ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (44 ms)
[ RUN ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
[ OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (52 ms)
[ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
[ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (40 ms)
[ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
[ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (32 ms)
[ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
[ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (37 ms)
[ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
[ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (30 ms)
[----------] 11 tests from DynamicWeightsTest (492 ms total)
[----------] Global test environment tear-down
[==========] 11 tests from 1 test case ran. (503 ms total)
[ PASSED ] 11 tests.
Thanks,
Yongqiao Wang
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Yongqiao Wang <yq...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/
-----------------------------------------------------------
(Updated Jan. 9, 2016, 11:38 a.m.)
Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
Changes
-------
Update the tests to apply the http authentication.
Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200
Repository: mesos
Description
-------
Add tests for /weights endpoint.
Diffs (updated)
-----
src/Makefile.am bbd0c119321fa9d11fea61b140428dd92d1258c8
src/tests/dynamic_weights_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/41790/diff/
Testing
-------
Make and Make check successfully!
./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
[==========] Running 10 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 10 tests from DynamicWeightsTest
[ RUN ] DynamicWeightsTest.PutInvalidRequest
[ OK ] DynamicWeightsTest.PutInvalidRequest (102 ms)
[ RUN ] DynamicWeightsTest.NegativeWeight
[ OK ] DynamicWeightsTest.NegativeWeight (42 ms)
[ RUN ] DynamicWeightsTest.MissingRole
[ OK ] DynamicWeightsTest.MissingRole (43 ms)
[ RUN ] DynamicWeightsTest.NonExistentRole
[ OK ] DynamicWeightsTest.NonExistentRole (30 ms)
[ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
[ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (38 ms)
[ RUN ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
[ OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (42 ms)
[ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
[ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (35 ms)
[ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
[ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (37 ms)
[ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
[ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (44 ms)
[ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
[ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (30 ms)
[----------] 10 tests from DynamicWeightsTest (443 ms total)
[----------] Global test environment tear-down
[==========] 10 tests from 1 test case ran. (452 ms total)
[ PASSED ] 10 tests.
Thanks,
Yongqiao Wang
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Yongqiao Wang <yq...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/
-----------------------------------------------------------
(Updated Jan. 6, 2016, 2:07 a.m.)
Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
Changes
-------
Using the common functions.
Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200
Repository: mesos
Description
-------
Add tests for /weights endpoint.
Diffs (updated)
-----
src/Makefile.am e08e86724abaa3023f0483aa222354c95d4d3817
src/tests/dynamic_weights_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/41790/diff/
Testing
-------
Make and Make check successfully!
./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
[==========] Running 10 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 10 tests from DynamicWeightsTest
[ RUN ] DynamicWeightsTest.PutInvalidRequest
[ OK ] DynamicWeightsTest.PutInvalidRequest (102 ms)
[ RUN ] DynamicWeightsTest.NegativeWeight
[ OK ] DynamicWeightsTest.NegativeWeight (42 ms)
[ RUN ] DynamicWeightsTest.MissingRole
[ OK ] DynamicWeightsTest.MissingRole (43 ms)
[ RUN ] DynamicWeightsTest.NonExistentRole
[ OK ] DynamicWeightsTest.NonExistentRole (30 ms)
[ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
[ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (38 ms)
[ RUN ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
[ OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (42 ms)
[ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
[ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (35 ms)
[ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
[ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (37 ms)
[ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
[ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (44 ms)
[ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
[ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (30 ms)
[----------] 10 tests from DynamicWeightsTest (443 ms total)
[----------] Global test environment tear-down
[==========] 10 tests from 1 test case ran. (452 ms total)
[ PASSED ] 10 tests.
Thanks,
Yongqiao Wang
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/#review112865
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41597, 41681, 41789, 41790]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 5, 2016, 1:42 p.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 1:42 p.m.)
>
>
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
>
>
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add tests for /weights endpoint.
>
>
> Diffs
> -----
>
> src/Makefile.am e08e86724abaa3023f0483aa222354c95d4d3817
> src/tests/dynamic_weights_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41790/diff/
>
>
> Testing
> -------
>
> Make and Make check successfully!
>
> ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
> [==========] Running 10 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 10 tests from DynamicWeightsTest
> [ RUN ] DynamicWeightsTest.PutInvalidRequest
> [ OK ] DynamicWeightsTest.PutInvalidRequest (102 ms)
> [ RUN ] DynamicWeightsTest.NegativeWeight
> [ OK ] DynamicWeightsTest.NegativeWeight (42 ms)
> [ RUN ] DynamicWeightsTest.MissingRole
> [ OK ] DynamicWeightsTest.MissingRole (43 ms)
> [ RUN ] DynamicWeightsTest.NonExistentRole
> [ OK ] DynamicWeightsTest.NonExistentRole (30 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (38 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (42 ms)
> [ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
> [ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (35 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (37 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
> [ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (44 ms)
> [ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (30 ms)
> [----------] 10 tests from DynamicWeightsTest (443 ms total)
>
> [----------] Global test environment tear-down
> [==========] 10 tests from 1 test case ran. (452 ms total)
> [ PASSED ] 10 tests.
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Yongqiao Wang <yq...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/
-----------------------------------------------------------
(Updated Jan. 5, 2016, 1:42 p.m.)
Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
Changes
-------
Update the test due to the updateWeight() interface changed.
Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200
Repository: mesos
Description
-------
Add tests for /weights endpoint.
Diffs (updated)
-----
src/Makefile.am e08e86724abaa3023f0483aa222354c95d4d3817
src/tests/dynamic_weights_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/41790/diff/
Testing (updated)
-------
Make and Make check successfully!
./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
[==========] Running 10 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 10 tests from DynamicWeightsTest
[ RUN ] DynamicWeightsTest.PutInvalidRequest
[ OK ] DynamicWeightsTest.PutInvalidRequest (102 ms)
[ RUN ] DynamicWeightsTest.NegativeWeight
[ OK ] DynamicWeightsTest.NegativeWeight (42 ms)
[ RUN ] DynamicWeightsTest.MissingRole
[ OK ] DynamicWeightsTest.MissingRole (43 ms)
[ RUN ] DynamicWeightsTest.NonExistentRole
[ OK ] DynamicWeightsTest.NonExistentRole (30 ms)
[ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
[ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (38 ms)
[ RUN ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
[ OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (42 ms)
[ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
[ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (35 ms)
[ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
[ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (37 ms)
[ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
[ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (44 ms)
[ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
[ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (30 ms)
[----------] 10 tests from DynamicWeightsTest (443 ms total)
[----------] Global test environment tear-down
[==========] 10 tests from 1 test case ran. (452 ms total)
[ PASSED ] 10 tests.
Thanks,
Yongqiao Wang
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/#review112641
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41597, 41681, 41789, 41790]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 4, 2016, 1:53 p.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 1:53 p.m.)
>
>
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
>
>
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add tests for /weights endpoint.
>
>
> Diffs
> -----
>
> src/Makefile.am b58d6b560858d318058be766456dd5c5ef98c23e
> src/tests/dynamic_weights_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41790/diff/
>
>
> Testing
> -------
>
> Make and Make check successfully!
>
> ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
> [==========] Running 9 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 9 tests from DynamicWeightsTest
> [ RUN ] DynamicWeightsTest.PutInvalidRequest
> [ OK ] DynamicWeightsTest.PutInvalidRequest (106 ms)
> [ RUN ] DynamicWeightsTest.NegativeWeight
> [ OK ] DynamicWeightsTest.NegativeWeight (43 ms)
> [ RUN ] DynamicWeightsTest.NonExistentRole
> [ OK ] DynamicWeightsTest.NonExistentRole (40 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (46 ms)
> [ RUN ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
> [ OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (35 ms)
> [ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
> [ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (33 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (41 ms)
> [ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
> [ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (34 ms)
> [ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
> [ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (36 ms)
> [----------] 9 tests from DynamicWeightsTest (415 ms total)
>
> [----------] Global test environment tear-down
> [==========] 9 tests from 1 test case ran. (424 ms total)
> [ PASSED ] 9 tests.
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Yongqiao Wang <yq...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/
-----------------------------------------------------------
(Updated Jan. 4, 2016, 1:53 p.m.)
Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
Changes
-------
Rebase.
Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200
Repository: mesos
Description
-------
Add tests for /weights endpoint.
Diffs (updated)
-----
src/Makefile.am b58d6b560858d318058be766456dd5c5ef98c23e
src/tests/dynamic_weights_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/41790/diff/
Testing
-------
Make and Make check successfully!
./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
[==========] Running 9 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 9 tests from DynamicWeightsTest
[ RUN ] DynamicWeightsTest.PutInvalidRequest
[ OK ] DynamicWeightsTest.PutInvalidRequest (106 ms)
[ RUN ] DynamicWeightsTest.NegativeWeight
[ OK ] DynamicWeightsTest.NegativeWeight (43 ms)
[ RUN ] DynamicWeightsTest.NonExistentRole
[ OK ] DynamicWeightsTest.NonExistentRole (40 ms)
[ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
[ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (46 ms)
[ RUN ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
[ OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (35 ms)
[ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
[ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (33 ms)
[ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
[ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (41 ms)
[ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
[ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (34 ms)
[ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
[ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (36 ms)
[----------] 9 tests from DynamicWeightsTest (415 ms total)
[----------] Global test environment tear-down
[==========] 9 tests from 1 test case ran. (424 ms total)
[ PASSED ] 9 tests.
Thanks,
Yongqiao Wang
Re: Review Request 41790: Add tests for /weights endpoint.
Posted by Yongqiao Wang <yq...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/
-----------------------------------------------------------
(Updated Jan. 4, 2016, 11:23 a.m.)
Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200
Repository: mesos
Description
-------
Add tests for /weights endpoint.
Diffs
-----
src/Makefile.am b58d6b560858d318058be766456dd5c5ef98c23e
src/tests/dynamic_weights_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/41790/diff/
Testing (updated)
-------
Make and Make check successfully!
./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
[==========] Running 9 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 9 tests from DynamicWeightsTest
[ RUN ] DynamicWeightsTest.PutInvalidRequest
[ OK ] DynamicWeightsTest.PutInvalidRequest (106 ms)
[ RUN ] DynamicWeightsTest.NegativeWeight
[ OK ] DynamicWeightsTest.NegativeWeight (43 ms)
[ RUN ] DynamicWeightsTest.NonExistentRole
[ OK ] DynamicWeightsTest.NonExistentRole (40 ms)
[ RUN ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
[ OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (46 ms)
[ RUN ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
[ OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (35 ms)
[ RUN ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
[ OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (33 ms)
[ RUN ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
[ OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (41 ms)
[ RUN ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
[ OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (34 ms)
[ RUN ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
[ OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (36 ms)
[----------] 9 tests from DynamicWeightsTest (415 ms total)
[----------] Global test environment tear-down
[==========] 9 tests from 1 test case ran. (424 ms total)
[ PASSED ] 9 tests.
Thanks,
Yongqiao Wang