You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "flycash (GitHub)" <gi...@apache.org> on 2020/01/09 12:52:52 UTC

[GitHub] [dubbo-go] flycash opened pull request #311: ftr: Grpc Protocol Support

<!--  Thanks for sending a pull request! 
-->

**What this PR does**:
Merge the feature/grpc into develop
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #

**Special notes for your reviewer**:
1. Check the code coverage
2. Test it
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
Now we support grpc!
```

[ Full content available at: https://github.com/apache/dubbo-go/pull/311 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #311: ftr: Grpc Protocol Support

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/311?src=pr&el=h1) Report
> Merging [#311](https://codecov.io/gh/apache/dubbo-go/pull/311?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/979acb2a53f1e2c0d0131907bde78479570160fe?src=pr&el=desc) will **decrease** coverage by `0.44%`.
> The diff coverage is `83.73%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/311/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/311?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #311      +/-   ##
===========================================
- Coverage    66.58%   66.13%   -0.45%     
===========================================
  Files          113      118       +5     
  Lines         7239     7380     +141     
===========================================
+ Hits          4820     4881      +61     
- Misses        1947     2018      +71     
- Partials       472      481       +9
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/311?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `64.45% <ø> (ø)` | :arrow_up: |
| [protocol/protocolwrapper/mock\_protocol\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcHJvdG9jb2x3cmFwcGVyL21vY2tfcHJvdG9jb2xfZmlsdGVyLmdv) | `0% <0%> (ø)` | :arrow_up: |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `55.55% <100%> (+0.15%)` | :arrow_up: |
| [protocol/jsonrpc/jsonrpc\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-cHJvdG9jb2wvanNvbnJwYy9qc29ucnBjX3Byb3RvY29sLmdv) | `95.55% <100%> (ø)` | :arrow_up: |
| [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `83.78% <100%> (+0.11%)` | :arrow_up: |
| [...rotocol/protocolwrapper/protocol\_filter\_wrapper.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcHJvdG9jb2x3cmFwcGVyL3Byb3RvY29sX2ZpbHRlcl93cmFwcGVyLmdv) | `51.42% <100%> (ø)` | :arrow_up: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `48.46% <100%> (+0.53%)` | :arrow_up: |
| [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `97.87% <100%> (+0.11%)` | :arrow_up: |
| [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `81.73% <100%> (ø)` | :arrow_up: |
| [protocol/dubbo/dubbo\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vZHViYm9fcHJvdG9jb2wuZ28=) | `95.55% <100%> (ø)` | :arrow_up: |
| ... and [17 more](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/311?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/311?src=pr&el=footer). Last update [979acb2...78818e8](https://codecov.io/gh/apache/dubbo-go/pull/311?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/311 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #311: ftr: Grpc Protocol Support

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/311?src=pr&el=h1) Report
> Merging [#311](https://codecov.io/gh/apache/dubbo-go/pull/311?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/01f84dc599514b5f1ce89f2a339850660a45832a?src=pr&el=desc) will **decrease** coverage by `0.44%`.
> The diff coverage is `80.51%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/311/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/311?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #311      +/-   ##
===========================================
- Coverage    66.58%   66.13%   -0.45%     
===========================================
  Files          112      118       +6     
  Lines         7182     7380     +198     
===========================================
+ Hits          4782     4881      +99     
- Misses        1934     2018      +84     
- Partials       466      481      +15
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/311?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [filter/filter/execute\_limit\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlci9leGVjdXRlX2xpbWl0X2ZpbHRlci5nbw==) | `73.8% <ø> (ø)` | |
| [filter/filter/access\_log\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlci9hY2Nlc3NfbG9nX2ZpbHRlci5nbw==) | `71.02% <ø> (ø)` | |
| [filter/filter/echo\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlci9lY2hvX2ZpbHRlci5nbw==) | `85.71% <ø> (ø)` | |
| [filter/common/rejected\_execution\_handler\_mock.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-ZmlsdGVyL2NvbW1vbi9yZWplY3RlZF9leGVjdXRpb25faGFuZGxlcl9tb2NrLmdv) | `0% <ø> (ø)` | |
| [filter/filter/tps\_limit\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlci90cHNfbGltaXRfZmlsdGVyLmdv) | `88.23% <ø> (ø)` | |
| [filter/filter/token\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlci90b2tlbl9maWx0ZXIuZ28=) | `87.5% <ø> (ø)` | |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `64.45% <ø> (ø)` | :arrow_up: |
| [filter/filter/active\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlci9hY3RpdmVfZmlsdGVyLmdv) | `18.18% <ø> (ø)` | |
| [filter/filter/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlci9oeXN0cml4X2ZpbHRlci5nbw==) | `68.64% <ø> (ø)` | |
| [filter/filter/generic\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlci9nZW5lcmljX2ZpbHRlci5nbw==) | `67.69% <ø> (ø)` | |
| ... and [37 more](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/311?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/311?src=pr&el=footer). Last update [01f84dc...5029e32](https://codecov.io/gh/apache/dubbo-go/pull/311?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/311 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #311: ftr: Grpc Protocol Support

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/311?src=pr&el=h1) Report
> Merging [#311](https://codecov.io/gh/apache/dubbo-go/pull/311?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/01f84dc599514b5f1ce89f2a339850660a45832a?src=pr&el=desc) will **decrease** coverage by `0.44%`.
> The diff coverage is `80.51%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/311/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/311?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #311      +/-   ##
===========================================
- Coverage    66.58%   66.13%   -0.45%     
===========================================
  Files          112      118       +6     
  Lines         7182     7380     +198     
===========================================
+ Hits          4782     4881      +99     
- Misses        1934     2018      +84     
- Partials       466      481      +15
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/311?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [filter/filter/execute\_limit\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlci9leGVjdXRlX2xpbWl0X2ZpbHRlci5nbw==) | `73.8% <ø> (ø)` | |
| [filter/filter/access\_log\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlci9hY2Nlc3NfbG9nX2ZpbHRlci5nbw==) | `71.02% <ø> (ø)` | |
| [filter/filter/echo\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlci9lY2hvX2ZpbHRlci5nbw==) | `85.71% <ø> (ø)` | |
| [filter/common/rejected\_execution\_handler\_mock.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-ZmlsdGVyL2NvbW1vbi9yZWplY3RlZF9leGVjdXRpb25faGFuZGxlcl9tb2NrLmdv) | `0% <ø> (ø)` | |
| [filter/filter/tps\_limit\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlci90cHNfbGltaXRfZmlsdGVyLmdv) | `88.23% <ø> (ø)` | |
| [filter/filter/token\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlci90b2tlbl9maWx0ZXIuZ28=) | `87.5% <ø> (ø)` | |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `64.45% <ø> (ø)` | :arrow_up: |
| [filter/filter/active\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlci9hY3RpdmVfZmlsdGVyLmdv) | `18.18% <ø> (ø)` | |
| [filter/filter/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlci9oeXN0cml4X2ZpbHRlci5nbw==) | `68.64% <ø> (ø)` | |
| [filter/filter/generic\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlci9nZW5lcmljX2ZpbHRlci5nbw==) | `67.69% <ø> (ø)` | |
| ... and [37 more](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/311?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/311?src=pr&el=footer). Last update [01f84dc...5029e32](https://codecov.io/gh/apache/dubbo-go/pull/311?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/311 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #311: ftr: Grpc Protocol Support

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/311?src=pr&el=h1) Report
> Merging [#311](https://codecov.io/gh/apache/dubbo-go/pull/311?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/979acb2a53f1e2c0d0131907bde78479570160fe?src=pr&el=desc) will **increase** coverage by `0.26%`.
> The diff coverage is `79.45%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/311/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/311?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #311      +/-   ##
===========================================
+ Coverage    66.58%   66.84%   +0.26%     
===========================================
  Files          113      118       +5     
  Lines         7239     7396     +157     
===========================================
+ Hits          4820     4944     +124     
- Misses        1947     1963      +16     
- Partials       472      489      +17
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/311?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/configurator/override.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9jb25maWd1cmF0b3Ivb3ZlcnJpZGUuZ28=) | `75.4% <ø> (ø)` | :arrow_up: |
| [...l/tps/tps\_limit\_thread\_safe\_fix\_window\_strategy.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rwcy90cHNfbGltaXRfdGhyZWFkX3NhZmVfZml4X3dpbmRvd19zdHJhdGVneS5nbw==) | `100% <ø> (ø)` | |
| [filter/filter\_impl/tps\_limit\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rwc19saW1pdF9maWx0ZXIuZ28=) | `88.23% <ø> (ø)` | |
| [filter/filter\_impl/graceful\_shutdown\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dyYWNlZnVsX3NodXRkb3duX2ZpbHRlci5nbw==) | `80.64% <ø> (ø)` | |
| [...lter/filter\_impl/tps/tps\_limiter\_method\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rwcy90cHNfbGltaXRlcl9tZXRob2Rfc2VydmljZS5nbw==) | `80% <ø> (ø)` | |
| [filter/filter\_impl/echo\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2VjaG9fZmlsdGVyLmdv) | `85.71% <ø> (ø)` | |
| [filter/filter\_impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2h5c3RyaXhfZmlsdGVyLmdv) | `68.64% <ø> (ø)` | |
| [filter/filter\_impl/tps/tps\_limiter\_mock.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rwcy90cHNfbGltaXRlcl9tb2NrLmdv) | `0% <ø> (ø)` | |
| [...ter/handler/rejected\_execution\_handler\_only\_log.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-ZmlsdGVyL2hhbmRsZXIvcmVqZWN0ZWRfZXhlY3V0aW9uX2hhbmRsZXJfb25seV9sb2cuZ28=) | `100% <ø> (ø)` | |
| [filter/filter\_impl/access\_log\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2FjY2Vzc19sb2dfZmlsdGVyLmdv) | `71.02% <ø> (ø)` | |
| ... and [39 more](https://codecov.io/gh/apache/dubbo-go/pull/311/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/311?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/311?src=pr&el=footer). Last update [979acb2...1c0e422](https://codecov.io/gh/apache/dubbo-go/pull/311?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/311 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org