[GitHub] [iceberg] rustyconover commented on a diff in pull request #8084: Python: Improve AVRO reading speed

["rustyconover (via GitHub)" <gi...@apache.org>]

rustyconover commented on code in PR #8084:
URL: https://github.com/apache/iceberg/pull/8084#discussion_r1269494383


##########
python/pyiceberg/avro/reader.py:
##########
@@ -267,10 +267,11 @@ def skip(self, decoder: BinaryDecoder) -> None:
 
 
 class StructReader(Reader):
-    __slots__ = ("field_readers", "create_struct", "struct")
+    __slots__ = ("field_readers", "create_struct", "struct", "create_with_keyword", "_field_reader_functions", "_hash")

Review Comment:
   There is a problem with an arbitrary struct reader that uses Record.  
   
   Record doesn't know what the slot names should be as such it still need to rely on __dict__.  
   
   Rusty



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org