You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/04/13 01:41:28 UTC

[GitHub] [kafka] ableegoldman commented on pull request #10529: KAFKA-12650: fix NPE in InternalTopicManagerTest

ableegoldman commented on pull request #10529:
URL: https://github.com/apache/kafka/pull/10529#issuecomment-818368666


   Personally I would slightly prefer to just increase the max.poll.interval if that's what defines the timeout (although, why would the max poll interval impact a timeout related to the admin client? Or do I not understand where this timeout is ultimately coming from)
   
   But we should probably try to actually handle the `null` even so, and fail with a more useful error message in case we ever do hit this again. Or if we can't handle the null directly, maybe use a not-nice mock so it'll fail rather than just returning null and hitting an NPE


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org