You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "mmartell (GitHub)" <gi...@apache.org> on 2018/11/16 00:10:42 UTC
[GitHub] [geode-native] mmartell opened pull request #405:
GEODE-6043: Improve Auth example
- Implement end to end authentication
Co-authored-by: Ivan Godwin <ig...@pivotal.io>
[ Full content available at: https://github.com/apache/geode-native/pull/405 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] mmartell commented on pull request #405:
GEODE-6043: Improve Auth example
Posted by "mmartell (GitHub)" <gi...@apache.org>.
Removed as unneccessary.
[ Full content available at: https://github.com/apache/geode-native/pull/405 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pivotal-jbarrett commented on pull request
#405: GEODE-6043: Improve Auth example
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
Dude, bad format here. The lines below can fit on this line. Please cleanup.
[ Full content available at: https://github.com/apache/geode-native/pull/405 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pivotal-jbarrett commented on pull request
#405: GEODE-6043: Improve Auth example
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
Dummy is a bit negative. Simple maybe?
[ Full content available at: https://github.com/apache/geode-native/pull/405 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] mmartell commented on pull request #405:
GEODE-6043: Improve Auth example
Posted by "mmartell (GitHub)" <gi...@apache.org>.
Removed as not necessary.
[ Full content available at: https://github.com/apache/geode-native/pull/405 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] mmartell closed pull request #405:
GEODE-6043: Improve Auth example
Posted by "mmartell (GitHub)" <gi...@apache.org>.
[ pull request closed by mmartell ]
[ Full content available at: https://github.com/apache/geode-native/pull/405 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] mmartell commented on pull request #405:
GEODE-6043: Improve Auth example
Posted by "mmartell (GitHub)" <gi...@apache.org>.
Good catch. Dummy may be OK for our internal tests. I agree SimpleAuthenticator is much better for sample code.
[ Full content available at: https://github.com/apache/geode-native/pull/405 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] mmartell commented on pull request #405:
GEODE-6043: Improve Auth example
Posted by "mmartell (GitHub)" <gi...@apache.org>.
Removed as unneccessary.
[ Full content available at: https://github.com/apache/geode-native/pull/405 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] mmartell commented on issue #405: GEODE-6043:
Improve Auth example
Posted by "mmartell (GitHub)" <gi...@apache.org>.
Hey jbarrett, your fixes are in! Good review!
[ Full content available at: https://github.com/apache/geode-native/pull/405 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] mmartell commented on pull request #405:
GEODE-6043: Improve Auth example
Posted by "mmartell (GitHub)" <gi...@apache.org>.
Fixed. Good catch.
[ Full content available at: https://github.com/apache/geode-native/pull/405 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pivotal-jbarrett commented on pull request
#405: GEODE-6043: Improve Auth example
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
Since 5.5 what?
[ Full content available at: https://github.com/apache/geode-native/pull/405 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org