You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by co...@apache.org on 2005/08/31 18:11:02 UTC
svn commit: r265523 - in /httpd/httpd/trunk/server/mpm:
experimental/event/event.c experimental/leader/leader.c
experimental/threadpool/threadpool.c prefork/prefork.c
Author: colm
Date: Wed Aug 31 09:10:55 2005
New Revision: 265523
URL: http://svn.apache.org/viewcvs?rev=265523&view=rev
Log:
Initiliase all of the first_*_limit variables to zero, so that we can actually
raise limits beyond their defaults reliably.
Modified:
httpd/httpd/trunk/server/mpm/experimental/event/event.c
httpd/httpd/trunk/server/mpm/experimental/leader/leader.c
httpd/httpd/trunk/server/mpm/experimental/threadpool/threadpool.c
httpd/httpd/trunk/server/mpm/prefork/prefork.c
Modified: httpd/httpd/trunk/server/mpm/experimental/event/event.c
URL: http://svn.apache.org/viewcvs/httpd/httpd/trunk/server/mpm/experimental/event/event.c?rev=265523&r1=265522&r2=265523&view=diff
==============================================================================
--- httpd/httpd/trunk/server/mpm/experimental/event/event.c (original)
+++ httpd/httpd/trunk/server/mpm/experimental/event/event.c Wed Aug 31 09:10:55 2005
@@ -146,9 +146,9 @@
static int max_spare_threads = 0;
static int ap_daemons_limit = 0;
static int server_limit = DEFAULT_SERVER_LIMIT;
-static int first_server_limit;
+static int first_server_limit = 0;
static int thread_limit = DEFAULT_THREAD_LIMIT;
-static int first_thread_limit;
+static int first_thread_limit = 0;
static int changed_limit_at_restart;
static int dying = 0;
static int workers_may_exit = 0;
Modified: httpd/httpd/trunk/server/mpm/experimental/leader/leader.c
URL: http://svn.apache.org/viewcvs/httpd/httpd/trunk/server/mpm/experimental/leader/leader.c?rev=265523&r1=265522&r2=265523&view=diff
==============================================================================
--- httpd/httpd/trunk/server/mpm/experimental/leader/leader.c (original)
+++ httpd/httpd/trunk/server/mpm/experimental/leader/leader.c Wed Aug 31 09:10:55 2005
@@ -114,9 +114,9 @@
static int max_spare_threads = 0;
static int ap_daemons_limit = 0;
static int server_limit = DEFAULT_SERVER_LIMIT;
-static int first_server_limit;
+static int first_server_limit = 0;
static int thread_limit = DEFAULT_THREAD_LIMIT;
-static int first_thread_limit;
+static int first_thread_limit = 0;
static int changed_limit_at_restart;
static int dying = 0;
static int workers_may_exit = 0;
Modified: httpd/httpd/trunk/server/mpm/experimental/threadpool/threadpool.c
URL: http://svn.apache.org/viewcvs/httpd/httpd/trunk/server/mpm/experimental/threadpool/threadpool.c?rev=265523&r1=265522&r2=265523&view=diff
==============================================================================
--- httpd/httpd/trunk/server/mpm/experimental/threadpool/threadpool.c (original)
+++ httpd/httpd/trunk/server/mpm/experimental/threadpool/threadpool.c Wed Aug 31 09:10:55 2005
@@ -120,9 +120,9 @@
static int max_spare_threads = 0;
static int ap_daemons_limit = 0;
static int server_limit = DEFAULT_SERVER_LIMIT;
-static int first_server_limit;
+static int first_server_limit = 0;
static int thread_limit = DEFAULT_THREAD_LIMIT;
-static int first_thread_limit;
+static int first_thread_limit = 0;
static int changed_limit_at_restart;
static int dying = 0;
static int workers_may_exit = 0;
Modified: httpd/httpd/trunk/server/mpm/prefork/prefork.c
URL: http://svn.apache.org/viewcvs/httpd/httpd/trunk/server/mpm/prefork/prefork.c?rev=265523&r1=265522&r2=265523&view=diff
==============================================================================
--- httpd/httpd/trunk/server/mpm/prefork/prefork.c (original)
+++ httpd/httpd/trunk/server/mpm/prefork/prefork.c Wed Aug 31 09:10:55 2005
@@ -97,7 +97,7 @@
static int ap_daemons_max_free=0;
static int ap_daemons_limit=0; /* MaxClients */
static int server_limit = DEFAULT_SERVER_LIMIT;
-static int first_server_limit;
+static int first_server_limit = 0;
static int changed_limit_at_restart;
static int mpm_state = AP_MPMQ_STARTING;
static ap_pod_t *pod;
Re: svn commit: r265523 - in /httpd/httpd/trunk/server/mpm: experimental/event/event.c experimental/leader/leader.c experimental/threadpool/threadpool.c prefork/prefork.c
Posted by Colm MacCarthaigh <co...@stdlib.net>.
On Wed, Aug 31, 2005 at 06:11:21PM +0100, Colm MacCarthaigh wrote:
> On Wed, Aug 31, 2005 at 01:02:55PM -0400, Jeff Trawick wrote:
> > > Initiliase all of the first_*_limit variables to zero, so that we can actually
> > > raise limits beyond their defaults reliably.
> >
> > How can a C-language global variable not be initialized to zero?
>
> A gcc ia64 bug, possibly. I can't raise ThreadLimit without those
> changes.
Yep, it's a compiler bug, meddling with optimisations fixes it too. I
don't see any harm in leaving the assignment in though.
--
Colm MacCárthaigh Public Key: colm+pgp@stdlib.net
Re: svn commit: r265523 - in /httpd/httpd/trunk/server/mpm: experimental/event/event.c experimental/leader/leader.c experimental/threadpool/threadpool.c prefork/prefork.c
Posted by Colm MacCarthaigh <co...@stdlib.net>.
On Wed, Aug 31, 2005 at 01:02:55PM -0400, Jeff Trawick wrote:
> > Initiliase all of the first_*_limit variables to zero, so that we can actually
> > raise limits beyond their defaults reliably.
>
> How can a C-language global variable not be initialized to zero?
A gcc ia64 bug, possibly. I can't raise ThreadLimit without those
changes.
--
Colm MacCárthaigh Public Key: colm+pgp@stdlib.net
Re: svn commit: r265523 - in /httpd/httpd/trunk/server/mpm: experimental/event/event.c experimental/leader/leader.c experimental/threadpool/threadpool.c prefork/prefork.c
Posted by Jeff Trawick <tr...@gmail.com>.
On 8/31/05, colm@apache.org <co...@apache.org> wrote:
> Author: colm
> Date: Wed Aug 31 09:10:55 2005
> New Revision: 265523
>
> URL: http://svn.apache.org/viewcvs?rev=265523&view=rev
> Log:
>
> Initiliase all of the first_*_limit variables to zero, so that we can actually
> raise limits beyond their defaults reliably.
How can a C-language global variable not be initialized to zero?