[GitHub] [commons-io] garydgregory commented on a diff in pull request #39: IO-543-ReversedLinesFileReader-with-RandowFileAccess-API

[GitBox <gi...@apache.org>]

garydgregory commented on code in PR #39:
URL: https://github.com/apache/commons-io/pull/39#discussion_r940345283


##########
src/main/java/org/apache/commons/io/input/ReversedLinesFileReader.java:
##########
@@ -211,6 +228,8 @@ private class FilePart {
         private byte[] leftOver;
 
         private int currentLastBytePos;
+        private int mappedFilePointer; // store file pointer position according to currentLastBytePos but take

Review Comment:
   Just a Javadoc comment instead.



##########
src/main/java/org/apache/commons/io/input/ReversedLinesFileReader.java:
##########
@@ -303,6 +323,7 @@ private String readLine() throws IOException {
                     line = new String(lineData, encoding);
 
                     currentLastBytePos = i - newLineMatchByteCount;
+                    mappedFilePointer=i;

Review Comment:
   Fix formatting.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org