[GitHub] [superset] john-bodley commented on a diff in pull request #20810: refactor: Improve performance regression introduced in #20473

[GitBox <gi...@apache.org>]

john-bodley commented on code in PR #20810:
URL: https://github.com/apache/superset/pull/20810#discussion_r926927548


##########
superset/datasets/dao.py:
##########
@@ -178,33 +178,29 @@ def update_columns(
         """
 
         column_by_id = {column.id: column for column in model.columns}
-        columns = []
 
         for properties in property_columns:
             if "id" in properties:
-                columns.append(

Review Comment:
   This was the root of the problem, i.e., existing columns shouldn't be added to the set of columns which need to be bound to the dataset when updated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org