You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/01/14 21:41:59 UTC
[GitHub] [netbeans] lkishalmi opened a new pull request #1871:
[NETBEANS-3115] Resolve third-party source against open Gradle projects.
lkishalmi opened a new pull request #1871: [NETBEANS-3115] Resolve third-party source against open Gradle projects.
URL: https://github.com/apache/netbeans/pull/1871
I've started a poll on the dev maillist if I need to implement a switch for this or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on issue #1871:
[NETBEANS-3115] Resolve third-party source against open Gradle projects.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on issue #1871: [NETBEANS-3115] Resolve third-party source against open Gradle projects.
URL: https://github.com/apache/netbeans/pull/1871#issuecomment-575297369
How do they behave different? They define binary dependencies and these can have sources attached. My scenario I tested:
- I create a project `library` (just a `DemoLib` class with a `dummyMethod`)
- I `maven -Prelease-profile install`ed version `1.0`, `2.0` and `3.0-SNAPSHOT`
- I created an application project that depends on library version `3.0-SNAPSHOT`, both projects are open in netbeans
- I invoke "Navigate -> Go to Source" on `demoLib.dummyMethod()`
At this point netbeans takes me to the code in the project that I have open.
- I change the dependency to `2.0`
- I invoke "Navigate -> Go to Source" on `demoLib.dummyMethod()`
At this point the source code of the source jar is opened and shown.
- I checkout version `2.0` of `library`
- I invoke "Navigate -> Go to Source" on `demoLib.dummyMethod()`
At this point I'm taken to the source of the open project.
From my perspective the behavior of the Integration of Maven in NetBeans in completely sane: If you have the source for a maven project open _and_ the version of the project matches the version of the dependency then the project source code is used, else the source jar is used to show the source.
If you don't do this, you will get misleading results. I once accidentally chased a bug that I misdiagnosed, because the lines in the source code did not match the one in the stack trace because I had the wrong version opened.
IMHO this would be a sane implementation for gradle as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi merged pull request #1871: [NETBEANS-3115]
Resolve third-party source against open Gradle projects.
Posted by GitBox <gi...@apache.org>.
lkishalmi merged pull request #1871: [NETBEANS-3115] Resolve third-party source against open Gradle projects.
URL: https://github.com/apache/netbeans/pull/1871
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on issue #1871:
[NETBEANS-3115] Resolve third-party source against open Gradle projects.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on issue #1871: [NETBEANS-3115] Resolve third-party source against open Gradle projects.
URL: https://github.com/apache/netbeans/pull/1871#issuecomment-575246119
The poll was a bit short. So are maven and gradle implementations aligned/behaving similar?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on issue #1871: [NETBEANS-3115]
Resolve third-party source against open Gradle projects.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on issue #1871: [NETBEANS-3115] Resolve third-party source against open Gradle projects.
URL: https://github.com/apache/netbeans/pull/1871#issuecomment-575307120
> From my perspective the behavior of the Integration of Maven in NetBeans in completely sane: If you have the source for a maven project open and the version of the project matches the version of the dependency then the project source code is used, else the source jar is used to show the source.
Wholeheartedly agree! Lots of Maven in NetBeans is completely sane. :smile: I just also had in mind the comments at https://docs.gradle.org/current/userguide/declaring_repositories.html#sec:case-for-maven-local This might reflect a need for a somewhat different approach between the two? But I don't use Gradle often enough to not need a refresher read each time so may be wrong - was actually reading that link yesterday. The important thing is, as you say, the sources match exactly what you're compiling against.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi edited a comment on issue #1871:
[NETBEANS-3115] Resolve third-party source against open Gradle projects.
Posted by GitBox <gi...@apache.org>.
lkishalmi edited a comment on issue #1871: [NETBEANS-3115] Resolve third-party source against open Gradle projects.
URL: https://github.com/apache/netbeans/pull/1871#issuecomment-575319658
With this code in, Gradle works the same as Maven in NetBeans. The poll is still open, if anyone would really debate on adding this behind a switch, I'd implement that in another PR. Though there are no response so far.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing edited a comment on issue #1871:
[NETBEANS-3115] Resolve third-party source against open Gradle projects.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing edited a comment on issue #1871: [NETBEANS-3115] Resolve third-party source against open Gradle projects.
URL: https://github.com/apache/netbeans/pull/1871#issuecomment-575297369
How do they behave different? They define binary dependencies and these can have sources attached. My scenario I tested:
- I create a project `library` (just a `DemoLib` class with a `dummyMethod`)
- I `maven -Prelease-profile install`ed version `1.0`, `2.0` and `3.0-SNAPSHOT`
- I created an application project that depends on library version `3.0-SNAPSHOT`, both projects are open in netbeans
- I invoke "Navigate -> Go to Source" on `demoLib.dummyMethod()`
At this point netbeans takes me to the code in the project that I have open.
- I change the dependency to `2.0`
- I invoke "Navigate -> Go to Source" on `demoLib.dummyMethod()`
At this point the source code of the source jar is opened and shown.
- I checkout version `2.0` of `library`
- I invoke "Navigate -> Go to Source" on `demoLib.dummyMethod()`
At this point I'm taken to the source of the open project.
From my perspective the behavior of the Integration of Maven in NetBeans in completely sane: If you have the source for a maven project open _and_ the version of the project matches the version of the dependency then the project source code is used, else the source jar is used to show the source.
If you don't do this, you will get misleading results. I once accidentally chased a bug that I misdiagnosed, because the lines in the source code did not match the one in the stack trace because I had the wrong version opened.
IMHO this would be a sane implementation for gradle as well.
And here is the code I used to test:
[TestVersions.zip](https://github.com/apache/netbeans/files/4073228/TestVersions.zip)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on issue #1871: [NETBEANS-3115]
Resolve third-party source against open Gradle projects.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on issue #1871: [NETBEANS-3115] Resolve third-party source against open Gradle projects.
URL: https://github.com/apache/netbeans/pull/1871#issuecomment-575264255
@matthiasblaesing don't Maven and Gradle themselves behave differently in this respect though?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on issue #1871:
[NETBEANS-3115] Resolve third-party source against open Gradle projects.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on issue #1871: [NETBEANS-3115] Resolve third-party source against open Gradle projects.
URL: https://github.com/apache/netbeans/pull/1871#issuecomment-575326195
Thank you for the confirmation. I think having maven and gradle behave identical or at least very similar make it more consistent to work with NetBeans.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on issue #1871: [NETBEANS-3115]
Resolve third-party source against open Gradle projects.
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on issue #1871: [NETBEANS-3115] Resolve third-party source against open Gradle projects.
URL: https://github.com/apache/netbeans/pull/1871#issuecomment-575319658
With this code in Gradle works the same as Maven in NetBeans. The poll is still open, if anyone would really debate on adding this behind a switch, I'd implement that in another PR. Though there are no response so far.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists