[jira] [Commented] (YETUS-187) maven javac/javadoc can't use calcdiffs

["Yetus QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YETUS-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15060091#comment-15060091 ] 

Yetus QA commented on YETUS-187:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s {color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} shellcheck {color} | {color:red} 0m 6s {color} | {color:red} The applied patch generated 1 new shellcheck issues (total was 13, now 14). {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 0s {color} | {color:green} Patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 0m 15s {color} | {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.9.1 Server=1.9.1 Image:yetus/yetus:577e74f |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12778008/YETUS-187.00.patch |
| JIRA Issue | YETUS-187 |
| Optional Tests |  shellcheck  |
| uname | Linux a89e3a0588ce 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | nobuild |
| git revision | master / bec32f2 |
| shellcheck | v0.4.1 |
| shellcheck | https://builds.apache.org/job/PreCommit-YETUS-Build/182/artifact/patchprocess/diff-patch-shellcheck.txt |
| modules | C:  U:  |
| Powered by | Apache Yetus 0.2.0-SNAPSHOT   http://yetus.apache.org |
| Console output | https://builds.apache.org/job/PreCommit-YETUS-Build/182/console |


This message was automatically generated.



> maven javac/javadoc can't use calcdiffs
> ---------------------------------------
>
>                 Key: YETUS-187
>                 URL: https://issues.apache.org/jira/browse/YETUS-187
>             Project: Yetus
>          Issue Type: Bug
>          Components: Test Patch
>    Affects Versions: 0.1.0
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>         Attachments: YETUS-187.00.patch
>
>
> calcdiffs works by doing the following:
> * given two files (A, B)
> * from (A,B), pull everything from the last colon(\:) out and into (C,D). This gives us a list of all errors in order without line numbers, columns, or filenames in the way.
> * do a diff of C and D, printing the numbers of the lines that are different from D
> * using the line numbers, pull out the lines from B, restoring the filenames, lines, and columns
> End result will be, the vast majority of the time (but not 100%), the new errors generated by B. The places where this doesn't work is when the surrounding context isn't different enough. e.g., multiple messages with the same text.  There obviously could be some improvement in accuracy here, but experience has shown this works well enough the majority of the time.
> For maven (and maybe other tools?), though, the place where this falls down is the line format:
> {code}
> [WARNING] Endpoint.java:[162,25] [unchecked] Possible heap pollution from parameterized vararg type Map<String,String>
> {code} 
> In this situation, we end up doing the diff with the line numbers and columns in place which means we're very likely to print any pre-existing errors too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)