You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by ol...@apache.org on 2013/04/15 13:28:40 UTC
svn commit: r1467939 - in /httpcomponents/httpclient/branches/4.2.x:
RELEASE_NOTES.txt
httpclient/src/main/java/org/apache/http/impl/client/DefaultRequestDirector.java
Author: olegk
Date: Mon Apr 15 11:28:40 2013
New Revision: 1467939
URL: http://svn.apache.org/r1467939
Log:
Redirects with underscore character in the location hostname cause IllegalArgumentException
Modified:
httpcomponents/httpclient/branches/4.2.x/RELEASE_NOTES.txt
httpcomponents/httpclient/branches/4.2.x/httpclient/src/main/java/org/apache/http/impl/client/DefaultRequestDirector.java
Modified: httpcomponents/httpclient/branches/4.2.x/RELEASE_NOTES.txt
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.2.x/RELEASE_NOTES.txt?rev=1467939&r1=1467938&r2=1467939&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.2.x/RELEASE_NOTES.txt (original)
+++ httpcomponents/httpclient/branches/4.2.x/RELEASE_NOTES.txt Mon Apr 15 11:28:40 2013
@@ -1,6 +1,10 @@
Changes since Release 4.2.4
-------------------
+* [HTTPCLIENT-1342] Redirects with underscore character in the location hostname cause
+ "java.lang.IllegalArgumentException: Host name may not be null".
+ Contributed by Oleg Kalnichevski <olegk at apache.org>
+
* [HTTPCLIENT-1338] (regression) Invalidated / stale DIGEST schemes do not get evicted from
the auth cache.
Contributed by Oleg Kalnichevski <olegk at apache.org>
Modified: httpcomponents/httpclient/branches/4.2.x/httpclient/src/main/java/org/apache/http/impl/client/DefaultRequestDirector.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.2.x/httpclient/src/main/java/org/apache/http/impl/client/DefaultRequestDirector.java?rev=1467939&r1=1467938&r2=1467939&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.2.x/httpclient/src/main/java/org/apache/http/impl/client/DefaultRequestDirector.java (original)
+++ httpcomponents/httpclient/branches/4.2.x/httpclient/src/main/java/org/apache/http/impl/client/DefaultRequestDirector.java Mon Apr 15 11:28:40 2013
@@ -497,8 +497,7 @@ public class DefaultRequestDirector impl
} else {
URI requestURI = wrapper.getURI();
if (requestURI.isAbsolute()) {
- target = new HttpHost(
- requestURI.getHost(), requestURI.getPort(), requestURI.getScheme());
+ target = URIUtils.extractHost(requestURI);
}
}
if (target == null) {