You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jdo-dev@db.apache.org by "Michael Watzek (JIRA)" <ji...@apache.org> on 2005/10/04 14:25:51 UTC

[jira] Created: (JDO-160) Implement new JDO 2 query tests cases concerning parameters.

Implement new JDO 2 query tests cases concerning parameters.
------------------------------------------------------------

         Key: JDO-160
         URL: http://issues.apache.org/jira/browse/JDO-160
     Project: JDO
        Type: New Feature
  Components: tck20  
    Reporter: Michael Watzek
 Assigned to: Michael Watzek 


 We need 4 new test classes, one for each of the following assertions: 

- A14.6.3-2: Parameters must all be declared explicitly via declareParameters or all be declared implicitly in the filter.
- A14.6.3-3: Parameters implicitly declared (in the result, filter, grouping, ordering, or range) are identified by prepending a ":" to the parameter everywhere it appears. All parameter types can be determined by one of the following techniques.
- A14.6.13-3: If implicit parameters are used, their order of appearance in the query determines their order for binding to positional parameters for execution.

Details can be found on Wiki page http://wiki.apache.org/jdo/QueryTests#Parameters

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (JDO-160) Implement new JDO 2 query tests cases concerning parameters.

Posted by "Michael Bouschen (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/JDO-160?page=comments#action_12332464 ] 

Michael Bouschen commented on JDO-160:
--------------------------------------

Two comments:
- Class OrderOfParameters defines queries using explicilty declared parameters . I propose to change this to implicit parameters, because the assertion only covers implicit parameters.
- The grouping query in class ImplicitParameters is not valid, it misses a result clause. I propose to add the following result clause: "department.name, COUNT(this)" and change the grouping clause to "department.name HAVING COUNT(this) >= :min".



> Implement new JDO 2 query tests cases concerning parameters.
> ------------------------------------------------------------
>
>          Key: JDO-160
>          URL: http://issues.apache.org/jira/browse/JDO-160
>      Project: JDO
>         Type: New Feature
>   Components: tck20
>     Reporter: Michael Watzek
>     Assignee: Michael Watzek
>  Attachments: JDO-160.patch, JDO-160.patch2
>
>  We need 4 new test classes, one for each of the following assertions: 
> - A14.6.3-2: Parameters must all be declared explicitly via declareParameters or all be declared implicitly in the filter.
> - A14.6.3-3: Parameters implicitly declared (in the result, filter, grouping, ordering, or range) are identified by prepending a ":" to the parameter everywhere it appears. All parameter types can be determined by one of the following techniques.
> - A14.6.13-3: If implicit parameters are used, their order of appearance in the query determines their order for binding to positional parameters for execution.
> Details can be found on Wiki page http://wiki.apache.org/jdo/QueryTests#Parameters

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (JDO-160) Implement new JDO 2 query tests cases concerning parameters.

Posted by "Michael Watzek (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/JDO-160?page=all ]

Michael Watzek updated JDO-160:
-------------------------------

    Attachment: JDO-160.patch

 This patch implements the assertions above.

> Implement new JDO 2 query tests cases concerning parameters.
> ------------------------------------------------------------
>
>          Key: JDO-160
>          URL: http://issues.apache.org/jira/browse/JDO-160
>      Project: JDO
>         Type: New Feature
>   Components: tck20
>     Reporter: Michael Watzek
>     Assignee: Michael Watzek
>  Attachments: JDO-160.patch
>
>  We need 4 new test classes, one for each of the following assertions: 
> - A14.6.3-2: Parameters must all be declared explicitly via declareParameters or all be declared implicitly in the filter.
> - A14.6.3-3: Parameters implicitly declared (in the result, filter, grouping, ordering, or range) are identified by prepending a ":" to the parameter everywhere it appears. All parameter types can be determined by one of the following techniques.
> - A14.6.13-3: If implicit parameters are used, their order of appearance in the query determines their order for binding to positional parameters for execution.
> Details can be found on Wiki page http://wiki.apache.org/jdo/QueryTests#Parameters

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (JDO-160) Implement new JDO 2 query tests cases concerning parameters.

Posted by "Michael Bouschen (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/JDO-160?page=comments#action_12332218 ] 

Michael Bouschen commented on JDO-160:
--------------------------------------

Some comments about JDO-160.patch:

OrderOfParameters:
- I propose to add a second test query that switches the order of param1 and param2, but keeps the order of the actula parameter values. The second query should return an empty result list.

MixedParameters:
- How about adding another negative test query having an explicit and an implict parameter? It declares one parameter "String param1". The filter uses this parameter plus an implicit parameter: "firstname == param1 & lastname == :param2". This mix of explict and implict declared parameters is not valid. 

ImplicitParameters:
- I propose to add a test query using an implict parameter in the having clause.

> Implement new JDO 2 query tests cases concerning parameters.
> ------------------------------------------------------------
>
>          Key: JDO-160
>          URL: http://issues.apache.org/jira/browse/JDO-160
>      Project: JDO
>         Type: New Feature
>   Components: tck20
>     Reporter: Michael Watzek
>     Assignee: Michael Watzek
>  Attachments: JDO-160.patch
>
>  We need 4 new test classes, one for each of the following assertions: 
> - A14.6.3-2: Parameters must all be declared explicitly via declareParameters or all be declared implicitly in the filter.
> - A14.6.3-3: Parameters implicitly declared (in the result, filter, grouping, ordering, or range) are identified by prepending a ":" to the parameter everywhere it appears. All parameter types can be determined by one of the following techniques.
> - A14.6.13-3: If implicit parameters are used, their order of appearance in the query determines their order for binding to positional parameters for execution.
> Details can be found on Wiki page http://wiki.apache.org/jdo/QueryTests#Parameters

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (JDO-160) Implement new JDO 2 query tests cases concerning parameters.

Posted by "Michael Watzek (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/JDO-160?page=all ]
     
Michael Watzek resolved JDO-160:
--------------------------------

    Resolution: Fixed

I incorporated the comments above into the second patch and checked in the changes.


> Implement new JDO 2 query tests cases concerning parameters.
> ------------------------------------------------------------
>
>          Key: JDO-160
>          URL: http://issues.apache.org/jira/browse/JDO-160
>      Project: JDO
>         Type: New Feature
>   Components: tck20
>     Reporter: Michael Watzek
>     Assignee: Michael Watzek
>  Attachments: JDO-160.patch, JDO-160.patch2
>
>  We need 4 new test classes, one for each of the following assertions: 
> - A14.6.3-2: Parameters must all be declared explicitly via declareParameters or all be declared implicitly in the filter.
> - A14.6.3-3: Parameters implicitly declared (in the result, filter, grouping, ordering, or range) are identified by prepending a ":" to the parameter everywhere it appears. All parameter types can be determined by one of the following techniques.
> - A14.6.13-3: If implicit parameters are used, their order of appearance in the query determines their order for binding to positional parameters for execution.
> Details can be found on Wiki page http://wiki.apache.org/jdo/QueryTests#Parameters

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (JDO-160) Implement new JDO 2 query tests cases concerning parameters.

Posted by "Michael Watzek (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/JDO-160?page=all ]

Michael Watzek updated JDO-160:
-------------------------------

    Attachment: JDO-160.patch2

The second patch contains the comments above.


> Implement new JDO 2 query tests cases concerning parameters.
> ------------------------------------------------------------
>
>          Key: JDO-160
>          URL: http://issues.apache.org/jira/browse/JDO-160
>      Project: JDO
>         Type: New Feature
>   Components: tck20
>     Reporter: Michael Watzek
>     Assignee: Michael Watzek
>  Attachments: JDO-160.patch, JDO-160.patch2
>
>  We need 4 new test classes, one for each of the following assertions: 
> - A14.6.3-2: Parameters must all be declared explicitly via declareParameters or all be declared implicitly in the filter.
> - A14.6.3-3: Parameters implicitly declared (in the result, filter, grouping, ordering, or range) are identified by prepending a ":" to the parameter everywhere it appears. All parameter types can be determined by one of the following techniques.
> - A14.6.13-3: If implicit parameters are used, their order of appearance in the query determines their order for binding to positional parameters for execution.
> Details can be found on Wiki page http://wiki.apache.org/jdo/QueryTests#Parameters

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira