You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff <to...@me.com> on 2016/11/29 15:32:27 UTC
Review Request 54165: Fixed conflict in hook result handling.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54165/
-----------------------------------------------------------
Review request for mesos, Adam B, Benjamin Bannier, Gast�n Kleiman, and Kapil Arya.
Repository: mesos
Description
-------
see summary.
Diffs
-----
src/slave/containerizer/docker.cpp 5ce4667b61bb226f726beda6e21b839456e0b941
Diff: https://reviews.apache.org/r/54165/diff/
Testing
-------
make check
Thanks,
Till Toenshoff
Re: Review Request 54165: Fixed conflict in hook result handling.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54165/#review157265
-----------------------------------------------------------
Ship it!
- Benjamin Bannier
On Nov. 29, 2016, 4:32 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54165/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2016, 4:32 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Bannier, Gast�n Kleiman, and Kapil Arya.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 5ce4667b61bb226f726beda6e21b839456e0b941
>
> Diff: https://reviews.apache.org/r/54165/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 54165: Fixed conflict in hook result handling.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54165/#review157323
-----------------------------------------------------------
Ship it!
Ship It!
- Kapil Arya
On Nov. 29, 2016, 11:37 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54165/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2016, 11:37 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Bannier, Gast�n Kleiman, and Kapil Arya.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 5ce4667b61bb226f726beda6e21b839456e0b941
>
> Diff: https://reviews.apache.org/r/54165/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 54165: Fixed conflict in hook result handling.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54165/#review157276
-----------------------------------------------------------
Patch looks great!
Reviews applied: [54165]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Nov. 29, 2016, 4:37 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54165/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2016, 4:37 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Bannier, Gast�n Kleiman, and Kapil Arya.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 5ce4667b61bb226f726beda6e21b839456e0b941
>
> Diff: https://reviews.apache.org/r/54165/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 54165: Fixed conflict in hook result handling.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54165/
-----------------------------------------------------------
(Updated Nov. 29, 2016, 4:37 p.m.)
Review request for mesos, Adam B, Benjamin Bannier, Gast�n Kleiman, and Kapil Arya.
Changes
-------
Small code readability fix.
Repository: mesos
Description
-------
see summary.
Diffs (updated)
-----
src/slave/containerizer/docker.cpp 5ce4667b61bb226f726beda6e21b839456e0b941
Diff: https://reviews.apache.org/r/54165/diff/
Testing
-------
make check
Thanks,
Till Toenshoff