You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@samoa.apache.org by abifet <gi...@git.apache.org> on 2015/10/14 10:34:21 UTC

[GitHub] incubator-samoa pull request: SAMOA-40: Add Kafka stream reader mo...

Github user abifet commented on the pull request:

    https://github.com/apache/incubator-samoa/pull/32#issuecomment-147974180
  
    @gdfm, @karande I think that the code has improved a lot and it's already there. My main concern right now is how to read sparse instances in the sparse instance format ( like  "{1 0.24, 434 0.34, 500:1}") and not only in the dense instance format (like "0.223, .2323, 1"). 
    
    The code to convert strings to dense and sparse instances is in org.apache.samoa.instances.ArffLoader, and it uses java.io.Reader to get the raw data. One way to do this could be that KafkaReader extends Reader, and then use ArffLoader to get the instances using the KafkaReader.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---