You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by "paulirwin (via GitHub)" <gi...@apache.org> on 2026/07/08 20:16:46 UTC
[PR] Backport trivial production fixes from Lucene 4.8.1, #1381 Batch 1 [lucenenet]
paulirwin opened a new pull request, #1413:
URL: https://github.com/apache/lucenenet/pull/1413
- [X] You've read the [Contributor Guide](https://github.com/apache/lucenenet/blob/master/CONTRIBUTING.md) and [Code of Conduct](https://www.apache.org/foundation/policies/conduct.html).
- [X] You've included unit or integration tests for your change, where applicable.
- [X] You've included inline docs for your change, where applicable.
- [X] There's an open issue for the PR that you are making. If you'd like to propose a change, please [open an issue](https://github.com/apache/lucenenet/issues/new/choose) to discuss the change or find an existing issue.
Backport trivial production fixes from Lucene 4.8.1
Partial #1381 (Batch 1)
## Description
- LUCENE-5635 (partial): move `stream.Reset()` into the `try` block
- LUCENE-5668: fix off-by-one error in TieredMergePolicy + test
- LUCENE-5656 (partial): don't leak dv producers if one of them throws exception
- Commit 9d10d6f92cc (no JIRA ticket; partial): throw ArgumentOutOfRangeException if `len > short.MaxValue`
- LUCENE-5644 (partial): add `PulseAll` call to `DeactivateUnreleasedStates`
Note that the partial items will be fully completed in Batch 5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Port trivial production fixes from Lucene 4.8.1, #1381 Batch 1 [lucenenet]
Posted by "paulirwin (via GitHub)" <gi...@apache.org>.
paulirwin commented on code in PR #1413:
URL: https://github.com/apache/lucenenet/pull/1413#discussion_r4254397280
##########
src/Lucene.Net.Tests/Index/TestTieredMergePolicy.cs:
##########
@@ -274,5 +278,39 @@ public virtual void TestSetters()
// TODO: Add more checks for other non-double setters!
}
+
+ // LUCENE-5668
+ [Test]
+ public void TestUnbalancedMergeSelection()
+ {
+ using Directory dir = NewDirectory();
+ IndexWriterConfig iwc = new IndexWriterConfig(TEST_VERSION_CURRENT, new MockAnalyzer(Random));
+ TieredMergePolicy tmp = (TieredMergePolicy)iwc.MergePolicy;
+ tmp.FloorSegmentMB = 0.00001;
+ iwc.MergeScheduler = new SerialMergeScheduler();
+ iwc.MaxBufferedDocs = 100;
+ iwc.RAMBufferSizeMB = -1;
+ using IndexWriter w = new IndexWriter(dir, iwc);
+ for (int i = 0; i < 100000; i++)
+ {
+ Document doc = new Document();
+ doc.Add(NewTextField("id", Random.NextInt64() + "" + Random.NextInt64(), Field.Store.YES));
Review Comment:
Finally fixed what I said I'd fix in August 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Port trivial production fixes from Lucene 4.8.1, #1381 Batch 1 [lucenenet]
Posted by "paulirwin (via GitHub)" <gi...@apache.org>.
paulirwin commented on code in PR #1413:
URL: https://github.com/apache/lucenenet/pull/1413#discussion_r4254395841
##########
src/Lucene.Net.Tests/Index/TestTieredMergePolicy.cs:
##########
@@ -274,5 +278,39 @@ public virtual void TestSetters()
// TODO: Add more checks for other non-double setters!
}
+
+ // LUCENE-5668
+ [Test]
+ public void TestUnbalancedMergeSelection()
+ {
+ using Directory dir = NewDirectory();
+ IndexWriterConfig iwc = new IndexWriterConfig(TEST_VERSION_CURRENT, new MockAnalyzer(Random));
+ TieredMergePolicy tmp = (TieredMergePolicy)iwc.MergePolicy;
+ tmp.FloorSegmentMB = 0.00001;
+ iwc.MergeScheduler = new SerialMergeScheduler();
+ iwc.MaxBufferedDocs = 100;
Review Comment:
Updated to use fluent syntax
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Port trivial production fixes from Lucene 4.8.1, #1381 Batch 1 [lucenenet]
Posted by "paulirwin (via GitHub)" <gi...@apache.org>.
paulirwin commented on code in PR #1413:
URL: https://github.com/apache/lucenenet/pull/1413#discussion_r3905302240
##########
src/Lucene.Net/Index/DocInverterPerField.cs:
##########
@@ -103,11 +103,12 @@ public override void ProcessFields(IIndexableField[] fields, int count)
bool succeededInProcessingField = false;
TokenStream stream = field.GetTokenStream(docState.analyzer);
- // reset the TokenStream to the first token
- stream.Reset();
try
{
+ // reset the TokenStream to the first token
Review Comment:
#1381 (of which this PR is one of 5 batches of work) _is_ the concerted effort to bump the rest of the project to 4.8.1. I went commit by commit (well, with the help of Claude Code, and validated by hand) and analyzed what the deltas were. Once all 5 batches are merged, Lucene.NET will be exactly matching 4.8.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Backport trivial production fixes from Lucene 4.8.1, #1381 Batch 1 [lucenenet]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #1413:
URL: https://github.com/apache/lucenenet/pull/1413#discussion_r3547021039
##########
src/Lucene.Net/Util/OfflineSorter.cs:
##########
@@ -683,6 +683,10 @@ public virtual void Write(byte[] bytes, int off, int len)
if (off > bytes.Length - len) // Checks for int overflow
throw new ArgumentException("Index and length must refer to a location within the array.");
+ // Lucene 4.8.1 commit 9d10d6f92cc (no JIRA number given)
+ if (len > short.MaxValue)
+ throw new ArgumentOutOfRangeException(nameof(len), $"len must be <= {short.MaxValue}; got {len}");
Review Comment:
The new `len > short.MaxValue` guard changes observable behavior of `ByteSequencesWriter.Write(...)`, but there’s no unit test asserting this exception path. Adding a small test in `src/Lucene.Net.Tests/Util/TestOfflineSorter.cs` (e.g., create a `byte[short.MaxValue + 1]` and assert `ArgumentOutOfRangeException`) would protect against regressions.
##########
src/Lucene.Net.Tests/Index/TestTieredMergePolicy.cs:
##########
@@ -274,5 +274,38 @@ public virtual void TestSetters()
// TODO: Add more checks for other non-double setters!
}
+
+ // LUCENE-5668
+ [Test]
+ public void TestUnbalancedMergeSelection()
+ {
+ Directory dir = NewDirectory();
+ IndexWriterConfig iwc = new IndexWriterConfig(TEST_VERSION_CURRENT, new MockAnalyzer(Random));
+ TieredMergePolicy tmp = (TieredMergePolicy)iwc.MergePolicy;
+ tmp.FloorSegmentMB = 0.00001;
+ iwc.MergeScheduler = new SerialMergeScheduler();
+ iwc.MaxBufferedDocs = 100;
+ iwc.RAMBufferSizeMB = -1;
+ IndexWriter w = new IndexWriter(dir, iwc);
+ for (int i = 0; i < 100000; i++)
+ {
+ Document doc = new Document();
+ doc.Add(NewTextField("id", Random.NextInt64() + "" + Random.NextInt64(), Field.Store.YES));
+ w.AddDocument(doc);
+ }
+
+ IndexReader r = DirectoryReader.Open(w, true);
+
+ // Make sure TMP always merged equal-number-of-docs segments:
+ foreach (AtomicReaderContext ctx in r.Leaves)
+ {
+ int numDocs = ctx.Reader.NumDocs;
+ Assert.IsTrue(numDocs == 100 || numDocs == 1000 || numDocs == 10000, $"got numDocs={numDocs}");
+ }
+
+ r.Dispose();
+ w.Dispose();
+ dir.Dispose();
+ }
Review Comment:
`TestUnbalancedMergeSelection()` disposes `IndexReader`/`IndexWriter`/`Directory` only at the end of the method, so an assertion failure will leak resources and can cascade into failures in subsequent tests. Wrap the test body in a `try/finally` (or use `using`) so cleanup happens even when the test fails.
##########
src/Lucene.Net/Util/OfflineSorter.cs:
##########
@@ -683,6 +683,10 @@ public virtual void Write(byte[] bytes, int off, int len)
if (off > bytes.Length - len) // Checks for int overflow
throw new ArgumentException("Index and length must refer to a location within the array.");
+ // Lucene 4.8.1 commit 9d10d6f92cc (no JIRA number given)
+ if (len > short.MaxValue)
+ throw new ArgumentOutOfRangeException(nameof(len), $"len must be <= {short.MaxValue}; got {len}");
Review Comment:
The new `len > short.MaxValue` guard introduces an additional `ArgumentOutOfRangeException` case, but the XML docs for `Write(byte[] bytes, int off, int len)` still only mention negative `off/len`. Update the `<exception>` documentation so callers get accurate API docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Port trivial production fixes from Lucene 4.8.1, #1381 Batch 1 [lucenenet]
Posted by "paulirwin (via GitHub)" <gi...@apache.org>.
paulirwin merged PR #1413:
URL: https://github.com/apache/lucenenet/pull/1413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Port trivial production fixes from Lucene 4.8.1, #1381 Batch 1 [lucenenet]
Posted by "paulirwin (via GitHub)" <gi...@apache.org>.
paulirwin commented on code in PR #1413:
URL: https://github.com/apache/lucenenet/pull/1413#discussion_r4254393673
##########
src/Lucene.Net/Index/SegmentReader.cs:
##########
@@ -199,14 +199,13 @@ private void InitDocValuesProducers(Codec codec)
long gen = e.Key;
IList<FieldInfo> infos = e.Value;
DocValuesProducer dvp = segDocValues.GetDocValuesProducer(gen, si, IOContext.READ, dir, dvFormat, infos, TermInfosIndexDivisor);
+ dvGens.Add(gen);
Review Comment:
See other comment; this is retargeting 4.8.1.
##########
src/Lucene.Net/Index/SegmentReader.cs:
##########
@@ -199,14 +199,13 @@ private void InitDocValuesProducers(Codec codec)
long gen = e.Key;
IList<FieldInfo> infos = e.Value;
DocValuesProducer dvp = segDocValues.GetDocValuesProducer(gen, si, IOContext.READ, dir, dvFormat, infos, TermInfosIndexDivisor);
+ dvGens.Add(gen);
foreach (FieldInfo fi in infos)
{
dvProducersByField[fi.Name] = dvp;
dvProducers.Add(dvp);
}
}
-
- dvGens.AddRange(genInfos.Keys);
Review Comment:
See other comment; this is retargeting 4.8.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Port trivial production fixes from Lucene 4.8.1, #1381 Batch 1 [lucenenet]
Posted by "paulirwin (via GitHub)" <gi...@apache.org>.
paulirwin commented on code in PR #1413:
URL: https://github.com/apache/lucenenet/pull/1413#discussion_r3890683207
##########
src/Lucene.Net.Tests/Index/TestTieredMergePolicy.cs:
##########
@@ -274,5 +278,39 @@ public virtual void TestSetters()
// TODO: Add more checks for other non-double setters!
}
+
+ // LUCENE-5668
+ [Test]
+ public void TestUnbalancedMergeSelection()
+ {
+ using Directory dir = NewDirectory();
+ IndexWriterConfig iwc = new IndexWriterConfig(TEST_VERSION_CURRENT, new MockAnalyzer(Random));
+ TieredMergePolicy tmp = (TieredMergePolicy)iwc.MergePolicy;
+ tmp.FloorSegmentMB = 0.00001;
+ iwc.MergeScheduler = new SerialMergeScheduler();
+ iwc.MaxBufferedDocs = 100;
+ iwc.RAMBufferSizeMB = -1;
+ using IndexWriter w = new IndexWriter(dir, iwc);
+ for (int i = 0; i < 100000; i++)
+ {
+ Document doc = new Document();
+ doc.Add(NewTextField("id", Random.NextInt64() + "" + Random.NextInt64(), Field.Store.YES));
Review Comment:
Good catch, this would have been caught by the other analyzer (once we can get around to fixing its findings...). Will fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Port trivial production fixes from Lucene 4.8.1, #1381 Batch 1 [lucenenet]
Posted by "NightOwl888 (via GitHub)" <gi...@apache.org>.
NightOwl888 commented on code in PR #1413:
URL: https://github.com/apache/lucenenet/pull/1413#discussion_r3902091077
##########
src/Lucene.Net/Index/DocInverterPerField.cs:
##########
@@ -103,11 +103,12 @@ public override void ProcessFields(IIndexableField[] fields, int count)
bool succeededInProcessingField = false;
TokenStream stream = field.GetTokenStream(docState.analyzer);
- // reset the TokenStream to the first token
- stream.Reset();
try
{
+ // reset the TokenStream to the first token
Review Comment:
Technically, AFAIK all of the parts that existed before I started working on Lucene.NET were ported from 4.8.0. That included:
- `Lucene.Net`
- `Lucene.Net.Classification`
- `Lucene.Net.Codecs`
- `Lucene.Net.Expressions`
- `Lucene.Net.Facet`
- `Lucene.Net.Join`
- `Lucene.Net.Queries`
- `Lucene.Net.Spatial`
- `Lucene.Net.Suggest`
- `Lucene.Net.TestFramework`
Since then, I have gone through and confirmed that there were no changes in 4.8.1 in some of them (such as Lucene.Net.Facet) and marked each file as being from 4.8.1.
```
// Lucene version compatibility level 4.8.1
```
The remainder of the projects were also from 4.8.1. So, this sits squarely in 4.8.0 territory and should have comments indicating why we diverged from 4.8.0.
> No objections if you want to start a concerted effort to bump the rest of the project to 4.8.1.
>
> I did some research and discovered that Lucene 4.10.0 did a rare divergence from semver and it included several breaking changes from 5.x. Apparently, they have not put breaking changes into another major release than 4.x. So, after the release, we must stay on this side of 4.10. Or alternatively, we should port to that level before the release (or at least include all of the breaking changes).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Port trivial production fixes from Lucene 4.8.1, #1381 Batch 1 [lucenenet]
Posted by "NightOwl888 (via GitHub)" <gi...@apache.org>.
NightOwl888 commented on code in PR #1413:
URL: https://github.com/apache/lucenenet/pull/1413#discussion_r3888624865
##########
src/Lucene.Net.Tests/Index/TestTieredMergePolicy.cs:
##########
@@ -274,5 +278,39 @@ public virtual void TestSetters()
// TODO: Add more checks for other non-double setters!
}
+
+ // LUCENE-5668
+ [Test]
+ public void TestUnbalancedMergeSelection()
+ {
+ using Directory dir = NewDirectory();
+ IndexWriterConfig iwc = new IndexWriterConfig(TEST_VERSION_CURRENT, new MockAnalyzer(Random));
+ TieredMergePolicy tmp = (TieredMergePolicy)iwc.MergePolicy;
+ tmp.FloorSegmentMB = 0.00001;
+ iwc.MergeScheduler = new SerialMergeScheduler();
+ iwc.MaxBufferedDocs = 100;
+ iwc.RAMBufferSizeMB = -1;
+ using IndexWriter w = new IndexWriter(dir, iwc);
+ for (int i = 0; i < 100000; i++)
+ {
+ Document doc = new Document();
+ doc.Add(NewTextField("id", Random.NextInt64() + "" + Random.NextInt64(), Field.Store.YES));
Review Comment:
Not sure whether it matters for the test, but `Random.NextInt64()` produces both positive and negative values. Converting it to a string in a culture-sensitive way like this means that it will sometimes insert an alternative negative sign. So, this isn't going to be the exact same test as in Java given the same random numbers if the random culture is one with a non-default negative sign.
##########
src/Lucene.Net/Index/SegmentReader.cs:
##########
@@ -199,14 +199,13 @@ private void InitDocValuesProducers(Codec codec)
long gen = e.Key;
IList<FieldInfo> infos = e.Value;
DocValuesProducer dvp = segDocValues.GetDocValuesProducer(gen, si, IOContext.READ, dir, dvFormat, infos, TermInfosIndexDivisor);
+ dvGens.Add(gen);
Review Comment:
Please add a comment here with a commit hash and JIRA number to indicate why we diverged from Lucene 4.8.0 here.
##########
src/Lucene.Net.Tests/Index/TestTieredMergePolicy.cs:
##########
@@ -274,5 +278,39 @@ public virtual void TestSetters()
// TODO: Add more checks for other non-double setters!
}
+
+ // LUCENE-5668
+ [Test]
+ public void TestUnbalancedMergeSelection()
+ {
+ using Directory dir = NewDirectory();
+ IndexWriterConfig iwc = new IndexWriterConfig(TEST_VERSION_CURRENT, new MockAnalyzer(Random));
+ TieredMergePolicy tmp = (TieredMergePolicy)iwc.MergePolicy;
+ tmp.FloorSegmentMB = 0.00001;
+ iwc.MergeScheduler = new SerialMergeScheduler();
+ iwc.MaxBufferedDocs = 100;
Review Comment:
It is not critical to fix, but do note that there is an `IndexWriterConfigExtensions` class that can be used to bring the syntax closer to Lucene. We primarily use this in tests - for users it is an optional add-on in most cases. But there may be use cases where the fluent builder pattern is also useful.
##########
src/Lucene.Net/Index/DocumentsWriterPerThreadPool.cs:
##########
@@ -283,6 +283,9 @@ internal void DeactivateUnreleasedStates()
threadState.Unlock();
}
}
+
+ // In case any threads are waiting for indexing:
+ UninterruptableMonitor.PulseAll(this);
Review Comment:
Please add a comment here with a commit hash and/or JIRA number to indicate why we diverged from Lucene 4.8.0 here.
##########
src/Lucene.Net/Index/DocInverterPerField.cs:
##########
@@ -103,11 +103,12 @@ public override void ProcessFields(IIndexableField[] fields, int count)
bool succeededInProcessingField = false;
TokenStream stream = field.GetTokenStream(docState.analyzer);
- // reset the TokenStream to the first token
- stream.Reset();
try
{
+ // reset the TokenStream to the first token
Review Comment:
Please add a comment here with a commit hash and JIRA number to indicate why we diverged from Lucene 4.8.0 here.
##########
src/Lucene.Net/Index/SegmentReader.cs:
##########
@@ -199,14 +199,13 @@ private void InitDocValuesProducers(Codec codec)
long gen = e.Key;
IList<FieldInfo> infos = e.Value;
DocValuesProducer dvp = segDocValues.GetDocValuesProducer(gen, si, IOContext.READ, dir, dvFormat, infos, TermInfosIndexDivisor);
+ dvGens.Add(gen);
foreach (FieldInfo fi in infos)
{
dvProducersByField[fi.Name] = dvp;
dvProducers.Add(dvp);
}
}
-
- dvGens.AddRange(genInfos.Keys);
Review Comment:
Please add a comment here with a commit hash and JIRA number to indicate why we diverged from Lucene 4.8.0 here.
##########
src/Lucene.Net/Index/TieredMergePolicy.cs:
##########
@@ -412,7 +412,7 @@ public override MergeSpecification FindMerges(MergeTrigger mergeTrigger, Segment
return spec;
}
- if (eligible.Count >= allowedSegCountInt)
+ if (eligible.Count > allowedSegCountInt)
Review Comment:
Please add a comment here with a commit hash and JIRA number to indicate why we diverged from Lucene 4.8.0 here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Backport trivial production fixes from Lucene 4.8.1, #1381 Batch 1 [lucenenet]
Posted by "paulirwin (via GitHub)" <gi...@apache.org>.
paulirwin commented on PR #1413:
URL: https://github.com/apache/lucenenet/pull/1413#issuecomment-4952811451
The OfflineSorter changes were reverted and moved to #1422.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Port trivial production fixes from Lucene 4.8.1, #1381 Batch 1 [lucenenet]
Posted by "paulirwin (via GitHub)" <gi...@apache.org>.
paulirwin commented on code in PR #1413:
URL: https://github.com/apache/lucenenet/pull/1413#discussion_r3890679389
##########
src/Lucene.Net/Index/DocInverterPerField.cs:
##########
@@ -103,11 +103,12 @@ public override void ProcessFields(IIndexableField[] fields, int count)
bool succeededInProcessingField = false;
TokenStream stream = field.GetTokenStream(docState.analyzer);
- // reset the TokenStream to the first token
- stream.Reset();
try
{
+ // reset the TokenStream to the first token
Review Comment:
I don't understand... we're not "diverging from Lucene 4.8.0" per se; we're porting Lucene 4.8.1. This does not diverge from 4.8.1 because it is a 4.8.1 change. See issue #1381. We can fix the library versioning separately before release (i.e. calling it 4.8.1-beta00019 or whatever).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Port trivial production fixes from Lucene 4.8.1, #1381 Batch 1 [lucenenet]
Posted by "paulirwin (via GitHub)" <gi...@apache.org>.
paulirwin commented on code in PR #1413:
URL: https://github.com/apache/lucenenet/pull/1413#discussion_r4254391915
##########
src/Lucene.Net/Index/DocumentsWriterPerThreadPool.cs:
##########
@@ -283,6 +283,9 @@ internal void DeactivateUnreleasedStates()
threadState.Unlock();
}
}
+
+ // In case any threads are waiting for indexing:
+ UninterruptableMonitor.PulseAll(this);
Review Comment:
See other comment; this is retargeting 4.8.1.
##########
src/Lucene.Net/Index/TieredMergePolicy.cs:
##########
@@ -412,7 +412,7 @@ public override MergeSpecification FindMerges(MergeTrigger mergeTrigger, Segment
return spec;
}
- if (eligible.Count >= allowedSegCountInt)
+ if (eligible.Count > allowedSegCountInt)
Review Comment:
See other comment; this is retargeting 4.8.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org