[GitHub] villebro commented on a change in pull request #5222: Downgrade celery and kombu

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #5222: Downgrade celery and kombu
URL: https://github.com/apache/incubator-superset/pull/5222#discussion_r195917845
 
 

 ##########
 File path: requirements.txt
 ##########
 @@ -17,7 +17,7 @@ geopy==1.11.0
 gunicorn==19.8.0
 humanize==0.5.1
 idna==2.6
-kombu==4.1.0
+kombu<4.2
 
 Review comment:
   I removed the line regarding `Kombu` in `requirements.txt`, as I checked that it is only indirectly used via `Celery`. In this case one can think of `Celery 4.1.1` as being broken. As `Kombu` isn't directly specified in `setup.py`, leaving it out of `requirements.txt` feels like the better option as per the initial comment?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org