[GitHub] [spark] cloud-fan commented on a change in pull request #27563: [SPARK-30812][SQL][CORE] Revise boolean config name to comply with new config naming policy

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #27563: [SPARK-30812][SQL][CORE] Revise boolean config name to comply with new config naming policy
URL: https://github.com/apache/spark/pull/27563#discussion_r379236026
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
 ##########
 @@ -143,7 +143,7 @@ package object config {
       .createWithDefault(false)
 
   private[spark] val EVENT_LOG_ALLOW_EC =
-    ConfigBuilder("spark.eventLog.erasureCoding.enabled")
+    ConfigBuilder("spark.eventLog.allowErasureCoding")
 
 Review comment:
   `allow` looks weird, I'd keep this unchanged or `enableErasureCoding`. Do we expect to see more configs starts with `spark.eventLog.erasureCoding`? It seems possible if we want some fine-grained controls over how to do erasure coding.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org