You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by "William A. Rowe, Jr." <wr...@rowe-clan.net> on 2001/03/25 09:11:07 UTC
Living in -r Tags
Sorry, I've been 'away' from the current world a while.
Good news, httpd-2.0 seems to build (one I fixed the cpq6000 to actually compile
things again.)
Bad news - apache-1.3 rotatelogs is now entirely broken, and there is _no_ simple
fix that I can find.
Here's the _minimal_ fix to get things straightened out, AFAICS.
os_stat, spawn* and strftime all need to slide into os.c. In that, we need to
stop using ap_snprintf and use the clib's _snprintf, and kill a stupid assert
sitting in os_stat by using MAX_PATH instead of _MAX_PATH.
Comments? I'd not post if someone has a better fix, but if noone does, this goes
in on Sunday night.
Bill
Re: Living in -r Tags
Posted by Rodent of Unusual Size <Ke...@Golux.Com>.
Bill Stoddard wrote:
>
> So what broke rotatelogs? I presume you mean for Windows.
I think it was the UTC offset and naming patch. It sounds
as though strftime() is not in Windows' default libraries,
or something like that.
--
#ken P-)}
Ken Coar <http://Golux.Com/coar/>
Apache Software Foundation <http://www.apache.org/>
"Apache Server for Dummies" <http://Apache-Server.Com/>
"Apache Server Unleashed" <http://ApacheUnleashed.Com/>
ApacheCon 2001!
Four tracks with over 70+ sessions. Free admission to exhibits
and special events - keynote presentations by John 'maddog' Hall
and David Brin. Special thanks to our Platinum Sponsors IBM and
Covalent, Gold Sponsor Thawte, and Silver Sponsor Compaq. Attend
the only Apache event designed and fully supported by the members of
the ASF. See more information and register at <http://ApacheCon.Com/>!
Re: Living in -r Tags
Posted by Bill Stoddard <bi...@wstoddard.com>.
So what broke rotatelogs? I presume you mean for Windows.
Bill
> Sorry, I've been 'away' from the current world a while.
>
> Good news, httpd-2.0 seems to build (one I fixed the cpq6000 to actually
compile
> things again.)
>
> Bad news - apache-1.3 rotatelogs is now entirely broken, and there is _no_
simple
> fix that I can find.
>
> Here's the _minimal_ fix to get things straightened out, AFAICS.
>
> os_stat, spawn* and strftime all need to slide into os.c. In that, we
need to
> stop using ap_snprintf and use the clib's _snprintf, and kill a stupid
assert
> sitting in os_stat by using MAX_PATH instead of _MAX_PATH.
>
> Comments? I'd not post if someone has a better fix, but if noone does,
this goes
> in on Sunday night.
>
> Bill
>
Re: Living in -r Tags
Posted by "William A. Rowe, Jr." <ad...@rowe-clan.net>.
From: "Rodent of Unusual Size" <Ke...@Golux.Com>
Sent: Sunday, March 25, 2001 8:33 AM
> "William A. Rowe, Jr." wrote:
> >
> > Bad news - apache-1.3 rotatelogs is now entirely broken, and
> > there is _no_ simple fix that I can find.
>
> What is broken about it? Is it a platform-specific breakage?
In a way, yes. rotatelogs.c didn't link in _any_ other modules on
win32. Bringing in the string formatting as you did introduced all
sorts of dependencies upon dependencies. We reimplement stat() and
strfmt() on win32, but relied on other httpd core code to do so!?!
That was the evil, not your patch.
By moving those 'os-extensions' into os.c, we make anyone using 'our'
idea of 1.3 have at those extensions by linking in ApacheOS, as the
patch does for rotatelogs.
> > Comments? I'd not post if someone has a better fix, but if
> > noone does, this goes in on Sunday night.
>
> Hang on, pushing a bunch of stuff into os.c sounds a little
> drastic a change to be given such short notice.. Please hold
> off until there is some discussion.
Exactly. I'm open to discussion, and I'll push this patch by a day
into Monday eve so those with issues (that won't read these posts
till they get into work) can look and comment.
> It is not like we are rolling a 1.3 release to-morrow or anything.
We aren't :-?
Re: Living in -r Tags
Posted by Rodent of Unusual Size <Ke...@Golux.Com>.
"William A. Rowe, Jr." wrote:
>
> Bad news - apache-1.3 rotatelogs is now entirely broken, and
> there is _no_ simple fix that I can find.
What is broken about it? Is it a platform-specific breakage?
> Comments? I'd not post if someone has a better fix, but if
> noone does, this goes in on Sunday night.
Hang on, pushing a bunch of stuff into os.c sounds a little
drastic a change to be given such short notice.. Please hold
off until there is some discussion. It is not like we are
rolling a 1.3 release to-morrow or anything.
--
#ken P-)}
Ken Coar <http://Golux.Com/coar/>
Apache Software Foundation <http://www.apache.org/>
"Apache Server for Dummies" <http://Apache-Server.Com/>
"Apache Server Unleashed" <http://ApacheUnleashed.Com/>
ApacheCon 2001!
Four tracks with over 70+ sessions. Free admission to exhibits
and special events - keynote presentations by John 'maddog' Hall
and David Brin. Special thanks to our Platinum Sponsors IBM and
Covalent, Gold Sponsor Thawte, and Silver Sponsor Compaq. Attend
the only Apache event designed and fully supported by the members of
the ASF. See more information and register at <http://ApacheCon.Com/>!