[GitHub] [maven] rfscholte commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…

[GitBox <gi...@apache.org>]

rfscholte commented on a change in pull request #419:
URL: https://github.com/apache/maven/pull/419#discussion_r549099926



##########
File path: apache-maven/src/assembly/maven/conf/settings.xml
##########
@@ -244,6 +244,35 @@ under the License.
       </properties>
     </profile>
     -->
+    <profile>
+      <activation>

Review comment:
       To me we're now abusing a profile because it is not yet possible to specify these at a higher level.  The `default` profile could contain much more.

##########
File path: maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java
##########
@@ -573,15 +573,6 @@ else if ( Artifact.SCOPE_COMPILE.equals( scope ) && Artifact.SCOPE_COMPILE.equal
     // Code taken from LegacyRepositorySystem
     //
 
-    public ArtifactRepository createDefaultRemoteRepository( MavenExecutionRequest request )

Review comment:
       I don't know where this code is used, but it is public and I think this class is accessible by all plugins.

##########
File path: apache-maven/src/assembly/maven/conf/settings.xml
##########
@@ -244,6 +244,35 @@ under the License.
       </properties>
     </profile>
     -->
+    <profile>
+      <activation>
+        <activeByDefault>true</activeByDefault>

Review comment:
       Here's the real issue. This means: activate if no other profiles are being activated. So if I run `mvn -P my-profile`, this one will be disabled, meaning we won't have remote repoitories.
   
   The proper way to activate is by using `<activeProfiles>`. Again a sign to me we need to change the settings.xml




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org