You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "arturobernalg (via GitHub)" <gi...@apache.org> on 2026/09/28 12:51:42 UTC
[PR] Optimize HPACK full match lookup [httpcomponents-core]
arturobernalg opened a new pull request, #706:
URL: https://github.com/apache/httpcomponents-core/pull/706
Avoid indexed access when traversing dynamic table entries. Use sequential iteration for linked lists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: [PR] Optimize HPACK full match lookup [httpcomponents-core]
Posted by "arturobernalg (via GitHub)" <gi...@apache.org>.
arturobernalg merged PR #706:
URL: https://github.com/apache/httpcomponents-core/pull/706
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: [PR] Optimize HPACK full match lookup [httpcomponents-core]
Posted by "arturobernalg (via GitHub)" <gi...@apache.org>.
arturobernalg commented on code in PR #706:
URL: https://github.com/apache/httpcomponents-core/pull/706#discussion_r4123104825
##########
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/hpack/HPackEncoder.java:
##########
@@ -259,8 +259,7 @@ private int findFullMatch(final List<HPackEntry> entries, final String value) {
if (entries == null || entries.isEmpty()) {
return 0;
}
- for (int i = 0; i < entries.size(); i++) {
- final HPackEntry entry = entries.get(i);
+ for (final HPackEntry entry : entries) {
Review Comment:
> Does this use `Iterator` underneath? Can we make it explicit?
@ok2c Yes, the enhanced for-loop uses an Iterator underneath. changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: [PR] Optimize HPACK full match lookup [httpcomponents-core]
Posted by "ok2c (via GitHub)" <gi...@apache.org>.
ok2c commented on code in PR #706:
URL: https://github.com/apache/httpcomponents-core/pull/706#discussion_r4122497801
##########
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/hpack/HPackEncoder.java:
##########
@@ -259,8 +259,7 @@ private int findFullMatch(final List<HPackEntry> entries, final String value) {
if (entries == null || entries.isEmpty()) {
return 0;
}
- for (int i = 0; i < entries.size(); i++) {
- final HPackEntry entry = entries.get(i);
+ for (final HPackEntry entry : entries) {
Review Comment:
@arturobernalg Does this use `Iterator` underneath? Can we make it explicit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org