[jira] [Commented] (FLINK-7372) Remove ActorGateway from JobGraph

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115819#comment-16115819 ] 

ASF GitHub Bot commented on FLINK-7372:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/4483

    [FLINK-7372] [JobGraph] Remove ActorGateway from JobGraph

    ## What is the purpose of the change
    
    The JobGraph has an unncessary dependency on the ActorGateway via its JobGraph#uploadUserJars method. In order to get rid of this dependency for future Flip-6 changes, this commit retrieves the BlobServer's address beforehand and directly passes it to this method as a `InetSocketAddress` instance.
    
    ## Brief change log
    
    - Introduce `JobClient#retrieveBlobServerAddress` method which retrieves from the given `ActorGateway` the `BlobServer` address
    - First retrieve `BlobServer` address using the aforementioned method wherever the `ActorGateway` was passed to the `JobGraph`
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink removeActorGateways

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4483.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4483
    
----
commit 52bf22d5b9b5893e3425c963e5516c1cef5e2938
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-08-04T22:28:15Z

    [FLINK-7372] [JobGraph] Remove ActorGateway from JobGraph
    
    The JobGraph has an unncessary dependency on the ActorGateway via its JobGraph#uploadUserJars method. In
    order to get rid of this dependency for future Flip-6 changes, this commit retrieves the BlobServer's
    address beforehand and directly passes it to this method.

----


> Remove ActorGateway from JobGraph
> ---------------------------------
>
>                 Key: FLINK-7372
>                 URL: https://issues.apache.org/jira/browse/FLINK-7372
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Coordination
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>
> As a preliminary step for easier Flip-6 integration we should try to decouple as many components from the underlying RPC abstraction as possible. One of these components is the {{JobGraph}} which has a dependency on {{ActorGateway}} via its {{JobGraph#uploadUserJars}} method.
> I propose to get rid of the {{ActorGateway}} parameter and passing instead the BlobServer's address as an {{InetSocketAddress}} instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)