You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@netbeans.apache.org by geertjanw <gi...@git.apache.org> on 2017/10/08 09:18:50 UTC

[GitHub] incubator-netbeans pull request #95: [NETBEANS-54] Module Review apisupport....

GitHub user geertjanw opened a pull request:

    https://github.com/apache/incubator-netbeans/pull/95

    [NETBEANS-54] Module Review apisupport.ant

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/geertjanw/incubator-netbeans netbeans-54-review-apisupport.ant

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-netbeans/pull/95.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #95
    
----
commit 06da98868310183b783644233c213a2349d689fe
Author: geertjan <ge...@oracle.com>
Date:   2017-10-08T09:18:22Z

    [NETBEANS-54] Module Review apisupport.ant

----


---

[GitHub] incubator-netbeans issue #95: [NETBEANS-54] Module Review apisupport.ant

Posted by matthiasblaesing <gi...@git.apache.org>.

Github user matthiasblaesing commented on the issue:

    https://github.com/apache/incubator-netbeans/pull/95
  
    The situation is already there. With or without Geertjans work a potential automatic system needs to detect present licenses, and if it decided, that the headers are not needed, they are not wrong either (Asuming they don't break tests/functionality). I don't see why we would rip out license headers, that are correct and don't interfere with functions/tests.
    



---

[GitHub] incubator-netbeans issue #95: [NETBEANS-54] Module Review apisupport.ant

Posted by geertjanw <gi...@git.apache.org>.

Github user geertjanw commented on the issue:

    https://github.com/apache/incubator-netbeans/pull/95
  
    Agree with this, i.e., whether we decide to add them for all of these throughout or not, the fact that these specific ones in this module already have them, now that I've added them manually, shouldn't be a problem and we should merge this PR from my point of view.


---

[GitHub] incubator-netbeans issue #95: [NETBEANS-54] Module Review apisupport.ant

Posted by emilianbold <gi...@git.apache.org>.

Github user emilianbold commented on the issue:

    https://github.com/apache/incubator-netbeans/pull/95
  
    > Yes, though did them just to get it done.
    
    But if the conclusion is that these should *not* have headers, we'll have to go back and delete them.


---

[GitHub] incubator-netbeans issue #95: [NETBEANS-54] Module Review apisupport.ant

Posted by geertjanw <gi...@git.apache.org>.

Github user geertjanw commented on the issue:

    https://github.com/apache/incubator-netbeans/pull/95
  
    OK.


---

[GitHub] incubator-netbeans issue #95: [NETBEANS-54] Module Review apisupport.ant

Posted by geertjanw <gi...@git.apache.org>.

Github user geertjanw commented on the issue:

    https://github.com/apache/incubator-netbeans/pull/95
  
    OK, we should decide on that first and until then not merge this PR.


---

[GitHub] incubator-netbeans issue #95: [NETBEANS-54] Module Review apisupport.ant

Posted by matthiasblaesing <gi...@git.apache.org>.

Github user matthiasblaesing commented on the issue:

    https://github.com/apache/incubator-netbeans/pull/95
  
    @geertjanw please close this PR, the changeset was also part of #96 and the changes are thus merged already.


---

[GitHub] incubator-netbeans issue #95: [NETBEANS-54] Module Review apisupport.ant

Posted by emilianbold <gi...@git.apache.org>.

Github user emilianbold commented on the issue:

    https://github.com/apache/incubator-netbeans/pull/95
  
    Arent't lots of these "Problems to be solved centrally"?


---