You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2010/03/23 20:26:27 UTC
[jira] Created: (MAPREDUCE-1621) Streaming's
TextOutputReader.getLastOutput throws NPE if it has never read any output
Streaming's TextOutputReader.getLastOutput throws NPE if it has never read any output
-------------------------------------------------------------------------------------
Key: MAPREDUCE-1621
URL: https://issues.apache.org/jira/browse/MAPREDUCE-1621
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: contrib/streaming
Affects Versions: 0.20.2, 0.21.0, 0.22.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
If TextOutputReader.readKeyValue() has never successfully read a line, then its bytes member will be left null. Thus when logging a task failure, PipeMapRed.getContext() can trigger an NPE when it calls outReader_.getLastOutput().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1621) Streaming's
TextOutputReader.getLastOutput throws NPE if it has never read any output
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888319#action_12888319 ]
Hadoop QA commented on MAPREDUCE-1621:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12449214/patch-1621.txt
against trunk revision 962682.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/597/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/597/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/597/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/597/console
This message is automatically generated.
> Streaming's TextOutputReader.getLastOutput throws NPE if it has never read any output
> -------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1621
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1621
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/streaming
> Affects Versions: 0.21.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: patch-1621.txt
>
>
> If TextOutputReader.readKeyValue() has never successfully read a line, then its bytes member will be left null. Thus when logging a task failure, PipeMapRed.getContext() can trigger an NPE when it calls outReader_.getLastOutput().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1621) Streaming's
TextOutputReader.getLastOutput throws NPE if it has never read any output
Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ravi Gummadi updated MAPREDUCE-1621:
------------------------------------
Status: Patch Available (was: Open)
> Streaming's TextOutputReader.getLastOutput throws NPE if it has never read any output
> -------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1621
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1621
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/streaming
> Affects Versions: 0.21.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: patch-1621.txt
>
>
> If TextOutputReader.readKeyValue() has never successfully read a line, then its bytes member will be left null. Thus when logging a task failure, PipeMapRed.getContext() can trigger an NPE when it calls outReader_.getLastOutput().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1621) Streaming's
TextOutputReader.getLastOutput throws NPE if it has never read any output
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated MAPREDUCE-1621:
-----------------------------------------------
Status: Open (was: Patch Available)
Many tests failed because of NoClassDefFoundError. Re-submitting to hudson
> Streaming's TextOutputReader.getLastOutput throws NPE if it has never read any output
> -------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1621
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1621
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/streaming
> Affects Versions: 0.21.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: patch-1621.txt
>
>
> If TextOutputReader.readKeyValue() has never successfully read a line, then its bytes member will be left null. Thus when logging a task failure, PipeMapRed.getContext() can trigger an NPE when it calls outReader_.getLastOutput().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1621) Streaming's
TextOutputReader.getLastOutput throws NPE if it has never read any output
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated MAPREDUCE-1621:
-----------------------------------------------
Status: Patch Available (was: Open)
> Streaming's TextOutputReader.getLastOutput throws NPE if it has never read any output
> -------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1621
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1621
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/streaming
> Affects Versions: 0.21.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: patch-1621.txt
>
>
> If TextOutputReader.readKeyValue() has never successfully read a line, then its bytes member will be left null. Thus when logging a task failure, PipeMapRed.getContext() can trigger an NPE when it calls outReader_.getLastOutput().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1621) Streaming's
TextOutputReader.getLastOutput throws NPE if it has never read any output
Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889127#action_12889127 ]
Ravi Gummadi commented on MAPREDUCE-1621:
-----------------------------------------
Patch looks good.
+1
> Streaming's TextOutputReader.getLastOutput throws NPE if it has never read any output
> -------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1621
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1621
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/streaming
> Affects Versions: 0.21.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: patch-1621.txt
>
>
> If TextOutputReader.readKeyValue() has never successfully read a line, then its bytes member will be left null. Thus when logging a task failure, PipeMapRed.getContext() can trigger an NPE when it calls outReader_.getLastOutput().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1621) Streaming's
TextOutputReader.getLastOutput throws NPE if it has never read any output
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated MAPREDUCE-1621:
-----------------------------------------------
Status: Resolved (was: Patch Available)
Hadoop Flags: [Reviewed]
Assignee: Amareshwari Sriramadasu (was: Todd Lipcon)
Resolution: Fixed
I just committed this.
> Streaming's TextOutputReader.getLastOutput throws NPE if it has never read any output
> -------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1621
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1621
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/streaming
> Affects Versions: 0.21.0
> Reporter: Todd Lipcon
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.22.0
>
> Attachments: patch-1621.txt
>
>
> If TextOutputReader.readKeyValue() has never successfully read a line, then its bytes member will be left null. Thus when logging a task failure, PipeMapRed.getContext() can trigger an NPE when it calls outReader_.getLastOutput().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1621) Streaming's
TextOutputReader.getLastOutput throws NPE if it has never read any output
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889085#action_12889085 ]
Amareshwari Sriramadasu commented on MAPREDUCE-1621:
----------------------------------------------------
Seems hudson is not picking up submitted patches, I ran test-patch and ant test on my machine. All tests passed except the known failures in trunk (MAPREDUCE-1834 and MAPREDUCE-1925).
> Streaming's TextOutputReader.getLastOutput throws NPE if it has never read any output
> -------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1621
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1621
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/streaming
> Affects Versions: 0.21.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: patch-1621.txt
>
>
> If TextOutputReader.readKeyValue() has never successfully read a line, then its bytes member will be left null. Thus when logging a task failure, PipeMapRed.getContext() can trigger an NPE when it calls outReader_.getLastOutput().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1621) Streaming's
TextOutputReader.getLastOutput throws NPE if it has never read any output
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12926142#action_12926142 ]
Hudson commented on MAPREDUCE-1621:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See [https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/])
> Streaming's TextOutputReader.getLastOutput throws NPE if it has never read any output
> -------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1621
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1621
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/streaming
> Affects Versions: 0.21.0
> Reporter: Todd Lipcon
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.22.0
>
> Attachments: patch-1621.txt
>
>
> If TextOutputReader.readKeyValue() has never successfully read a line, then its bytes member will be left null. Thus when logging a task failure, PipeMapRed.getContext() can trigger an NPE when it calls outReader_.getLastOutput().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1621) Streaming's
TextOutputReader.getLastOutput throws NPE if it has never read any output
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated MAPREDUCE-1621:
-----------------------------------------------
Status: Patch Available (was: Open)
Affects Version/s: (was: 0.22.0)
(was: 0.20.2)
Fix Version/s: 0.22.0
> Streaming's TextOutputReader.getLastOutput throws NPE if it has never read any output
> -------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1621
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1621
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/streaming
> Affects Versions: 0.21.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: patch-1621.txt
>
>
> If TextOutputReader.readKeyValue() has never successfully read a line, then its bytes member will be left null. Thus when logging a task failure, PipeMapRed.getContext() can trigger an NPE when it calls outReader_.getLastOutput().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1621) Streaming's
TextOutputReader.getLastOutput throws NPE if it has never read any output
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated MAPREDUCE-1621:
-----------------------------------------------
Attachment: patch-1621.txt
Here is a patch fixing the NPE.
Currently, NPE can be see from TestStreamingBadRecords logs. After the fix, I don't see the NPE.
> Streaming's TextOutputReader.getLastOutput throws NPE if it has never read any output
> -------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1621
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1621
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/streaming
> Affects Versions: 0.21.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: patch-1621.txt
>
>
> If TextOutputReader.readKeyValue() has never successfully read a line, then its bytes member will be left null. Thus when logging a task failure, PipeMapRed.getContext() can trigger an NPE when it calls outReader_.getLastOutput().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1621) Streaming's
TextOutputReader.getLastOutput throws NPE if it has never read any output
Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ravi Gummadi updated MAPREDUCE-1621:
------------------------------------
Status: Open (was: Patch Available)
> Streaming's TextOutputReader.getLastOutput throws NPE if it has never read any output
> -------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1621
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1621
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/streaming
> Affects Versions: 0.21.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: patch-1621.txt
>
>
> If TextOutputReader.readKeyValue() has never successfully read a line, then its bytes member will be left null. Thus when logging a task failure, PipeMapRed.getContext() can trigger an NPE when it calls outReader_.getLastOutput().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.