You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2018/11/08 12:29:52 UTC

[GitHub] vvysotskyi opened a new pull request #1528: DRILL-3610: Fix TIMESTAMPADD and TIMESTAMPDIFF functions

vvysotskyi opened a new pull request #1528: DRILL-3610: Fix TIMESTAMPADD and TIMESTAMPDIFF functions
URL: https://github.com/apache/drill/pull/1528
 
 
   - Added type inference for TIMESTAMPADD function to avoid failures for the cases when function types are checked for expressions before and after rewriting.
   
   - Added custom convertlet for TIMESTAMPDIFF function to avoid rewriting it by Calcite, since Drill does not support Reinterpret function and does not handle all Calcite interval representations correctly.
   
   - Added UDFs for TIMESTAMPDIFF for all supported time units. The mechanism is similar to the existing EXTRACT function: when Calcite RexCall is converted to the Drill LogicalExpression, a function name is changed to timestampdiffSecond or similar one depending on the specified time unit.
   
   For problem description please see [DRILL-3610](https://issues.apache.org/jira/browse/DRILL-3610).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services