You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2022/08/22 19:04:11 UTC
[GitHub] [mynewt-nimble] andrzej-kaczmarek opened a new pull request, #1332: nimble/ll: Fix aux scan timing
andrzej-kaczmarek opened a new pull request, #1332:
URL: https://github.com/apache/mynewt-nimble/pull/1332
We should include clock drift due to sleep clock accuracy and jitter
when calculating aux scan start time (Core 5.3, Vol 6, Part B, 4.2.2).
Slot duration calculation should also include the above and possible
drift due to offset accuracy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #1332: nimble/ll: Fix aux scan timing
Posted by "andrzej-kaczmarek (via GitHub)" <gi...@apache.org>.
andrzej-kaczmarek merged PR #1332:
URL: https://github.com/apache/mynewt-nimble/pull/1332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on pull request #1332: nimble/ll: Fix aux scan timing
Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek commented on PR #1332:
URL: https://github.com/apache/mynewt-nimble/pull/1332#issuecomment-1225337354
rebased on top of https://github.com/apache/mynewt-nimble/pull/1333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1332: nimble/ll: Fix aux scan timing
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1332:
URL: https://github.com/apache/mynewt-nimble/pull/1332#issuecomment-1232264976
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1332: nimble/ll: Fix aux scan timing
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1332:
URL: https://github.com/apache/mynewt-nimble/pull/1332#issuecomment-1232060184
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/controller/src/ble_ll_scan_aux.c
<details>
```diff
@@ -701,7 +701,7 @@
#endif
#if MYNEWT_VAL(BLE_LL_CFG_FEAT_LE_CODED_PHY)
case 2:
- *phy = BLE_PHY_CODED;
+ *phy = BLE_PHY_CODED;
break;
#endif
default:
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1332: nimble/ll: Fix aux scan timing
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1332:
URL: https://github.com/apache/mynewt-nimble/pull/1332#issuecomment-1225643457
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/controller/src/ble_ll_adv.c
<details>
```diff
@@ -1401,7 +1400,7 @@
* TargetA is included in AUX_ADV_IND which is in that case calculated in
* ble_ll_adv_aux_schedule_first().
*/
- if (first_pdu &&
+ if (first_pdu &&
(props & BLE_HCI_LE_SET_EXT_ADV_PROP_DIRECTED) &&
!(props & BLE_HCI_LE_SET_EXT_ADV_PROP_SCANNABLE)) {
ext_hdr_flags |= (1 << BLE_LL_EXT_ADV_TARGETA_BIT);
@@ -2336,20 +2335,20 @@
/* AuxPtr if there are more AdvData remaining that we can fit here */
if ((rem_data_len > sync->data_len)) {
- /* adjust for flags that needs to be added if AuxPtr is only field
- * in Extended Header
- */
- if (!sync->ext_hdr_flags) {
- ext_hdr_len += BLE_LL_EXT_ADV_FLAGS_SIZE;
- sync->data_len -= BLE_LL_EXT_ADV_FLAGS_SIZE;
- }
-
- sync->ext_hdr_flags |= (1 << BLE_LL_EXT_ADV_AUX_PTR_BIT);
+ /* adjust for flags that needs to be added if AuxPtr is only field
+ * in Extended Header
+ */
+ if (!sync->ext_hdr_flags) {
+ ext_hdr_len += BLE_LL_EXT_ADV_FLAGS_SIZE;
+ sync->data_len -= BLE_LL_EXT_ADV_FLAGS_SIZE;
+ }
+
+ sync->ext_hdr_flags |= (1 << BLE_LL_EXT_ADV_AUX_PTR_BIT);
ext_hdr_len += BLE_LL_EXT_ADV_AUX_PTR_SIZE;
- sync->data_len -= BLE_LL_EXT_ADV_AUX_PTR_SIZE;
-
- /* PDU payload should be full if chained */
- BLE_LL_ASSERT(ext_hdr_len + sync->data_len == BLE_LL_MAX_PAYLOAD_LEN);
+ sync->data_len -= BLE_LL_EXT_ADV_AUX_PTR_SIZE;
+
+ /* PDU payload should be full if chained */
+ BLE_LL_ASSERT(ext_hdr_len + sync->data_len == BLE_LL_MAX_PAYLOAD_LEN);
}
sync->payload_len = ext_hdr_len + sync->data_len;
```
</details>
#### nimble/controller/src/ble_ll_scan_aux.c
<details>
```diff
@@ -701,7 +701,7 @@
#endif
#if MYNEWT_VAL(BLE_LL_CFG_FEAT_LE_CODED_PHY)
case 2:
- *phy = BLE_PHY_CODED;
+ *phy = BLE_PHY_CODED;
break;
#endif
default:
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1332: nimble/ll: Fix aux scan timing
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1332:
URL: https://github.com/apache/mynewt-nimble/pull/1332#issuecomment-1222953257
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] andrzej-kaczmarek closed pull request #1332: nimble/ll: Fix aux scan timing
Posted by "andrzej-kaczmarek (via GitHub)" <gi...@apache.org>.
andrzej-kaczmarek closed pull request #1332: nimble/ll: Fix aux scan timing
URL: https://github.com/apache/mynewt-nimble/pull/1332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org