You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by yu-iskw <gi...@git.apache.org> on 2015/10/21 01:01:11 UTC

[GitHub] spark pull request: [SPARK-10266][Documentation, ML] Fixed @Since ...

Github user yu-iskw commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8729#discussion_r42566036
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/GBTRegressor.scala ---
    @@ -153,20 +158,21 @@ object GBTRegressor {
      * @param _trees  Decision trees in the ensemble.
      * @param _treeWeights  Weights for the decision trees in the ensemble.
      */
    +@Since("1.4.0")
     @Experimental
    -final class GBTRegressionModel(
    -    override val uid: String,
    -    private val _trees: Array[DecisionTreeRegressionModel],
    -    private val _treeWeights: Array[Double])
    +final class GBTRegressionModel @Since("1.4.0") (
    +                                                 @Since("1.4.0") override val uid: String,
    +                                                 private val _trees: Array[DecisionTreeRegressionModel],
    +                                                 private val _treeWeights: Array[Double])
    --- End diff --
    
    Fix the indentations for the parameters. There is no problem about the `@Since` tag.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org