You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "X-LightYear (via GitHub)" <gi...@apache.org> on 2026/09/23 08:30:21 UTC
[PR] feat(studio): expose ACL user updates through MCP [rocketmq-dashboard]
X-LightYear opened a new pull request, #5022:
URL: https://github.com/apache/rocketmq-dashboard/pull/5022
## Summary
- expose the existing ACL user update lifecycle through MCP
- reuse `AclService.updateUser` for Apache and Tencent provider paths
- add deterministic coverage for partial updates, credential-free output, Tencent role identifiers, and catalog authorization
## Existing capability
The REST endpoint `/api/acl/users/update`, `AclService.updateUser`, `TencentAclService.updateUser`, and the Studio ACL user editor already support this operation. The MCP catalog previously exposed user list/get/create/delete, but not update.
## Fix
Add `rmq.user.update` as an L3 `acl:write` mutation. It accepts the existing editor fields `id`, `username`, `admin`, and `clusters`; omitted fields preserve their current values. The handler reuses `AclService.updateUser`, uses the existing confirmation/dry-run mutation filter, and projects the result through `AclUserItem`, so credentials are not returned.
The tool requires `ACL_MANAGEMENT` only. Tencent cloud instances expose ACL management without `REMOTING`, and the existing service delegates role updates through the cloud provider path.
The result schema permits a missing numeric `id` for current Tencent role representations; this does not modify the separate stable-identifier work in #5012/#5013.
## Testing
- `UserUpdateToolHandlerTest`: 3 passed
- MCP catalog/registration/output contract suite: 46 passed
- ACL service/provider/controller suite: 122 passed
- checkstyle: 0 violations
- `mvn -B -ntp -Dmaven.compiler.proc=full -Dmaven.antrun.skip=true -DskipTests package`: passed
Fixes #5021
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(studio): expose ACL user updates through MCP [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #5022: feat(studio): expose ACL user updates through MCP
URL: https://github.com/apache/rocketmq-dashboard/pull/5022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(studio): expose ACL user updates through MCP [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5022:
URL: https://github.com/apache/rocketmq-dashboard/pull/5022#issuecomment-6115553596
This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(studio): expose ACL user updates through MCP [rocketmq-dashboard]
Posted by "X-LightYear (via GitHub)" <gi...@apache.org>.
X-LightYear commented on PR #5022:
URL: https://github.com/apache/rocketmq-dashboard/pull/5022#issuecomment-5931141976
Coordination note for #5013: the stable-ID fix has now been updated on the `rocketmq-studio` branch so Tencent ACL users project `username` as MCP `id`, and Tencent ACL rules project `principal` as MCP `id`; numeric/local IDs remain unchanged. #5022 currently contains `TencentRoleOutputShouldSatisfySchemaWithoutNumericId` with `result.id() == null` and a workaround schema that permits a missing id. Please keep #5022 code unchanged for now, but after #5013 merges, rebase it and remove that null-id expectation/workaround rather than duplicating the stable-ID implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org