You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by tinkoff-dwh <gi...@git.apache.org> on 2017/07/13 06:18:29 UTC
[GitHub] zeppelin pull request #2490: Zeppelin 2718 Find and replace code in note
GitHub user tinkoff-dwh opened a pull request:
https://github.com/apache/zeppelin/pull/2490
Zeppelin 2718 Find and replace code in note
### What is this PR for?
Add feature for find and replace code in all paragraphs of note
### What type of PR is it?
[Feature]
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2718
### How should this be tested?
Try to find and replace code in note (with help of search element)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-2718
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2490.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2490
----
commit 3d77d72dda03a1da3aec1c5a67618f7275e6d531
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-07-11T11:48:42Z
add find implementation
commit d89ffe2b505127e790e32553e91fa3a5192859f6
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-07-12T08:59:44Z
add replace implementation
commit 52d14a93fbbf77b12b59553034c84ff55c8bcc7b
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-07-12T11:53:28Z
add find/replace dropdown
commit 06a74b2f4b16dbbdc2fe9cfc1ebe5a122b6ec4bd
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-07-12T13:45:25Z
add tooltip, fix search spaces
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2490: [Zeppelin-2718] Find and replace code in note
Posted by tinkoff-dwh <gi...@git.apache.org>.
GitHub user tinkoff-dwh reopened a pull request:
https://github.com/apache/zeppelin/pull/2490
[Zeppelin-2718] Find and replace code in note
### What is this PR for?
Add feature for find and replace code in all paragraphs of note
### What type of PR is it?
[Feature]
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2718
### How should this be tested?
Try to find and replace code in note (with help of search element)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-2718
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2490.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2490
----
commit f269b8aa79268d47c4baf1a5c2e3a4d681eb1354
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-07-18T11:20:05Z
add find and replace feature
commit 9c662b4f7f2da68f2775f56f4e49f57fabfab14e
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-07-19T13:49:52Z
add matches count
commit 8c163d82106a2a86f18aee4b16bdace5efc63d8a
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-07-20T06:12:11Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2718
# Conflicts:
# zeppelin-web/src/app/notebook/notebook.controller.js
commit 7f524ae3e5b006ced5063e85d7b744e85c3188ca
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-07-21T12:03:40Z
add e2e tests
commit a0cd3b1d64488f0493fc281c7d97ccaf81c57ccc
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-07-24T08:05:15Z
add shortcut
commit 8808b7bc23a8fdfa4a145b078a9368e240d5c6ab
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-07-24T08:27:45Z
fix borders
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2490: [Zeppelin-2718] Find and replace code in note
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2490
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2490: [Zeppelin-2718] Find and replace code in note
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh closed the pull request at:
https://github.com/apache/zeppelin/pull/2490
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2490: [Zeppelin-2718] Find and replace code in note
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2490
LGTM merge if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2490: [Zeppelin-2718] Find and replace code in note
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2490
@tinkoff-dwh It's the default binding in emacs mode.
## in default modes
https://github.com/ajaxorg/ace/wiki/Default-Keyboard-Shortcuts
# in emacs mode
https://github.com/ajaxorg/ace/blob/master/lib/ace/keyboard/emacs.js#L363
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2490: [Zeppelin-2718] Find and replace code in note
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh closed the pull request at:
https://github.com/apache/zeppelin/pull/2490
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2490: [Zeppelin-2718] Find and replace code in note
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2490
Ready to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2490: [Zeppelin-2718] Find and replace code in note
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2490
@1ambda
Ready to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2490: [Zeppelin-2718] Find and replace code in note
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2490
@tinkoff-dwh Thank you for the update.
1. Can we add the shortcut into
2. Can we use more thin border color?
Sorry for the late feedback.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2490: [Zeppelin-2718] Find and replace code in note
Posted by tinkoff-dwh <gi...@git.apache.org>.
GitHub user tinkoff-dwh reopened a pull request:
https://github.com/apache/zeppelin/pull/2490
[Zeppelin-2718] Find and replace code in note
### What is this PR for?
Add feature for find and replace code in all paragraphs of note
### What type of PR is it?
[Feature]
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2718
### How should this be tested?
Try to find and replace code in note (with help of search element)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-2718
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2490.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2490
----
commit f269b8aa79268d47c4baf1a5c2e3a4d681eb1354
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-07-18T11:20:05Z
add find and replace feature
commit 9c662b4f7f2da68f2775f56f4e49f57fabfab14e
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-07-19T13:49:52Z
add matches count
commit 8c163d82106a2a86f18aee4b16bdace5efc63d8a
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-07-20T06:12:11Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2718
# Conflicts:
# zeppelin-web/src/app/notebook/notebook.controller.js
commit 7f524ae3e5b006ced5063e85d7b744e85c3188ca
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-07-21T12:03:40Z
add e2e tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2490: [Zeppelin-2718] Find and replace code in note
Posted by tinkoff-dwh <gi...@git.apache.org>.
GitHub user tinkoff-dwh reopened a pull request:
https://github.com/apache/zeppelin/pull/2490
[Zeppelin-2718] Find and replace code in note
### What is this PR for?
Add feature for find and replace code in all paragraphs of note
### What type of PR is it?
[Feature]
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2718
### How should this be tested?
Try to find and replace code in note (with help of search element)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-2718
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2490.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2490
----
commit f269b8aa79268d47c4baf1a5c2e3a4d681eb1354
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-07-18T11:20:05Z
add find and replace feature
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2490: [Zeppelin-2718] Find and replace code in note
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2490
@1ambda
Added tests, search result count, `Ctrl-F` shortcut and move cursor by enter
Ready to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2490: [Zeppelin-2718] Find and replace code in note
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2490
Thanks for implementing such a great feature!
1. Could you rebase against the current master? Since filenames were changes, it would be easier to review after rebasing
2. Regarding UX
- It would be nice to provide shortcut to trigger this feature (overriding `CTRL+F`, `CMD+F` or using a different key)
- It would be great if cursor move to the next search result if I stroke `enter` key like other editor do.
- Can we provide the search result count? (refer the screenshot)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2490: [Zeppelin-2718] Find and replace code in note
Posted by tinkoff-dwh <gi...@git.apache.org>.
GitHub user tinkoff-dwh reopened a pull request:
https://github.com/apache/zeppelin/pull/2490
[Zeppelin-2718] Find and replace code in note
### What is this PR for?
Add feature for find and replace code in all paragraphs of note
### What type of PR is it?
[Feature]
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2718
### How should this be tested?
Try to find and replace code in note (with help of search element)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-2718
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2490.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2490
----
commit f269b8aa79268d47c4baf1a5c2e3a4d681eb1354
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-07-18T11:20:05Z
add find and replace feature
commit 9c662b4f7f2da68f2775f56f4e49f57fabfab14e
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-07-19T13:49:52Z
add matches count
commit 8c163d82106a2a86f18aee4b16bdace5efc63d8a
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-07-20T06:12:11Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2718
# Conflicts:
# zeppelin-web/src/app/notebook/notebook.controller.js
commit 7f524ae3e5b006ced5063e85d7b744e85c3188ca
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-07-21T12:03:40Z
add e2e tests
commit a0cd3b1d64488f0493fc281c7d97ccaf81c57ccc
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-07-24T08:05:15Z
add shortcut
commit 8808b7bc23a8fdfa4a145b078a9368e240d5c6ab
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-07-24T08:27:45Z
fix borders
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2490: [Zeppelin-2718] Find and replace code in note
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2490
@1ambda
Shortcut added, borders width reduced
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2490: [Zeppelin-2718] Find and replace code in note
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2490
@1ambda
I have not found any command to which `Ctrl-F` is bounded in List of shortcut or in code. Could you give a link?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2490: [Zeppelin-2718] Find and replace code in note
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2490
Ready to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2490: [Zeppelin-2718] Find and replace code in note
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2490
@tinkoff-dwh
1. I realized that `CTRL+F` is bound to `Moving cursor` in paragraphs. Can we use `CTRL + OPT + F` (`ALT` in case of windows OS) or another key what you think better
2. If you change browser size, can't see other buttons like `<`, `replace` and so on. Could you move the find and replace dialog?
(I used the half-sized browser)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2490: [Zeppelin-2718] Find and replace code in note
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh closed the pull request at:
https://github.com/apache/zeppelin/pull/2490
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2490: [Zeppelin-2718] Find and replace code in note
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh closed the pull request at:
https://github.com/apache/zeppelin/pull/2490
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---