[GitHub] adriancole commented on a change in pull request #432: Bumps to latest Brave dependencies

[GitBox <gi...@apache.org>]

adriancole commented on a change in pull request #432: Bumps to latest Brave dependencies
URL: https://github.com/apache/cxf/pull/432#discussion_r206505725
 
 

 ##########
 File path: osgi/karaf/features/src/main/resources/features.xml
 ##########
 @@ -294,8 +294,8 @@
     <feature name="cxf-tracing-brave" version="${project.version}">
         <feature version="${project.version}">cxf-core</feature>
         <bundle start-level="10" dependency="true">mvn:com.google.code.findbugs/jsr305/${cxf.findbugs.version}</bundle>
-        <bundle start-level="35">mvn:io.zipkin.java/zipkin/${cxf.brave.zipkin.version}</bundle>
-        <bundle start-level="35">mvn:io.zipkin.reporter/zipkin-reporter/${cxf.brave.reporter.version}</bundle>
+        <bundle start-level="35">mvn:io.zipkin.zipkin2/zipkin/${cxf.brave.zipkin.version}</bundle>
+        <bundle start-level="35">mvn:io.zipkin.reporter2/zipkin-reporter/${cxf.brave.reporter.version}</bundle>
 
 Review comment:
   ps do we need to claim all of these deps in the bundle? or just the top-level (brave)? Seems to add maintenance to have to add each independently, but I don't really know what is required

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services