You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by kxepal <gi...@git.apache.org> on 2014/08/25 17:09:43 UTC
[GitHub] couchdb-fauxton pull request: Fix align for active tasks progress ...
GitHub user kxepal opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/42
Fix align for active tasks progress bar and button
Before:
After:
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kxepal/couchdb-fauxton patch-4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/42.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #42
----
commit a59767f7599e79253c96b565eba8a358428a9b6f
Author: Alexander Shorin <kx...@apache.org>
Date: 2014-08-25T15:07:37Z
Fix align for active tasks progress bar and button
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Fix align for active tasks progress ...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/42#issuecomment-53422523
@garrensmith oh, right, forgot to remove.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Fix align for active tasks progress ...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/42#issuecomment-53447976
Thanks @kxepal, this has been merged in. You can close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Fix align for active tasks progress ...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/42#issuecomment-53398619
PR Updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Fix align for active tasks progress ...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/42
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Fix align for active tasks progress ...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/42#discussion_r16696654
--- Diff: assets/less/bootstrap/progress-bars.less ---
@@ -57,7 +57,8 @@
height: 100%;
color: @white;
float: left;
- font-size: 12px;
+ font-size: 16px;
+ line-height: 30px;
--- End diff --
Oh, so I was too close (: Thanks, will pick this then,
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Fix align for active tasks progress ...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/42#issuecomment-53416943
@kxepal this PR is not picking up the change. This patch still changes bootstrap/pogress-bars.less
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Fix align for active tasks progress ...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/42#discussion_r16678197
--- Diff: assets/less/bootstrap/progress-bars.less ---
@@ -57,7 +57,8 @@
height: 100%;
color: @white;
float: left;
- font-size: 12px;
+ font-size: 16px;
+ line-height: 30px;
--- End diff --
This patches the external dependency Twitter Bootstrap. You probably want that:
```diff
diff --git a/app/addons/replication/assets/less/replication.less b/app/addons/replication/assets/less/replication.less
index 7966fe8..3836ea2 100644
--- a/app/addons/replication/assets/less/replication.less
+++ b/app/addons/replication/assets/less/replication.less
@@ -185,6 +185,10 @@
border-top: 1px solid @greyBrownLighter;
line-height: 30px;
font-size: 16px;
+ div.bar {
+ font-size: 16px;
+ line-height: 30px;
+ }
}
}
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Fix align for active tasks progress ...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/42#issuecomment-53395767
@kxepal it is so great having you contribute some fixes. Thanks. I'm +1 once you fix the nit that @robertkowalski pointed out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Fix align for active tasks progress ...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/42#issuecomment-53453693
^_^
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Fix align for active tasks progress ...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/42#issuecomment-53323839
I am not a designer, but looks good to me beside that small nit I commented on
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Fix align for active tasks progress ...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/42#issuecomment-53443206
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---