You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "He-Pin (via GitHub)" <gi...@apache.org> on 2024/03/29 17:40:38 UTC
[PR] chore: Refactor UnfoldResourceSourceAsync. [pekko]
He-Pin opened a new pull request, #1240:
URL: https://github.com/apache/pekko/pull/1240
Motivation:
Refactory UnfoldResourceSourceAsync without change the order of type parameter instead of https://github.com/apache/pekko/pull/616
Result:
Clean code and less allocation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Refactor UnfoldResourceSourceAsync. [pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1240:
URL: https://github.com/apache/pekko/pull/1240#issuecomment-2053955782
Thanks for the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Refactor UnfoldResourceSourceAsync. [pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin merged PR #1240:
URL: https://github.com/apache/pekko/pull/1240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Refactor UnfoldResourceSourceAsync. [pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #1240:
URL: https://github.com/apache/pekko/pull/1240#discussion_r1553969784
##########
stream/src/main/scala/org/apache/pekko/stream/impl/UnfoldResourceSourceAsync.scala:
##########
@@ -36,116 +38,116 @@ import pekko.stream.stage._
extends GraphStage[SourceShape[T]] {
val out = Outlet[T]("UnfoldResourceSourceAsync.out")
override val shape = SourceShape(out)
- override def initialAttributes: Attributes = DefaultAttributes.unfoldResourceSourceAsync
-
- def createLogic(inheritedAttributes: Attributes) = new GraphStageLogic(shape) with OutHandler {
- lazy val decider = inheritedAttributes.mandatoryAttribute[SupervisionStrategy].decider
- private implicit def ec: ExecutionContext = materializer.executionContext
- private var state: Option[S] = None
-
- private val createdCallback = getAsyncCallback[Try[S]] {
- case Success(resource) =>
- state = Some(resource)
- if (isAvailable(out)) onPull()
- case Failure(t) => failStage(t)
- }.invokeWithFeedback _
-
- private val errorHandler: PartialFunction[Throwable, Unit] = {
- case NonFatal(ex) =>
- decider(ex) match {
- case Supervision.Stop =>
- failStage(ex)
- case Supervision.Restart =>
- try {
- restartResource()
- } catch {
- case NonFatal(ex) => failStage(ex)
- }
- case Supervision.Resume => onPull()
- }
- }
+ override def initialAttributes: Attributes =
+ DefaultAttributes.unfoldResourceSourceAsync and SourceLocation.forLambda(create)
+
+ def createLogic(inheritedAttributes: Attributes) =
+ new GraphStageLogic(shape) with OutHandler {
+ private lazy val decider = inheritedAttributes.mandatoryAttribute[SupervisionStrategy].decider
+ private implicit def ec: ExecutionContext = materializer.executionContext
+ private var maybeResource: OptionVal[S] = OptionVal.none
+
+ private val createdCallback = getAsyncCallback[Try[S]] {
+ case Success(resource) =>
+ require(resource != null, "`create` method should not return a null resource.")
Review Comment:
the resource can be null, but can not now.
I think no one will returning a null resource
Maybe we should do the same in `unfoldResource`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org